Skip to content

Commit de898b6

Browse files
authored
add rule for breaking change detector (#36967)
1 parent 347c625 commit de898b6

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

scripts/breaking_changes_checker/breaking_changes_allowlist.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020
("ChangedParameterKind", "*", "*", "*", "filter"),
2121
("ChangedParameterKind", "*", "*", "*", "skip"),
2222
("RemovedOrRenamedPositionalParam", "*", "*", "*", "maxpagesize"),
23+
# msrest model bases on vendored _serialization.model instead of msrest.Model which no longer has "validate"
24+
("RemovedOrRenamedClassMethod", "*", "*", "validate"),
2325
# Changes due to not using msrest anymore
2426
("RemovedOrRenamedClassMethod", "*", "*", "as_dict"),
2527
("RemovedOrRenamedClassMethod", "*", "*", "deserialize"),

tools/azure-sdk-tools/packaging_tools/package_utils.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,10 +29,12 @@ def change_log_new(package_folder: str, lastest_pypi_version: bool) -> str:
2929
if lastest_pypi_version:
3030
cmd += "--latest-pypi-version"
3131
try:
32+
_LOGGER.info(f"Run breaking change detector with command: {cmd}")
3233
output = getoutput(cmd)
3334
except CalledProcessError as e:
3435
_LOGGER.warning(f"Error ocurred when call breaking change detector: {e.output.decode('utf-8')}")
3536
raise e
37+
_LOGGER.info(f"Breaking change detector output: {result}")
3638
result = [l for l in output.split("\n")]
3739
begin = result.index("===== changelog start =====")
3840
end = result.index("===== changelog end =====")

0 commit comments

Comments
 (0)