[SDK generation pipeline] multiapi package use old changelog tool (#36754)

* multiapi package use old changelog

* format

* fix

Author: msyyc

tools/azure-sdk-tools/packaging_tools/package_utils.py

@@ -40,7 +40,14 @@ def change_log_new(package_folder: str, lastest_pypi_version: bool) -> str:
     return "\n".join(result[begin + 1 : end]).strip()
 
 
-def change_log_generate(package_name, last_version, tag_is_stable: bool = False, *, prefolder: Optional[str] = None):
+def change_log_generate(
+    package_name,
+    last_version,
+    tag_is_stable: bool = False,
+    *,
+    prefolder: Optional[str] = None,
+    is_multiapi: bool = False,
+):
     from pypi_tools.pypi import PyPIClient
 
     client = PyPIClient()
@@ -57,7 +64,7 @@ def change_log_generate(package_name, last_version, tag_is_stable: bool = False,
         return "### Other Changes\n\n  - Initial version"
 
     # try new changelog tool
-    if prefolder:
+    if prefolder and not is_multiapi:
         try:
             return change_log_new(str(Path(prefolder) / package_name), not (last_stable_release and tag_is_stable))
         except Exception as e:

tools/azure-sdk-tools/packaging_tools/sdk_generator.py

@@ -8,6 +8,7 @@
 import shutil
 import re
 import os
+
 try:
     # py 311 adds this library natively
     import tomllib as toml
@@ -67,6 +68,7 @@ def multiapi_combiner(sdk_code_path: str, package_name: str):
     )
     check_call("pip install -e .", shell=True)
 
+
 @return_origin_path
 def after_multiapi_combiner(sdk_code_path: str, package_name: str, folder_name: str):
     toml_file = Path(sdk_code_path) / CONF_NAME
@@ -81,12 +83,14 @@ def after_multiapi_combiner(sdk_code_path: str, package_name: str, folder_name:
             # azure-mgmt-resource has subfolders
             subfolder_path = Path(sdk_code_path) / package_name.replace("-", "/")
             subfolders_name = [s.name for s in subfolder_path.iterdir() if s.is_dir() and not s.name.startswith("_")]
-            content["packaging"]["exclude_folders"] = ",".join([exclude(f"{package_name}-{s}") for s in subfolders_name])
+            content["packaging"]["exclude_folders"] = ",".join(
+                [exclude(f"{package_name}-{s}") for s in subfolders_name]
+            )
 
         with open(toml_file, "wb") as file_out:
             tomlw.dump(content, file_out)
         call_build_config(package_name, folder_name)
-        
+
         # remove .egg-info to reinstall package
         for item in Path(sdk_code_path).iterdir():
             if item.suffix == ".egg-info":
@@ -97,14 +101,20 @@ def after_multiapi_combiner(sdk_code_path: str, package_name: str, folder_name:
         _LOGGER.info(f"do not find {toml_file}")
 
 
-def del_outdated_files(readme: str):
+# readme: ../azure-rest-api-specs/specification/paloaltonetworks/resource-manager/readme.md or absolute path
+def get_readme_python_content(readme: str) -> List[str]:
     python_readme = Path(readme).parent / "readme.python.md"
     if not python_readme.exists():
         _LOGGER.info(f"do not find python configuration: {python_readme}")
-        return
+        return []
 
     with open(python_readme, "r") as file_in:
-        content = file_in.readlines()
+        return file_in.readlines()
+
+
+# readme: ../azure-rest-api-specs/specification/paloaltonetworks/resource-manager/readme.md
+def del_outdated_files(readme: str):
+    content = get_readme_python_content(readme)
     sdk_folder = extract_sdk_folder(content)
     is_multiapi = is_multiapi_package(content)
     if sdk_folder:
@@ -150,7 +160,7 @@ def get_related_swagger(readme_content: List[str], tag: str) -> List[str]:
 
 
 def get_last_commit_info(files: List[str]) -> str:
-    result = [getoutput(f'git log -1 --pretty="format:%ai %H" {f}').strip('\n ') + " " + f for f in files]
+    result = [getoutput(f'git log -1 --pretty="format:%ai %H" {f}').strip("\n ") + " " + f for f in files]
     result.sort()
     return result[-1]
 
@@ -199,7 +209,9 @@ def extract_version_info(config: Dict[str, Any]) -> str:
 def if_need_regenerate(meta: Dict[str, Any]) -> bool:
     with open(str(Path("../azure-sdk-for-python", CONFIG_FILE)), "r") as file_in:
         config = json.load(file_in)
-    current_info = config["meta"]["autorest_options"]["version"] + "".join(sorted(config["meta"]["autorest_options"]["use"]))
+    current_info = config["meta"]["autorest_options"]["version"] + "".join(
+        sorted(config["meta"]["autorest_options"]["use"])
+    )
     recorded_info = meta["autorest"] + "".join(sorted(meta["use"]))
     return recorded_info != current_info
 
@@ -327,6 +339,8 @@ def main(generate_input, generate_output):
                 package_entry["path"] = [folder_name]
                 package_entry[spec_word] = [input_readme]
                 package_entry["tagIsStable"] = not judge_tag_preview(sdk_code_path)
+                readme_python_content = get_readme_python_content(str(Path(spec_folder) / input_readme))
+                package_entry["isMultiapi"] = is_multiapi_package(readme_python_content)
                 result[package_name] = package_entry
             else:
                 result[package_name]["path"].append(folder_name)

tools/azure-sdk-tools/packaging_tools/sdk_package.py

@@ -30,7 +30,13 @@ def main(generate_input, generate_output):
         last_version = ["first release"]
         if "azure-mgmt-" in package_name:
             try:
-                md_output = change_log_generate(package_name, last_version, package["tagIsStable"], prefolder=prefolder)
+                md_output = change_log_generate(
+                    package_name,
+                    last_version,
+                    package["tagIsStable"],
+                    prefolder=prefolder,
+                    is_multiapi=package["isMultiapi"],
+                )
             except:
                 md_output = "change log generation failed!!!"
         else: