Skip to content

Commit f59f42c

Browse files
koen-mertenscbovijnceliabovijncatalinaperalta
authored
Radiology insights ga (#35276)
* Update tsp-location.yaml with latest commit id * regenerated SDK .\venv\Scripts\activate pip install -r dev_requirements.txt pip install tox<5 pip install -e . adjustments sample_critical_result_inference_async * inference * Adjusted README.md * adjustment tests fixes pylint * fix get result call on inferences inside job * implementation RadiologyInsightsInferenceResult in samples and tests * removed headers from test files * cspell updates & fix typos Update cspell file & fix some unknown words for typos * fix tests in record mode * fix spelling errors * fix spelling error * Update sample_finding_inference.py * Update sample_finding_inference.py * fix reviewer comments * add breaking changes to changelog and fix pylint issue * Update assets.json * Regenerated SDK for authentication, adjusted samples * Update CHANGELOG.md * fixing PR conversations * small cosmetic changes * Update README.md * refactor sample and adjust changelog * Update sample_age_mismatch_inference_async.py * adjust async samples according to review * Update README.md * fix tests for other packages * Update assets.json * Update assets.json * Update assets.json * regenerated SDK * disable healthinsights tests * disable cancerprofiling and trialmatcher test * disable tests * remove key based authentication from samples and documentation * fix tests * push recordings to assets * change sync to async cred * remove credentials sample and update documentation * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * Update sdk/healthinsights/azure-healthinsights-radiologyinsights/README.md Co-authored-by: catalinaperalta <[email protected]> * change samples and add a patch method * adjust tests * fix tests for radiology insights * - adjust def documentation in patch.py - remove unused imports in patch.py - resolve duplicate references in models.py - resolve duplicate and wrong references in README.md * - fix exception handling in samples - move imports in samples - fix pylint and mypy issues in patch files * remove class from sync samples replace deserialize with job iso inference result * - fix bugs sample_finding_inference.py - fix bugs sample_laterality_discrepancy_inference.py - adjust _operations * undo changes in patch files : replace deserialize Job with InferenceResult * - revert changes in _operations - replace with expected code in _patch * postprocess changes * revert _patch * fix pylint error in _operations.py fix mypy error in _patch.py (add ignore) * move ignore comment in _patch.py adjust sample_radiology_procedure_inference to align with the other samples adjust sample_radiology_procedure_inference_async to align with the other samples adjust sample_sex_mismatch_inference to align with the other samples adjust sample_sex_mismatch_inference_async to align with the other samples --------- Co-authored-by: cbovijn <[email protected]> Co-authored-by: Celia Bovijn <[email protected]> Co-authored-by: catalinaperalta <[email protected]>
1 parent 441319e commit f59f42c

File tree

54 files changed

+16178
-3734
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+16178
-3734
lines changed

‎.github/CODEOWNERS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@
164164

165165
# ServiceLabel: %Cognitive - Health Insights
166166
# PRLabel: %Cognitive - Health Insights
167-
/sdk/healthinsights/ @tomsft
167+
/sdk/healthinsights/ @tomsft @koen-mertens
168168

169169
# AzureSdkOwners: @mccoyp
170170
# ServiceLabel: %KeyVault

‎.vscode/cspell.json‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1818,7 +1818,12 @@
18181818
"Nify",
18191819
"loinc",
18201820
"wday",
1821-
"SNOMED"
1821+
"SNOMED",
1822+
"lobulated",
1823+
"pericholecystic",
1824+
"craniocaudally",
1825+
"angiomyolipomas",
1826+
"Omnipaque"
18221827
]
18231828
},
18241829
{

‎sdk/healthinsights/azure-healthinsights-cancerprofiling/assets.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "python",
44
"TagPrefix": "python/healthinsights/azure-healthinsights-cancerprofiling",
5-
"Tag": "python/healthinsights/azure-healthinsights-cancerprofiling_9de1430315"
5+
"Tag": "python/healthinsights/azure-healthinsights-cancerprofiling_4b8e4bf3ad"
66
}

‎sdk/healthinsights/azure-healthinsights-cancerprofiling/tests/test_cancer_profiling.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import functools
22
import json
33
import os
4+
import pytest
45

56
from azure.core.credentials import AzureKeyCredential
67
from azure.healthinsights.cancerprofiling import CancerProfilingClient
@@ -14,13 +15,13 @@
1415
HealthInsightsEnvPreparer = functools.partial(
1516
PowerShellPreparer,
1617
"healthinsights",
17-
healthinsights_endpoint="https://fake_ad_resource.cognitiveservices.azure.com/",
18+
healthinsights_endpoint="https://fake_ad_resource.cognitiveservices.azure.com",
1819
healthinsights_key="00000000000000000000000000000000",
1920
)
2021

2122

2223
class TestCancerProfiling(AzureRecordedTestCase):
23-
24+
@pytest.mark.skip
2425
@HealthInsightsEnvPreparer()
2526
@recorded_by_proxy
2627
def test_cancer_profiling(self, healthinsights_endpoint, healthinsights_key):

‎sdk/healthinsights/azure-healthinsights-clinicalmatching/assets.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,5 @@
22
"AssetsRepo": "Azure/azure-sdk-assets",
33
"AssetsRepoPrefixPath": "python",
44
"TagPrefix": "python/healthinsights/azure-healthinsights-clinicalmatching",
5-
"Tag": "python/healthinsights/azure-healthinsights-clinicalmatching_6b8e9da1f0"
5+
"Tag": "python/healthinsights/azure-healthinsights-clinicalmatching_76071d27f8"
66
}

‎sdk/healthinsights/azure-healthinsights-clinicalmatching/tests/conftest.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
@pytest.fixture(scope="session", autouse=True)
4242
def add_sanitizers(test_proxy):
4343
healthinsights_endpoint = os.environ.get(
44-
"HEALTHINSIGHTS_ENDPOINT", "https://fake_ad_resource.cognitiveservices.azure.com/"
44+
"HEALTHINSIGHTS_ENDPOINT", "https://fake_ad_resource.cognitiveservices.azure.com"
4545
)
4646
healthinsights_key = os.environ.get("HEALTHINSIGHTS_KEY", "00000000000000000000000000000000")
4747
add_general_regex_sanitizer(

‎sdk/healthinsights/azure-healthinsights-clinicalmatching/tests/test_match_trials.py‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
import functools
22
import json
3+
import pytest
4+
35

46
from azure.core.credentials import AzureKeyCredential
57
from azure.healthinsights.clinicalmatching import ClinicalMatchingClient
@@ -13,13 +15,13 @@
1315
HealthInsightsEnvPreparer = functools.partial(
1416
PowerShellPreparer,
1517
"healthinsights",
16-
healthinsights_endpoint="https://fake_ad_resource.cognitiveservices.azure.com/",
18+
healthinsights_endpoint="https://fake_ad_resource.cognitiveservices.azure.com",
1719
healthinsights_key="00000000000000000000000000000000",
1820
)
1921

2022

2123
class TestMatchTrials(AzureRecordedTestCase):
22-
24+
@pytest.mark.skip
2325
@HealthInsightsEnvPreparer()
2426
@recorded_by_proxy
2527
def test_match_trials(self, healthinsights_endpoint, healthinsights_key):

‎sdk/healthinsights/azure-healthinsights-radiologyinsights/CHANGELOG.md‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
11
# Release History
22

3-
## 1.0.0b2 (Unreleased)
3+
## 1.0.0 (Unreleased)
44

5-
### Features Added
5+
- GA release
66

77
### Breaking Changes
88

9-
### Bugs Fixed
10-
11-
### Other Changes
9+
- Unique ID required to be added in the request parameters
10+
- models.PatientInfo renamed into models.PatientDetails
11+
- models.Encounter renamed into models.PatientEncounter
12+
- models.RadiologyInsightsResult renamed into models.RadiologyInsightsJob
13+
- PatientDocument.created_date_time renamed into PatientDocument.created_at
14+
- FollowupCommunication.datetime renamed into FollowupCommunication.communicated_at
15+
- FollowupRecommendation.effective_date_time renamed into FollowupRecommendation.effective_at
1216

1317
## 1.0.0b1 (2024-03-01)
1418

0 commit comments

Comments
 (0)