Mypy Dev Requirement Installation Fix (#42973)

* python exe path fix

* add install_dev_reqs function

* remove print

* minor clean

* safety

* minor comment fix

Author: JennyPng

eng/tools/azure-sdk-tools/azpysdk/Check.py

@@ -4,10 +4,10 @@
 import traceback
 import sys
 import shutil
+import tempfile
 
 from typing import Sequence, Optional, List, Any, Tuple
-from subprocess import check_call
-
+from subprocess import CalledProcessError, check_call
 
 from ci_tools.parsing import ParsedSetup
 from ci_tools.functions import discover_targeted_packages, get_venv_call, install_into_venv, get_venv_python
@@ -111,3 +111,40 @@ def get_targeted_directories(self, args: argparse.Namespace) -> List[ParsedSetup
                     logger.error(traceback.format_exc())
 
         return targeted
+
+    def install_dev_reqs(self, executable: str, args: argparse.Namespace, package_dir: str) -> None:
+        """Install dev requirements for the given package."""
+        dev_requirements = os.path.join(package_dir, "dev_requirements.txt")
+
+        requirements = []
+        if os.path.exists(dev_requirements):
+            requirements += ["-r", dev_requirements]
+        else:
+            logger.warning(f"No dev_requirements.txt found for {package_dir}, skipping installation of dev requirements.")
+            return
+
+        temp_req_file = None
+        if not getattr(args, "isolate", False):
+            # don't install azure-sdk-tools when not isolated
+            with open(dev_requirements, "r") as f:
+                filtered_req_lines = [
+                    line.strip()
+                    for line in f 
+                    if "eng/tools/azure-sdk-tools" not in line
+                ]
+            with tempfile.NamedTemporaryFile(mode="w", delete=False) as temp_req_file:
+                temp_req_file.write("\n".join(filtered_req_lines))
+            if temp_req_file.name:
+                requirements = ["-r", temp_req_file.name]
+        try: 
+            logger.info(f"Installing dev requirements for {package_dir}")
+            install_into_venv(executable, requirements, package_dir)
+        except CalledProcessError as e:
+            logger.error("Failed to install dev requirements:", e)
+            raise e
+        finally:
+            if temp_req_file and temp_req_file.name:
+                try:
+                    os.remove(temp_req_file.name)
+                except Exception as cleanup_error:
+                    logger.warning(f"Failed to remove temporary requirements file: {cleanup_error}")

eng/tools/azure-sdk-tools/azpysdk/mypy.py

@@ -52,15 +52,13 @@ def run(self, args: argparse.Namespace) -> int:
         for parsed in targeted:
             package_dir = parsed.folder
             package_name = parsed.name
-            dev_requirements = os.path.join(package_dir, "dev_requirements.txt")
             additional_requirements = ADDITIONAL_LOCKED_DEPENDENCIES
 
             executable, staging_directory = self.get_executable(args.isolate, args.command, sys.executable, package_dir)
             logger.info(f"Processing {package_name} for mypy check")
 
             # # need to install dev_requirements to ensure that type-hints properly resolve
-            if os.path.exists(dev_requirements):
-                additional_requirements += ["-r", dev_requirements]
+            self.install_dev_reqs(executable, args, package_dir)
 
             # install mypy
             try:

eng/tools/azure-sdk-tools/ci_tools/functions.py

@@ -505,7 +505,8 @@ def get_venv_python(venv_path: str) -> str:
 
     # cross-platform python in a venv
     bin_dir = "Scripts" if os.name == "nt" else "bin"
-    return os.path.join(venv_path, bin_dir, "python")
+    python_exe =  "python.exe" if os.name == "nt" else "python"
+    return os.path.join(venv_path, bin_dir, python_exe)
 
 
 def install_into_venv(
@@ -526,7 +527,6 @@ def install_into_venv(
 
     if pip_cmd[0] == "uv":
         cmd += ["--python", py]
-
     # todo: clean this up so that we're using run_logged from #42862
     subprocess.check_call(cmd, cwd=working_directory)