Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Oct 9, 2025

Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433742 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68 Submitted by: [email protected]

Release Plan Details

@briantkim93 briantkim93 marked this pull request as ready for review October 16, 2025 07:48
Copilot AI review requested due to automatic review settings October 16, 2025 07:48
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the azure-mgmt-nginx SDK from AutoRest-generated code (API version 2024-11-01-preview) to Python Code Generator-generated code (API version 2025-03-01-preview). The update includes:

  • Migration from setup.py to pyproject.toml for build configuration
  • Addition of new WAF (Web Application Firewall) policy operations and models
  • Removal of hardcoded API version parameters from test files
  • Update of generated samples with new API version and standardized subscription ID placeholder

Reviewed Changes

Copilot reviewed 84 out of 86 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tsp-location.yaml Defines TypeSpec generation source (new API spec commit)
setup.py Removed in favor of pyproject.toml
sdk_packaging.toml Configuration moved to pyproject.toml
pyproject.toml Consolidated build and packaging configuration with new project metadata
generated_tests/*.py Updated code generator attribution and removed hardcoded API version parameters
generated_samples/*.py Updated API version references and subscription ID placeholders
azure/mgmt/nginx/operations/*.py Large operations files removed (regenerated by new code generator)
azure/mgmt/nginx/operations/init.py Updated imports to include new WAF policy operations
azure/mgmt/nginx/models/*.py Model definitions regenerated with new enums and WAF-related classes
azure/mgmt/nginx/_version.py Version bumped from 3.1.0b2 to 3.1.0b3
azure/mgmt/nginx/aio/* Async client files updated with new configuration and imports

@ChenxiJiang333
Copy link
Member

@msyyc, pr prepared, please help review

@msyyc msyyc self-requested a review November 7, 2025 03:31
Copy link
Member

@msyyc msyyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need regenerate from swagger.

@ChenxiJiang333
Copy link
Member

regenerated, please help review @msyyc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants