-
Notifications
You must be signed in to change notification settings - Fork 3.2k
[AutoPR azure-mgmt-nginx]-generated-from-SDK Generation - Python-5433742 #43314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…, API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433742 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the azure-mgmt-nginx SDK from AutoRest-generated code (API version 2024-11-01-preview) to Python Code Generator-generated code (API version 2025-03-01-preview). The update includes:
- Migration from setup.py to pyproject.toml for build configuration
- Addition of new WAF (Web Application Firewall) policy operations and models
- Removal of hardcoded API version parameters from test files
- Update of generated samples with new API version and standardized subscription ID placeholder
Reviewed Changes
Copilot reviewed 84 out of 86 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tsp-location.yaml | Defines TypeSpec generation source (new API spec commit) |
| setup.py | Removed in favor of pyproject.toml |
| sdk_packaging.toml | Configuration moved to pyproject.toml |
| pyproject.toml | Consolidated build and packaging configuration with new project metadata |
| generated_tests/*.py | Updated code generator attribution and removed hardcoded API version parameters |
| generated_samples/*.py | Updated API version references and subscription ID placeholders |
| azure/mgmt/nginx/operations/*.py | Large operations files removed (regenerated by new code generator) |
| azure/mgmt/nginx/operations/init.py | Updated imports to include new WAF policy operations |
| azure/mgmt/nginx/models/*.py | Model definitions regenerated with new enums and WAF-related classes |
| azure/mgmt/nginx/_version.py | Version bumped from 3.1.0b2 to 3.1.0b3 |
| azure/mgmt/nginx/aio/* | Async client files updated with new configuration and imports |
|
@msyyc, pr prepared, please help review |
msyyc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need regenerate from swagger.
… Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'd8f039ebd965e40471a082c547b103dd5dc9a33b' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5552189 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
|
regenerated, please help review @msyyc |
Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433742 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68 Submitted by: [email protected]
Release Plan Details
Spec pull request: Merge Nginx TypeSpec migration changes from RPSaaSMaster of private repo azure-rest-api-specs#37743
Spec API version: 2025-03-01-preview