address reasonable clippy lints from nightly (#841)

* address reasonable clippy lints from nightly

* fmt

Co-authored-by: Brian Caswell <[email protected]>

Author: bmc-msft

sdk/core/src/request_options/metadata.rs

@@ -48,7 +48,7 @@ impl Metadata {
         self.0.iter().map(|(key, value)| {
             Metadatum(
                 key.clone(),
-                std::str::from_utf8(&*value)
+                std::str::from_utf8(value)
                     .expect("non-utf8 header value")
                     .into(),
             )

sdk/data_cosmos/src/headers/from_headers.rs

@@ -144,15 +144,15 @@ pub(crate) fn schema_version_from_headers(headers: &Headers) -> azure_core::Resu
 }
 
 pub(crate) fn server_from_headers(headers: &Headers) -> azure_core::Result<&str> {
-    headers::get_str_from_headers(headers, &http::header::SERVER.to_string())
+    headers::get_str_from_headers(headers, http::header::SERVER.as_ref())
 }
 
 pub(crate) fn service_version_from_headers(headers: &Headers) -> azure_core::Result<&str> {
     headers::get_str_from_headers(headers, HEADER_SERVICE_VERSION)
 }
 
 pub(crate) fn content_location_from_headers(headers: &Headers) -> azure_core::Result<&str> {
-    headers::get_str_from_headers(headers, &http::header::CONTENT_LOCATION.to_string())
+    headers::get_str_from_headers(headers, http::header::CONTENT_LOCATION.as_ref())
 }
 
 pub(crate) fn gateway_version_from_headers(headers: &Headers) -> azure_core::Result<&str> {

sdk/messaging_servicebus/src/service_bus/mod.rs

@@ -147,13 +147,7 @@ async fn peek_lock_message(
 ) -> azure_core::Result<CollectedResponse> {
     let url = craft_peek_lock_url(namespace, queue, lock_expiry)?;
 
-    let req = prepare_request(
-        &url.to_string(),
-        Method::POST,
-        None,
-        policy_name,
-        signing_key,
-    )?;
+    let req = prepare_request(url.as_ref(), Method::POST, None, policy_name, signing_key)?;
 
     http_client
         .as_ref()
@@ -175,13 +169,7 @@ async fn peek_lock_message2(
 ) -> azure_core::Result<PeekLockResponse> {
     let url = craft_peek_lock_url(namespace, queue, lock_expiry)?;
 
-    let req = prepare_request(
-        &url.to_string(),
-        Method::POST,
-        None,
-        policy_name,
-        signing_key,
-    )?;
+    let req = prepare_request(url.as_ref(), Method::POST, None, policy_name, signing_key)?;
 
     let res = http_client.execute_request(&req).await?;
 

sdk/security_keyvault/src/lib.rs

@@ -14,7 +14,7 @@ mod tests {
     #[macro_export]
     macro_rules! mock_key_client {
         ($keyvault_name:expr, $creds:expr, ) => {{
-            crate::client::KeyClient {
+            $crate::client::KeyClient {
                 vault_url: url::Url::parse(&mockito::server_url()).unwrap(),
                 endpoint: "".to_string(),
                 token_credential: $creds,
@@ -25,7 +25,7 @@ mod tests {
     #[macro_export]
     macro_rules! mock_cert_client {
         ($keyvault_name:expr, $creds:expr, ) => {{
-            crate::client::CertificateClient {
+            $crate::client::CertificateClient {
                 vault_url: url::Url::parse(&mockito::server_url()).unwrap(),
                 endpoint: "".to_string(),
                 token_credential: $creds,

sdk/storage/src/core/clients/storage_account_client.rs

@@ -634,7 +634,7 @@ fn canonicalized_resource(account: &str, u: &url::Url) -> String {
 
     for p in paths {
         can_res.push('/');
-        can_res.push_str(&*p);
+        can_res.push_str(p);
     }
     can_res += "\n";
 

sdk/storage_datalake/src/authorization_policies/shared_key.rs

@@ -161,7 +161,7 @@ fn canonicalized_resource(account: &str, u: &url::Url) -> String {
 
     for p in paths {
         can_res.push('/');
-        can_res.push_str(&*p);
+        can_res.push_str(p);
     }
     can_res += "\n";
 

sdk/storage_datalake/src/file_system.rs

@@ -100,7 +100,7 @@ mod tests {
     #[test]
     fn test_path_serialization() {
         let payload = json!({
-            "contentLength": 100 as i64,
+            "contentLength": 100_i64,
             "etag": "etag",
             "group": "group",
             "isDirectory": true,