Remove fs module (#2877)

* Remove fs module

Resolves #2860 and resolves #2318

* Also remove dependency on tokio/io-util

Author: heaths

sdk/core/azure_core/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Release History
 
+## 0.28.0 (Unreleased)
+
+### Breaking Changes
+
+- Removed the `fs` module including the `FileStream` and `FileStreamBuilder` types. Moved to `examples/` for `typespec_client_core` to copy if needed.
+
 ## 0.27.0 (2025-08-01)
 
 ### Features Added

sdk/core/azure_core/src/fs/mod.rs

@@ -11,7 +11,6 @@ mod macros;
 
 mod constants;
 pub mod credentials;
-pub mod fs;
 pub mod hmac;
 pub mod http;
 

sdk/core/azure_core/src/lib.rs

@@ -1,5 +1,11 @@
 # Release History
 
+## 0.7.0 (Unreleased)
+
+### Breaking Changes
+
+- Removed the `fs` module including the `FileStream` and `FileStreamBuilder` types. Moved to `examples/` to copy if needed.
+
 ## 0.6.0 (2025-08-01)
 
 ### Features Added

sdk/typespec/typespec_client_core/CHANGELOG.md

@@ -39,7 +39,7 @@ getrandom.workspace = true
 tokio = { workspace = true, features = ["macros", "rt", "time"] }
 
 [dev-dependencies]
-tokio.workspace = true
+tokio = { workspace = true, features = ["fs"] }
 tracing.workspace = true
 tracing-subscriber.workspace = true
 typespec_macros.path = "../typespec_macros"
@@ -58,13 +58,9 @@ reqwest_rustls = [
   "reqwest/rustls-tls-native-roots-no-provider",
 ] # Remove dependency on banned `ring` crate; requires manually configuring crypto provider.
 test = [] # Enables extra tracing including error bodies that may contain PII.
-tokio = ["tokio/fs", "tokio/sync", "tokio/time", "tokio/io-util"]
+tokio = ["tokio/sync", "tokio/time"]
 xml = ["dep:quick-xml"]
 
-[[example]]
-name = "core_binary_data_request"
-required-features = ["tokio"]
-
 [[example]]
 name = "core_stream_response"
 required-features = ["derive"]

sdk/typespec/typespec_client_core/Cargo.toml

@@ -1,11 +1,6 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
-use crate::{
-    http::{Body, RequestContent},
-    setters,
-    stream::{SeekableStream, DEFAULT_BUFFER_SIZE},
-};
 use futures::{task::Poll, Future};
 use std::{cmp::min, io::SeekFrom, pin::Pin, sync::Arc, task::Context};
 use tokio::{
@@ -14,6 +9,12 @@ use tokio::{
     sync::Mutex,
 };
 use tracing::debug;
+use typespec_client_core::{
+    error::Result,
+    http::{Body, RequestContent},
+    setters,
+    stream::{SeekableStream, DEFAULT_BUFFER_SIZE},
+};
 
 #[derive(Debug)]
 pub struct FileStreamBuilder {
@@ -45,7 +46,7 @@ impl FileStreamBuilder {
         buffer_size: usize => Some(buffer_size),
     }
 
-    pub async fn build(mut self) -> crate::Result<FileStream> {
+    pub async fn build(mut self) -> Result<FileStream> {
         let stream_size = self.handle.metadata().await?.len();
 
         let buffer_size = self.buffer_size.unwrap_or(DEFAULT_BUFFER_SIZE);
@@ -102,7 +103,7 @@ impl FileStream {
     /// `stream_size`
     ///
     /// This is useful if you want to read the stream in multiple blocks
-    pub async fn next_block(&mut self) -> crate::Result<()> {
+    pub async fn next_block(&mut self) -> Result<()> {
         debug!("setting limit to {}", self.block_size);
         let mut handle = self.handle.clone().lock_owned().await;
         {
@@ -120,7 +121,7 @@ impl SeekableStream for FileStream {
     /// Seek to the specified offset into the file and reset the number of bytes to read
     ///
     /// This is useful upon encountering an error to reset the stream to the last
-    async fn reset(&mut self) -> crate::Result<()> {
+    async fn reset(&mut self) -> Result<()> {
         debug!(
             "resetting stream to offset {} and limit to {}",
             self.offset, self.block_size

sdk/typespec/typespec_client_core/src/fs/tokio.rs renamed to sdk/typespec/typespec_client_core/examples/common/fs.rs

@@ -0,0 +1,4 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+pub mod fs;

sdk/typespec/typespec_client_core/examples/common/mod.rs

@@ -1,10 +1,13 @@
 // Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT License.
 
+mod common;
+
+use common::fs::FileStreamBuilder;
 use tokio::fs;
 use tracing::level_filters::LevelFilter;
 use tracing_subscriber::fmt::format::FmtSpan;
-use typespec_client_core::{fs::FileStreamBuilder, http::RequestContent};
+use typespec_client_core::http::RequestContent;
 
 #[tokio::main]
 async fn main() -> Result<(), Box<dyn std::error::Error>> {

sdk/typespec/typespec_client_core/examples/core_binary_data_request.rs

@@ -10,7 +10,6 @@ pub mod async_runtime;
 pub mod base64;
 pub mod error;
 pub mod fmt;
-pub mod fs;
 #[cfg(feature = "http")]
 pub mod http;
 #[cfg(feature = "json")]