address clippy 0.1.56 lints (#436)

Author: bmc-msft

sdk/core/src/headers/mod.rs

@@ -73,9 +73,10 @@ pub fn add_optional_header2<T: AddAsHeader>(
     item: &Option<T>,
     request: &mut crate::Request,
 ) -> Result<(), crate::errors::HTTPHeaderError> {
-    Ok(if let Some(item) = item {
+    if let Some(item) = item {
         item.add_as_header2(request)?
-    })
+    }
+    Ok(())
 }
 
 #[must_use]

sdk/core/src/headers/utilities.rs

@@ -156,9 +156,9 @@ where
     T: std::str::FromStr,
     T::Err: Into<ParsingError>,
 {
-    Ok(get_str_from_headers(headers, key)?
+    get_str_from_headers(headers, key)?
         .parse()
-        .map_err(|e: T::Err| Error::ParsingError(e.into()))?)
+        .map_err(|e: T::Err| Error::ParsingError(e.into()))
 }
 
 pub fn get_option_from_headers<T>(headers: &HeaderMap, key: &str) -> Result<Option<T>, Error>

sdk/core/src/http_client.rs

@@ -166,7 +166,7 @@ impl HttpClient for reqwest::Client {
         request: &crate::Request,
     ) -> Result<crate::Response, HttpError> {
         let mut reqwest_request = self.request(
-            request.method().clone(),
+            request.method(),
             url::Url::parse(&request.uri().to_string()).unwrap(),
         );
         for header in request.headers() {

sdk/core/src/macros.rs

@@ -26,6 +26,8 @@
 #[macro_export]
 macro_rules! setters {
     (@single $name:ident : $typ:ty => $transform:expr) => {
+        #[allow(clippy::redundant_field_names)]
+        #[allow(clippy::needless_update)]
         // TODO: Declare using idiomatic with_$name when https://github.com/Azure/azure-sdk-for-rust/issues/292 is resolved.
         pub fn $name<T: ::std::convert::Into<$typ>>(self, $name: T) -> Self {
             let $name: $typ = $name.into();

sdk/core/src/policies/retry_policies/exponential_retry.rs

@@ -65,7 +65,7 @@ where
                 Ok(response) => return Ok(response),
                 Err(error) => {
                     log::error!("Error occurred when making request: {}", error);
-                    if self.is_expired(&mut first_retry_time, &mut current_retries) {
+                    if self.is_expired(&mut first_retry_time, &current_retries) {
                         return Err(error);
                     } else {
                         current_retries += 1;

sdk/core/src/policies/retry_policies/fixed_retry.rs

@@ -64,7 +64,7 @@ where
                 Ok(response) => return Ok(response),
                 Err(error) => {
                     log::error!("Error occurred when making request: {}", error);
-                    if self.is_expired(&mut first_retry_time, &mut current_retries) {
+                    if self.is_expired(&mut first_retry_time, &current_retries) {
                         return Err(error);
                     } else {
                         current_retries += 1;

sdk/core/src/policies/telemetry_policy.rs

@@ -32,7 +32,7 @@ impl<'a> TelemetryPolicy {
         rustc_version: Option<&'a str>,
         options: &TelemetryOptions,
     ) -> Self {
-        const UNKNOWN: &'static str = "unknown";
+        const UNKNOWN: &str = "unknown";
         let mut crate_name = crate_name.unwrap_or(UNKNOWN);
         let crate_version = crate_version.unwrap_or(UNKNOWN);
         let rustc_version = rustc_version.unwrap_or(UNKNOWN);

sdk/core/src/request.rs

@@ -21,7 +21,7 @@ impl From<Box<dyn SeekableStream>> for Body {
     }
 }
 
-const FIELDS: &'static [&'static str] = &["uri", "method", "headers", "body"];
+const FIELDS: &[&str] = &["uri", "method", "headers", "body"];
 
 /// A pipeline request.
 ///

sdk/core/src/request_options/delimiter.rs

@@ -11,7 +11,7 @@ impl<'a> Delimiter<'a> {
 
 impl<'a> AppendToUrlQuery for Delimiter<'a> {
     fn append_to_url_query(&self, url: &mut url::Url) {
-        url.query_pairs_mut().append_pair("delimiter", &self.0);
+        url.query_pairs_mut().append_pair("delimiter", self.0);
     }
 }
 

sdk/core/src/request_options/prefix.rs

@@ -11,7 +11,7 @@ impl<'a> Prefix<'a> {
 
 impl<'a> AppendToUrlQuery for Prefix<'a> {
     fn append_to_url_query(&self, url: &mut url::Url) {
-        url.query_pairs_mut().append_pair("prefix", &self.0);
+        url.query_pairs_mut().append_pair("prefix", self.0);
     }
 }