Skip to content

Commit 9ba8eaf

Browse files
authored
Add missing conditional headers to blob and container operations (#1280)
1 parent dcf7738 commit 9ba8eaf

File tree

12 files changed

+55
-9
lines changed

12 files changed

+55
-9
lines changed

sdk/storage_blobs/src/blob/operations/acquire_lease.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ operation! {
77
client: BlobClient,
88
lease_duration: LeaseDuration,
99
?lease_id: LeaseId,
10-
?proposed_lease_id: ProposedLeaseId
10+
?proposed_lease_id: ProposedLeaseId,
11+
?if_modified_since: IfModifiedSinceCondition,
12+
?if_match: IfMatchCondition,
13+
?if_tags: IfTags
1114
}
1215

1316
impl AcquireLeaseBuilder {
@@ -22,6 +25,9 @@ impl AcquireLeaseBuilder {
2225
headers.add(self.lease_duration);
2326
headers.add(self.proposed_lease_id);
2427
headers.add(self.lease_id);
28+
headers.add(self.if_modified_since);
29+
headers.add(self.if_match);
30+
headers.add(self.if_tags);
2531

2632
let mut request =
2733
self.client

sdk/storage_blobs/src/blob/operations/change_lease.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ operation! {
66
ChangeLease,
77
client: BlobLeaseClient,
88
proposed_lease_id: ProposedLeaseId,
9+
?if_modified_since: IfModifiedSinceCondition,
10+
?if_match: IfMatchCondition,
11+
?if_tags: IfTags
912
}
1013

1114
impl ChangeLeaseBuilder {
@@ -19,6 +22,9 @@ impl ChangeLeaseBuilder {
1922
headers.insert(LEASE_ACTION, "change");
2023
headers.add(self.client.lease_id());
2124
headers.add(self.proposed_lease_id);
25+
headers.add(self.if_modified_since);
26+
headers.add(self.if_match);
27+
headers.add(self.if_tags);
2228

2329
let mut request =
2430
self.client

sdk/storage_blobs/src/blob/operations/get_page_ranges.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ use time::OffsetDateTime;
66
operation! {
77
GetPageRanges,
88
client: BlobClient,
9-
?if_modified_since: IfModifiedSinceCondition,
9+
?if_modified_since: IfModifiedSinceCondition,
1010
?if_match: IfMatchCondition,
1111
?if_tags: IfTags,
1212
?blob_versioning: BlobVersioning,

sdk/storage_blobs/src/blob/operations/put_block_blob.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ operation! {
1616
?access_tier: AccessTier,
1717
?tags: Tags,
1818
?lease_id: LeaseId,
19-
?encryption_scope: EncryptionScope
19+
?encryption_scope: EncryptionScope,
20+
?if_modified_since: IfModifiedSinceCondition,
21+
?if_match: IfMatchCondition,
22+
?if_tags: IfTags
2023
}
2124

2225
impl PutBlockBlobBuilder {
@@ -40,6 +43,9 @@ impl PutBlockBlobBuilder {
4043
headers.add(self.access_tier);
4144
headers.add(self.lease_id);
4245
headers.add(self.encryption_scope);
46+
headers.add(self.if_modified_since);
47+
headers.add(self.if_match);
48+
headers.add(self.if_tags);
4349

4450
let mut request = self.client.finalize_request(
4551
url,

sdk/storage_blobs/src/blob/operations/put_block_list.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ operation! {
1616
?metadata: Metadata,
1717
?access_tier: AccessTier,
1818
?tags: Tags,
19-
?lease_id: LeaseId
19+
?lease_id: LeaseId,
20+
?if_modified_since: IfModifiedSinceCondition,
21+
?if_match: IfMatchCondition,
22+
?if_tags: IfTags
2023
}
2124

2225
impl PutBlockListBuilder {
@@ -51,6 +54,9 @@ impl PutBlockListBuilder {
5154
}
5255
headers.add(self.access_tier);
5356
headers.add(self.lease_id);
57+
headers.add(self.if_modified_since);
58+
headers.add(self.if_match);
59+
headers.add(self.if_tags);
5460

5561
let mut request = self.client.finalize_request(
5662
url,

sdk/storage_blobs/src/blob/operations/release_lease.rs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
11
use crate::prelude::*;
2-
use azure_core::{headers::*, RequestId};
2+
use azure_core::{headers::*, prelude::*, RequestId};
33
use time::OffsetDateTime;
44

55
operation! {
66
ReleaseLease,
77
client: BlobLeaseClient,
8+
?if_modified_since: IfModifiedSinceCondition,
9+
?if_match: IfMatchCondition,
10+
?if_tags: IfTags
811
}
912

1013
impl ReleaseLeaseBuilder {
@@ -17,6 +20,9 @@ impl ReleaseLeaseBuilder {
1720
let mut headers = Headers::new();
1821
headers.insert(LEASE_ACTION, "release");
1922
headers.add(self.client.lease_id());
23+
headers.add(self.if_modified_since);
24+
headers.add(self.if_match);
25+
headers.add(self.if_tags);
2026

2127
let mut request =
2228
self.client

sdk/storage_blobs/src/blob/operations/renew_lease.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@ use time::OffsetDateTime;
55
operation! {
66
RenewLease,
77
client: BlobLeaseClient,
8+
?if_modified_since: IfModifiedSinceCondition,
9+
?if_match: IfMatchCondition,
10+
?if_tags: IfTags
811
}
912

1013
impl RenewLeaseBuilder {
@@ -17,6 +20,9 @@ impl RenewLeaseBuilder {
1720
let mut headers = Headers::new();
1821
headers.insert(LEASE_ACTION, "renew");
1922
headers.add(self.client.lease_id());
23+
headers.add(self.if_modified_since);
24+
headers.add(self.if_match);
25+
headers.add(self.if_tags);
2026

2127
let mut request =
2228
self.client

sdk/storage_blobs/src/blob/operations/set_blob_tier.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ operation! {
77
client: BlobClient,
88
access_tier: AccessTier,
99
?rehydrate_priority: RehydratePriority,
10-
?blob_versioning: BlobVersioning
10+
?blob_versioning: BlobVersioning,
11+
?if_tags: IfTags
1112
}
1213

1314
impl SetBlobTierBuilder {
@@ -23,6 +24,7 @@ impl SetBlobTierBuilder {
2324
self.rehydrate_priority
2425
.unwrap_or(RehydratePriority::Standard),
2526
);
27+
headers.add(self.if_tags);
2628

2729
let mut request =
2830
self.client

sdk/storage_blobs/src/blob/operations/snapshot_blob.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ operation! {
1414
?metadata: Metadata,
1515
?if_modified_since: IfModifiedSinceCondition,
1616
?if_match: IfMatchCondition,
17+
?if_tags: IfTags,
1718
?lease_id: LeaseId
1819
}
1920

@@ -28,6 +29,7 @@ impl SnapshotBlobBuilder {
2829
headers.add(self.lease_id);
2930
headers.add(self.if_modified_since);
3031
headers.add(self.if_match);
32+
headers.add(self.if_tags);
3133
if let Some(metadata) = &self.metadata {
3234
for m in metadata.iter() {
3335
headers.add(m);

sdk/storage_blobs/src/container/operations/break_lease.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,8 @@ operation! {
77
BreakLease,
88
client: ContainerClient,
99
?lease_break_period: LeaseBreakPeriod,
10-
?lease_id: LeaseId
10+
?lease_id: LeaseId,
11+
?if_modified_since: IfModifiedSinceCondition
1112
}
1213

1314
impl BreakLeaseBuilder {
@@ -22,6 +23,7 @@ impl BreakLeaseBuilder {
2223
headers.insert(LEASE_ACTION, "break");
2324
headers.add(self.lease_id);
2425
headers.add(self.lease_break_period);
26+
headers.add(self.if_modified_since);
2527

2628
let mut request = self
2729
.client

0 commit comments

Comments
 (0)