Always set RUSTFLAGS=-Dwarnings (#2260)

* Always set RUSTFLAGS=-Dwarnings

Also removes some old scripts that no longer apply (for old legacy directory structure).

* Use correct Azure Pipelines syntax

I was thinking of GitHub Actions. Also adds dummy file like in #2253.

* Refactor into top-level pipeline

All CI and PR pipelines extend from this, so this should work as global variables. Also emits some info in relevant scripts.

* Remove -Dwarnings test

Also moves `azure_data_cosmos`'s `default` feature last given what @hallipr found with Tomlyn, which PSToml uses, which we use for publishing scripts currently.

Author: heaths

eng/pipelines/templates/stages/archetype-rust-release.yml

@@ -29,6 +29,7 @@ stages:
         variables:
         - template: /eng/pipelines/templates/variables/globals.yml
         - template: /eng/pipelines/templates/variables/image.yml
+        - template: /eng/pipelines/templates/variables/rust.yml
 
         pool:
           name: $(LINUXPOOL)

eng/pipelines/templates/stages/archetype-sdk-client.yml

@@ -19,6 +19,7 @@ extends:
     - stage: Build
       variables:
       - template: /eng/pipelines/templates/variables/image.yml
+      - template: /eng/pipelines/templates/variables/rust.yml
       jobs:
       - template: /eng/pipelines/templates/jobs/ci.yml
         parameters:

eng/pipelines/templates/variables/rust.yml

@@ -0,0 +1,3 @@
+variables:
+  RUSTFLAGS: "-Dwarnings"
+  RUSTDOCFLAGS: "-Dwarnings"

eng/scripts/Analyze-Code.ps1

@@ -13,11 +13,12 @@ Set-StrictMode -Version 2.0
 
 . (Join-Path $PSScriptRoot '..' 'common' 'scripts' 'common.ps1')
 
-Write-Host "Analyzing code with
-    Toolchain: '$Toolchain'`n"
-
-$env:RUSTDOCFLAGS = "-D warnings"
-$env:RUSTFLAGS = "-Dwarnings"
+Write-Host @"
+Analyzing code with
+    Toolchain: '$Toolchain'
+    RUSTFLAGS: '${env:RUSTFLAGS}'
+    RUSTDOCFLAGS: '${env:RUSTDOCFLAGS}'
+"@
 
 if ($CheckWasm) {
   Invoke-LoggedCommand "rustup target add --toolchain $Toolchain wasm32-unknown-unknown"

eng/scripts/Pack-Crates.ps1

@@ -13,6 +13,11 @@ $ErrorActionPreference = 'Stop'
 
 . (Join-Path $PSScriptRoot '..' 'common' 'scripts' 'common.ps1')
 
+Write-Host @"
+Packing crates with
+    RUSTFLAGS: '${env:RUSTFLAGS}'
+"@
+
 if ($OutputPath) {
   $OutputPath = New-Item -ItemType Directory -Path $OutputPath -Force | Select-Object -ExpandProperty FullName
 }
@@ -76,7 +81,7 @@ function Get-PackagesToBuild() {
 
   # We start with output packages, then recursively add unreleased dependencies to the list of packages that need to be built
   [array]$packagesToBuild = $packages | Where-Object { $outputPackageNames.Contains($_.name) }
-  
+
   $toProcess = $packagesToBuild
   while ($toProcess.Length -gt 0) {
     $package = $toProcess[0]
@@ -89,14 +94,14 @@ function Get-PackagesToBuild() {
       }
     }
   }
-  
+
   $buildOrder = @()
 
   # Then we order the packages to that dependencies are built first
   while ($packagesToBuild.Count -gt 0) {
     # Pick any package with no unreleased dependencies, add it to the build order and remove it from the list of other packages' unreleased dependencies
     $package = $packagesToBuild | Where-Object { $_.UnreleasedDependencies.Count -eq 0 } | Select-Object -First 1
-    
+
     if (-not $package) {
       Write-Error "These packages cannot be built because they depend on unreleased dependencies that aren't being built." -ErrorAction Continue
       foreach ($package in $packagesToBuild) {
@@ -150,7 +155,7 @@ function Add-PathVersions($packages) {
 
     foreach ($name in $toml.dependencies.Keys) {
       # we want to look at the dependency as it was resolved by `cargo metadata`
-      # this will resolve workspace depdencies, but retain their path/no-version state 
+      # this will resolve workspace depdencies, but retain their path/no-version state
       $dependency = $package.dependencies | Where-Object -Property name -EQ -Value $name | Select-Object -First 1
       # If the dependency is a path dependency, set the version to the version of the package in the workspace
       if ($dependency.path -and !$dependency.version) {

eng/scripts/Test-Packages.ps1

@@ -11,9 +11,13 @@ Set-StrictMode -Version 2.0
 
 . "$PSScriptRoot\..\common\scripts\common.ps1"
 
-Write-Host "Testing packages with
+Write-Host @"
+Testing packages with
     Toolchain: '$Toolchain'
-    PackageInfoDirectory: '$PackageInfoDirectory'"
+    PackageInfoDirectory: '$PackageInfoDirectory'
+    RUSTFLAGS: '${env:RUSTFLAGS}'
+    RUSTDOCFLAGS: '${env:RUSTDOCFLAGS}'
+"@
 
 if ($PackageInfoDirectory) {
   if (!(Test-Path $PackageInfoDirectory)) {
@@ -34,9 +38,6 @@ foreach ($package in $packagesToTest) {
   Write-Host "  '$($package.Name)' in '$($package.DirectoryPath)'"
 }
 
-Write-Host "Setting RUSTFLAGS to '-Dwarnings'"
-$env:RUSTFLAGS = "-Dwarnings"
-
 foreach ($package in $packagesToTest) {
   Push-Location ([System.IO.Path]::Combine($RepoRoot, $package.DirectoryPath))
   try {