Skip to content

Commit c16148b

Browse files
authored
Add Format parameter to RequestContent (#2844)
* Add Format parameter to RequestContent This provides parity with `Response<T, F: Format>` so that the client clearly dictates the request serialization format. * Serialize decimals as float
1 parent 4bccdbd commit c16148b

File tree

17 files changed

+289
-185
lines changed

17 files changed

+289
-185
lines changed

.vscode/cspell.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@
7272
"rustup",
7373
"seekable",
7474
"servicebus",
75+
"spector",
7576
"stylesheet",
7677
"subclient",
7778
"telemetered",

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ reqwest = { version = "0.12.22", features = [
103103
"json",
104104
"stream",
105105
], default-features = false }
106-
rust_decimal = "1.37.2"
106+
rust_decimal.version = "1.37.2"
107107
rustc_version = "0.4"
108108
serde = { version = "1.0", features = ["derive"] }
109109
serde_amqp = { version = "0.14", features = ["uuid"] }

sdk/core/azure_core/Cargo.toml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ default = [
5656
]
5757
azurite_workaround = []
5858
debug = ["typespec_client_core/debug"]
59+
decimal = ["typespec_client_core/decimal"]
5960
hmac_openssl = ["dep:openssl"]
6061
hmac_rust = ["dep:sha2", "dep:hmac"]
6162
reqwest = ["typespec_client_core/reqwest"]
@@ -72,6 +73,7 @@ workspace = true
7273
[package.metadata.docs.rs]
7374
features = [
7475
"debug",
76+
"decimal",
7577
"hmac_openssl",
7678
"hmac_rust",
7779
"reqwest",

sdk/storage/azure_storage_blob/CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
### Breaking Changes
88

9+
* Changed `RequestContent<T>` models in client methods to `RequestContent<T, XmlFormat>` to provide parity with `Response<T, XmlFormat>`.
10+
911
### Bugs Fixed
1012

1113
### Other Changes

sdk/storage/azure_storage_blob/src/clients/block_blob_client.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ impl BlockBlobClient {
9595
/// * `options` - Optional configuration for the request.
9696
pub async fn commit_block_list(
9797
&self,
98-
blocks: RequestContent<BlockLookupList>,
98+
blocks: RequestContent<BlockLookupList, XmlFormat>,
9999
options: Option<BlockBlobClientCommitBlockListOptions<'_>>,
100100
) -> Result<Response<BlockBlobClientCommitBlockListResult, NoFormat>> {
101101
self.client.commit_block_list(blocks, options).await

sdk/storage/azure_storage_blob/src/generated/clients/blob_client.rs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/azure_storage_blob/src/generated/clients/blob_container_client.rs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/azure_storage_blob/src/generated/clients/blob_service_client.rs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/azure_storage_blob/src/generated/clients/block_blob_client.rs

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sdk/storage/azure_storage_blob/src/generated/models/models_impl.rs

Lines changed: 10 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)