use the StorageCredentials helpers instead of using the enum variants directly (#1420)

Author: demoray

sdk/data_tables/README.md

@@ -29,7 +29,7 @@ async fn main() -> azure_core::Result<()> {
         std::env::var("STORAGE_ACCESS_KEY").expect("Set env variable STORAGE_ACCESS_KEY first!");
     let table_name = std::env::var("STORAGE_TABLE_NAME").expect("Set env variable STORAGE_TABLE_NAME first!");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let table_service = TableServiceClient::new(account, storage_credentials);
 
     let table_client = table_service.table_client(table_name);

sdk/data_tables/examples/table.rs

@@ -27,7 +27,7 @@ async fn main() -> azure_core::Result<()> {
         .nth(1)
         .expect("please specify the table name as first command line parameter");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let table_service = TableServiceClient::new(account, storage_credentials);
 
     let table_client = table_service.table_client(table_name);

sdk/data_tables/src/lib.rs

@@ -28,7 +28,7 @@ async fn main() -> azure_core::Result<()> {
         std::env::var("STORAGE_ACCESS_KEY").expect("Set env variable STORAGE_ACCESS_KEY first!");
     let table_name = std::env::var("STORAGE_TABLE_NAME").expect("Set env variable STORAGE_TABLE_NAME first!");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let table_service = TableServiceClient::new(account, storage_credentials);
 
     let table_client = table_service.table_client(table_name);

sdk/storage/src/connection_string.rs

@@ -1,6 +1,5 @@
-use azure_core::error::{Error, ErrorKind, ResultExt};
-
 use crate::StorageCredentials;
+use azure_core::error::{Error, ErrorKind};
 
 // Key names.
 pub const ACCOUNT_KEY_KEY_NAME: &str = "AccountKey";
@@ -188,15 +187,13 @@ impl<'a> ConnectionString<'a> {
                 if self.account_key.is_some() {
                     log::warn!("Both account key and SAS defined in connection string. Using only the provided SAS.");
                 }
-                Ok(StorageCredentials::SASToken(get_sas_token_parms(
-                    sas_token,
-                )?))
+                StorageCredentials::sas_token(*sas_token)
             }
             ConnectionString {
                 account_name: Some(account),
                 account_key: Some(key),
                 ..
-            } =>  Ok(StorageCredentials::Key((*account).to_string(), (*key).to_string())),
+            } =>  Ok(StorageCredentials::access_key(*account, *key)),
            _ => {
                 Err(Error::message(ErrorKind::Credential,
                     "Could not create a `StorageCredentail` from the provided connection string. Please validate that you have specified a means of authentication (key, SAS, etc.)."
@@ -206,30 +203,6 @@ impl<'a> ConnectionString<'a> {
     }
 }
 
-fn get_sas_token_parms(sas_token: &str) -> azure_core::Result<Vec<(String, String)>> {
-    // Any base url will do: we just need to parse the SAS token
-    // to get its query pairs.
-    let base_url = url::Url::parse("https://blob.core.windows.net").unwrap();
-
-    let url = url::Url::options().base_url(Some(&base_url));
-
-    // this code handles the leading ?
-    // we support both with or without
-    let url = if sas_token.starts_with('?') {
-        url.parse(sas_token)
-    } else {
-        url.parse(&format!("?{sas_token}"))
-    }
-    .with_context(ErrorKind::DataConversion, || {
-        format!("failed to parse SAS token: {sas_token}")
-    })?;
-
-    Ok(url
-        .query_pairs()
-        .map(|p| (String::from(p.0), String::from(p.1)))
-        .collect())
-}
-
 #[cfg(test)]
 mod tests {
     #[allow(unused_imports)]

sdk/storage_blobs/README.md

@@ -21,7 +21,7 @@ async fn main() -> azure_core::Result<()> {
     let container = std::env::var("STORAGE_CONTAINER").expect("missing STORAGE_CONTAINER");
     let blob_name = std::env::var("STORAGE_BLOB_NAME").expect("missing STORAGE_BLOB_NAME");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let blob_client = ClientBuilder::new(account, storage_credentials).blob_client(&container, blob_name);
 
     blob_client.put_block_blob("hello world").content_type("text/plain").await?;

sdk/storage_blobs/examples/account.rs

@@ -10,7 +10,7 @@ async fn main() -> azure_core::Result<()> {
     let access_key =
         std::env::var("STORAGE_ACCESS_KEY").expect("Set env variable STORAGE_ACCESS_KEY first!");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let service_client = BlobServiceClient::new(account, storage_credentials);
 
     let account = service_client.get_account_information().await?;

sdk/storage_blobs/examples/anonymous_access.rs

@@ -8,7 +8,7 @@ async fn main() -> azure_core::Result<()> {
     let account = std::env::var("STORAGE_ACCOUNT").expect("Set env variable STORAGE_ACCOUNT");
     let container = std::env::var("STORAGE_CONTAINER").expect("Set env variable STORAGE_CONTAINER");
 
-    let storage_credentials = StorageCredentials::Anonymous;
+    let storage_credentials = StorageCredentials::anonymous();
     let container_client =
         BlobServiceClient::new(account, storage_credentials).container_client(container);
 

sdk/storage_blobs/examples/blob_00.rs

@@ -20,7 +20,7 @@ async fn main() -> azure_core::Result<()> {
         .nth(2)
         .expect("please specify blob name as command line parameter");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let service_client = BlobServiceClient::new(account, storage_credentials);
 
     // this is how you would use the SAS token:

sdk/storage_blobs/examples/blob_01.rs

@@ -16,7 +16,7 @@ async fn main() -> azure_core::Result<()> {
         .nth(1)
         .expect("please specify container name as command line parameter");
 
-    let storage_credentials = StorageCredentials::Key(account.clone(), access_key);
+    let storage_credentials = StorageCredentials::access_key(account.clone(), access_key);
     let service_client = BlobServiceClient::new(account, storage_credentials);
     let container_client = service_client.container_client(container_name);
     let blob_client = container_client.blob_client("SorgeniaReorganizeRebuildIndexes.zip");

sdk/storage_blobs/examples/blob_02_bearer_token.rs

@@ -21,7 +21,7 @@ async fn main() -> azure_core::Result<()> {
         .nth(4)
         .expect("please specify the bearer token as fourth command line parameter");
 
-    let storage_credentials = StorageCredentials::BearerToken(bearer_token);
+    let storage_credentials = StorageCredentials::bearer_token(bearer_token);
     let blob_client = BlobServiceClient::new(account, storage_credentials)
         .container_client(&container)
         .blob_client(&blob);