Review feedback: Don't enable allowCompoundWords, also release_ names can include name separators

Author: danieljurek

.vscode/cspell.json

@@ -2,7 +2,6 @@
   "version": "0.2",
   "language": "en",
   "useGitignore": true,
-  "allowCompoundWords": true,
   "ignorePaths": [
     "**/test-resources.bicep",
     "**/test-resources.json",
@@ -142,52 +141,91 @@
   "overrides": [
     {
       "filename": "**/Cargo.toml",
-      "dictionaries": ["crates", "rust-custom"]
+      "dictionaries": [
+        "crates",
+        "rust-custom"
+      ]
     },
     {
       "filename": "**/*.md",
-      "dictionaries": ["crates", "rust", "rust-custom"],
-      "ignoreRegExpList": ["@\\w+"]
+      "dictionaries": [
+        "crates",
+        "rust",
+        "rust-custom"
+      ],
+      "ignoreRegExpList": [
+        "@\\w+"
+      ]
     },
     {
       "filename": "**/*.rs",
-      "dictionaries": ["crates", "rust-custom"]
+      "dictionaries": [
+        "crates",
+        "rust-custom"
+      ]
     },
     {
       "filename": "sdk/core/azure_core_amqp/**",
-      "dictionaries": ["crates", "rust-custom", "azure_core_amqp"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "azure_core_amqp"
+      ]
     },
     {
       "filename": "sdk/eventhubs/**",
-      "dictionaries": ["crates", "rust-custom", "eventhubs"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "eventhubs"
+      ]
     },
     {
       "filename": "sdk/identity/**",
-      "dictionaries": ["crates", "rust-custom", "identity"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "identity"
+      ]
     },
     {
       "filename": "sdk/keyvault/**",
-      "dictionaries": ["crates", "rust-custom", "keyvault"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "keyvault"
+      ]
     },
     {
       "filename": "sdk/typespec/**",
-      "flagWords": ["azure", "azurite"]
+      "flagWords": [
+        "azure",
+        "azurite"
+      ]
     },
     {
       "filename": "sdk/cosmos/**",
-      "dictionaries": ["crates", "rust-custom", "cosmos"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "cosmos"
+      ]
     },
     {
       "filename": "sdk/servicebus/**",
-      "dictionaries": ["crates", "rust-custom", "servicebus"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "servicebus"
+      ]
     },
     {
       "filename": "sdk/storage/**",
-      "dictionaries": ["crates", "rust-custom", "storage"]
-    },
-    {
-      "filename": "sdk/*/ci.yml",
-      "ignoreWords": ["azurecoreamqp"]
+      "dictionaries": [
+        "crates",
+        "rust-custom",
+        "storage"
+      ]
     }
   ]
 }

sdk/canary/ci.yml

@@ -11,11 +11,11 @@ trigger:
     - sdk/canary/
 
 parameters:
-- name: release_azurecanarycore
+- name: release_azure_canary_core
   displayName: 'azure_canary_core'
   type: boolean
   default: true
-- name: release_azurecanary
+- name: release_azure_canary
   displayName: 'azure_canary'
   type: boolean
   default: true
@@ -26,8 +26,6 @@ extends:
     ServiceDirectory: canary
     Artifacts:
     - name: azure_canary_core
-      safeName: AzureCanaryCore
-      releaseInBatch: ${{ parameters.release_azurecanarycore }}
+      releaseInBatch: ${{ parameters.release_azure_canary_core }}
     - name: azure_canary
-      safeName: AzureCanary
-      releaseInBatch: ${{ parameters.release_azurecanary }}
+      releaseInBatch: ${{ parameters.release_azure_canary }}

sdk/core/ci.yml

@@ -11,19 +11,19 @@ trigger:
     - sdk/core/
 
 parameters:
-- name: release_azurecore
+- name: release_azure_core
   displayName: 'azure_core'
   type: boolean
   default: true
-- name: release_azurecoremacros
+- name: release_azure_core_macros
   displayName: 'azure_core_macros'
   type: boolean
   default: true
-- name: release_azurecoreamqp
+- name: release_azure_core_amqp
   displayName: 'azure_core_amqp'
   type: boolean
   default: true
-- name: release_azurecoreopentelemetry
+- name: release_azure_core_opentelemetry
   displayName: 'azure_core_opentelemetry'
   type: boolean
   default: true
@@ -34,14 +34,10 @@ extends:
     ServiceDirectory: core
     Artifacts:
     - name: azure_core
-      safeName: AzureCore
-      releaseInBatch: ${{ parameters.release_azurecore }}
+      releaseInBatch: ${{ parameters.release_azure_core }}
     - name: azure_core_macros
-      safeName: AzureCoreMacros
-      releaseInBatch: ${{ parameters.release_azurecoremacros }}
+      releaseInBatch: ${{ parameters.release_azure_core_macros }}
     - name: azure_core_amqp
-      safeName: AzureCoreAmqp
-      releaseInBatch: ${{ parameters.release_azurecoreamqp }}
+      releaseInBatch: ${{ parameters.release_azure_core_amqp }}
     - name: azure_core_opentelemetry
-      safeName: AzureCoreOpentelemetry
-      releaseInBatch: ${{ parameters.release_azurecoreopentelemetry }}
+      releaseInBatch: ${{ parameters.release_azure_core_opentelemetry }}

sdk/cosmos/ci.yml

@@ -11,7 +11,7 @@ trigger:
     - sdk/cosmos/
 
 parameters:
-- name: release_azuredatacosmos
+- name: release_azure_data_cosmos
   displayName: 'azure_data_cosmos'
   type: boolean
   default: true
@@ -22,5 +22,4 @@ extends:
     ServiceDirectory: cosmos
     Artifacts:
     - name: azure_data_cosmos
-      safeName: AzureDataCosmos
-      releaseInBatch: ${{ parameters.release_azuredatacosmos }}
+      releaseInBatch: ${{ parameters.release_azure_data_cosmos }}

sdk/eventhubs/ci.yml

@@ -11,11 +11,11 @@ trigger:
     - sdk/eventhubs/
 
 parameters:
-- name: release_azuremessagingeventhubs
+- name: release_azure_messaging_eventhubs
   displayName: 'azure_messaging_eventhubs'
   type: boolean
   default: true
-- name: release_azuremessagingeventhubscheckpointstoreblob
+- name: release_azure_messaging_eventhubs_checkpointstore_blob
   displayName: 'azure_messaging_eventhubs_checkpointstore_blob'
   type: boolean
   default: true
@@ -26,8 +26,6 @@ extends:
     ServiceDirectory: eventhubs
     Artifacts:
     - name: azure_messaging_eventhubs
-      safeName: AzureMessagingEventHubs
-      releaseInBatch: ${{ parameters.release_azuremessagingeventhubs }}
+      releaseInBatch: ${{ parameters.release_azure_messaging_eventhubs }}
     - name: azure_messaging_eventhubs_checkpointstore_blob
-      safeName: AzureMessagingEventHubsBlobCheckpointStore
-      releaseInBatch: ${{ parameters.release_azuremessagingeventhubscheckpointstoreblob }}
+      releaseInBatch: ${{ parameters.release_azure_messaging_eventhubs_checkpointstore_blob }}

sdk/identity/ci.yml

@@ -11,7 +11,7 @@ trigger:
     - sdk/identity/
 
 parameters:
-- name: release_azureidentity
+- name: release_azure_identity
   displayName: 'azure_identity'
   type: boolean
   default: true
@@ -22,8 +22,7 @@ extends:
     ServiceDirectory: identity
     Artifacts:
       - name: azure_identity
-        safeName: AzureIdentity
-        releaseInBatch: ${{ parameters.release_azureidentity }}
+        releaseInBatch: ${{ parameters.release_azure_identity }}
 
     ${{ if endsWith(variables['Build.DefinitionName'], 'weekly') }}:
       Location: uksouth

sdk/keyvault/ci.yml

@@ -14,15 +14,15 @@ parameters:
   displayName: 'Run live tests'
   type: boolean
   default: false
-- name: release_azuresecuritykeyvaultsecrets
+- name: release_azure_security_keyvault_secrets
   displayName: 'azure_security_keyvault_secrets'
   type: boolean
   default: true
-- name: release_azuresecuritykeyvaultkeys
+- name: release_azure_security_keyvault_keys
   displayName: 'azure_security_keyvault_keys'
   type: boolean
   default: true
-- name: release_azuresecuritykeyvaultcertificates
+- name: release_azure_security_keyvault_certificates
   displayName: 'azure_security_keyvault_certificates'
   type: boolean
   default: true
@@ -34,11 +34,8 @@ extends:
     RunLiveTests: ${{ or(parameters.RunLiveTests, eq(variables['Build.Reason'], 'Schedule')) }}
     Artifacts:
     - name: azure_security_keyvault_secrets
-      safeName: AzureSecurityKeyvaultSecrets
-      releaseInBatch: ${{ parameters.release_azuresecuritykeyvaultsecrets }}
+      releaseInBatch: ${{ parameters.release_azure_security_keyvault_secrets }}
     - name: azure_security_keyvault_keys
-      safeName: AzureSecurityKeyvaultKeys
-      releaseInBatch: ${{ parameters.release_azuresecuritykeyvaultkeys }}
+      releaseInBatch: ${{ parameters.release_azure_security_keyvault_keys }}
     - name: azure_security_keyvault_certificates
-      safeName: AzureSecurityKeyvaultCertificates
-      releaseInBatch: ${{ parameters.release_azuresecuritykeyvaultcertificates }}
+      releaseInBatch: ${{ parameters.release_azure_security_keyvault_certificates }}

sdk/servicebus/ci.yml

@@ -12,7 +12,7 @@ trigger:
     - sdk/servicebus/
 
 parameters:
-- name: release_azuremessagingservicebus
+- name: release_azure_messaging_servicebus
   displayName: 'azure_messaging_servicebus'
   type: boolean
   default: true
@@ -23,5 +23,4 @@ extends:
     ServiceDirectory: servicebus
     Artifacts:
     - name: azure_messaging_servicebus
-      safeName: AzureMessagingServiceBus
-      releaseInBatch: ${{ parameters.release_azuremessagingservicebus }}
+      releaseInBatch: ${{ parameters.release_azure_messaging_servicebus }}

sdk/storage/ci.yml

@@ -14,15 +14,15 @@ parameters:
   displayName: 'Run live tests'
   type: boolean
   default: false
-- name: release_azurestoragecommon
+- name: release_azure_storage_common
   displayName: 'azure_storage_common'
   type: boolean
   default: true
-- name: release_azurestorageblob
+- name: release_azure_storage_blob
   displayName: 'azure_storage_blob'
   type: boolean
   default: true
-- name: release_azurestoragequeue
+- name: release_azure_storage_queue
   displayName: 'azure_storage_queue'
   type: boolean
   default: true
@@ -35,11 +35,8 @@ extends:
     TestTimeoutInMinutes: 120
     Artifacts:
     - name: azure_storage_common
-      safeName: AzureStorageCommon
-      releaseInBatch: ${{ parameters.release_azurestoragecommon }}
+      releaseInBatch: ${{ parameters.release_azure_storage_common }}
     - name: azure_storage_blob
-      safeName: AzureStorageBlob
-      releaseInBatch: ${{ parameters.release_azurestorageblob }}
+      releaseInBatch: ${{ parameters.release_azure_storage_blob }}
     - name: azure_storage_queue
-      safeName: AzureStorageQueue
-      releaseInBatch: ${{ parameters.release_azurestoragequeue }}
+      releaseInBatch: ${{ parameters.release_azure_storage_queue }}

sdk/typespec/ci.yml

@@ -15,11 +15,11 @@ parameters:
   displayName: 'typespec'
   type: boolean
   default: true
-- name: release_typespecmacros
+- name: release_release_typespecmacros
   displayName: 'typespec_macros'
   type: boolean
   default: true
-- name: release_typespecclientcore
+- name: release_typespec_client_core
   displayName: 'typespec_client_core'
   type: boolean
   default: true
@@ -30,11 +30,8 @@ extends:
     ServiceDirectory: typespec
     Artifacts:
     - name: typespec
-      safeName: Typespec
       releaseInBatch: ${{ parameters.release_typespec }}
     - name: typespec_macros
-      safeName: TypespecMacros
-      releaseInBatch: ${{ parameters.release_typespecmacros }}
+      releaseInBatch: ${{ parameters.release_release_typespecmacros }}
     - name: typespec_client_core
-      safeName: TypespecClientCore
-      releaseInBatch: ${{ parameters.release_typespecclientcore }}
+      releaseInBatch: ${{ parameters.release_typespec_client_core }}