Skip to content

Commit dd6e335

Browse files
Sync eng/common directory with azure-sdk-tools for PR 9896 (#2212)
* Remove trailing slash addition to ExcludePaths * Remove the needless loop and, now defunct, comment --------- Co-authored-by: James Suplizio <[email protected]>
1 parent 4ba692b commit dd6e335

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

eng/common/scripts/Package-Properties.ps1

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -185,14 +185,7 @@ function Get-PrPkgProperties([string]$InputDiffJson) {
185185
$targetedFiles += $diff.DeletedFiles
186186
}
187187

188-
# The exclude paths and the targeted files paths aren't full OS paths, they're
189-
# GitHub paths meaning they're relative to the repo root and slashes are forward
190-
# slashes "/". The ExcludePaths need to have a trailing slash added in order
191-
# correctly test for string matches without overmatching. For example, if a pr
192-
# had files sdk/foo/file1 and sdk/foobar/file2 with the exclude of anything in
193-
# sdk/foo, it should only exclude things under sdk/foo. The TrimEnd is just in
194-
# case one of the paths ends with a slash, it doesn't add a second one.
195-
$excludePaths = $diff.ExcludePaths | ForEach-Object { $_.TrimEnd("/") + "/" }
188+
$excludePaths = $diff.ExcludePaths
196189

197190
$additionalValidationPackages = @()
198191
$lookup = @{}

0 commit comments

Comments
 (0)