Fixes scheduled pipeline (#1671)

* Fixes scheduled pipeline

Fixes #1670

* Always set no_clippy

Author: heaths

.github/workflows/build.yml

@@ -114,18 +114,18 @@ jobs:
         experimental:
           - false
         include:
+          - no_clippy: false
           - build: nightly
-            clippy: false
+            no_clippy: ${{ github.event_name != 'scheduled' }}
             experimental: true
-          - clippy: true
     steps:
       - uses: actions/checkout@v4
       - uses: Swatinem/rust-cache@v2
         with:
           workspaces: services
-      - run: echo "NO_CLIPPY=true" >> $GITHUB_ENV
-        if: github.event_name != 'schedule' && ! matrix.clippy
       - run: eng/scripts/services_tests.sh ${{ matrix.build }}
+        env:
+          NO_CLIPPY: ${{ matrix.no_clippy }}
       - name: display free disk space
         run: df -h /
         if: ${{ always() }}

eng/scripts/services_tests.sh

@@ -12,7 +12,7 @@ rustup component add rustfmt clippy --toolchain ${BUILD}
 export RUSTFLAGS="-Dwarnings -Aunreachable-code -Aunused-assignments -Adead-code -Aclippy::new-without-default -Aclippy::unnecessary_to_owned"
 cargo +${BUILD} check --manifest-path services/Cargo.toml --all
 cargo +${BUILD} check --manifest-path services/Cargo.toml --examples
-if [ -z $NO_CLIPPY ]; then
+if [[ $NO_CLIPPY != 'true' ]]; then
     cargo +${BUILD} clippy --manifest-path services/Cargo.toml --all
 fi
 cargo +${BUILD} fmt --manifest-path services/Cargo.toml --all -- --check