-
Notifications
You must be signed in to change notification settings - Fork 229
Open
Labels
APIViewIssues related to APIView core functionality or UIIssues related to APIView core functionality or UIJavascriptPull requests that update Javascript codePull requests that update Javascript codeneeds-triageWorkflow: This is a new issue that needs to be triaged to the appropriate team.Workflow: This is a new issue that needs to be triaged to the appropriate team.
Description
Two Tasks:
Task 1:
Implemented a simple intersperse helper we could use that instead of doing the same check everywhere.
The idea would be:
const typeParameterTokens = typeParameters.map(<logic to map to review tokens>).intersperse(createToken(TokenKind.Text, ",", { hasSuffixSpace: true, deprecated }))
Or something along those lines. Not for this PR, but we could do a cleanup pass separately
The basic idea:
- Build an array of ReviewToken
- call
interspersegetting a new array - tokens.push(result of [2])
Originally posted by @maorleger in #13453 (comment)
Task 2:
let copilot extract a helper function and centralize this typeParameter rendering logic. #13516 (comment)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
APIViewIssues related to APIView core functionality or UIIssues related to APIView core functionality or UIJavascriptPull requests that update Javascript codePull requests that update Javascript codeneeds-triageWorkflow: This is a new issue that needs to be triaged to the appropriate team.Workflow: This is a new issue that needs to be triaged to the appropriate team.
Type
Projects
Status
🆕 New