Fix #579 - correct error message (#580)

Fixes #579
For an empty list do not throw argument null exception

Author: SeanFeldman

src/Microsoft.Azure.ServiceBus/Core/MessageReceiver.cs

@@ -97,7 +97,7 @@ public MessageReceiver(
             {
                 throw Fx.Exception.ArgumentNullOrWhiteSpace(connectionString);
             }
-            
+
             this.OwnsConnection = true;
         }
 
@@ -158,7 +158,7 @@ internal MessageReceiver(
             string sessionId = null,
             bool isSessionReceiver = false)
             : base(nameof(MessageReceiver), entityPath, retryPolicy ?? RetryPolicy.Default)
-        {        
+        {
             MessagingEventSource.Log.MessageReceiverCreateStart(serviceBusConnection?.Endpoint.Authority, entityPath, receiveMode.ToString());
 
             if (string.IsNullOrWhiteSpace(entityPath))
@@ -512,7 +512,7 @@ public async Task CompleteAsync(IEnumerable<string> lockTokens)
             var lockTokenList = lockTokens.ToList();
             if (lockTokenList.Count == 0)
             {
-                throw Fx.Exception.ArgumentNull(nameof(lockTokens));
+                throw Fx.Exception.Argument(nameof(lockTokens), Resources.ListOfLockTokensCannotBeEmty);
             }
 
             MessagingEventSource.Log.MessageCompleteStart(this.ClientId, lockTokenList.Count, lockTokenList);
@@ -1523,13 +1523,13 @@ async Task<ReceivingAmqpLink> CreateLinkAsync(TimeSpan timeout)
             var endpointUri = new Uri(this.ServiceBusConnection.Endpoint, this.Path);
             var claims = new[] { ClaimConstants.Listen };
             var amqpSendReceiveLinkCreator = new AmqpSendReceiveLinkCreator(
-                this.Path, 
-                this.ServiceBusConnection, 
-                endpointUri, 
-                new string[] { endpointUri.AbsoluteUri }, 
-                claims, 
-                this.CbsTokenProvider, 
-                amqpLinkSettings, 
+                this.Path,
+                this.ServiceBusConnection,
+                endpointUri,
+                new string[] { endpointUri.AbsoluteUri },
+                claims,
+                this.CbsTokenProvider,
+                amqpLinkSettings,
                 this.ClientId);
 
             Tuple<AmqpObject, DateTime> linkDetails = await amqpSendReceiveLinkCreator.CreateAndOpenAmqpLinkAsync().ConfigureAwait(false);
@@ -1561,13 +1561,13 @@ async Task<RequestResponseAmqpLink> CreateRequestResponseLinkAsync(TimeSpan time
             var endpointUri = new Uri(this.ServiceBusConnection.Endpoint, entityPath);
             string[] claims = { ClaimConstants.Manage, ClaimConstants.Listen };
             var amqpRequestResponseLinkCreator = new AmqpRequestResponseLinkCreator(
-                entityPath, 
-                this.ServiceBusConnection, 
+                entityPath,
+                this.ServiceBusConnection,
                 endpointUri,
                 new string[] { endpointUri.AbsoluteUri },
-                claims, 
-                this.CbsTokenProvider, 
-                amqpLinkSettings, 
+                claims,
+                this.CbsTokenProvider,
+                amqpLinkSettings,
                 this.ClientId);
 
             var linkDetails = await amqpRequestResponseLinkCreator.CreateAndOpenAmqpLinkAsync().ConfigureAwait(false);

src/Microsoft.Azure.ServiceBus/Resources.Designer.cs

@@ -159,6 +159,9 @@
   <data name="TokenMissingExpiresOn" xml:space="preserve">
     <value>The provided token does not specify the 'ExpiresOn' value.</value>
   </data>
+  <data name="ListOfLockTokensCannotBeEmty" xml:space="preserve">
+    <value>List of lock tokens cannot be empty</value>
+  </data>
   <data name="NotSupportedPropertyType" xml:space="preserve">
     <value>'{0}' is not a supported type.</value>
   </data>