Fix linting issues on main (#4236)

* Add tests and refactor getTestName

* Rename test recording

* Delete Test_Network.Frontdoor_v1api_CreationAndDeletion.yaml

* Remove use of ioutil

* Remove use of strings.Title()

* Update test file

Author: theunrepentantgeek

v2/internal/controllers/recordings/Test_Samples_CreationAndDeletion/Test_Network.Frontdoor_v1api_CreationAndDeletion.yaml

@@ -14,6 +14,8 @@ import (
 	"testing"
 
 	. "github.com/onsi/gomega"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 	v1 "k8s.io/api/core/v1"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 
@@ -187,11 +189,58 @@ func findRefsAndCreateSecrets(tc *testcommon.KubePerTestContext, resources []cli
 }
 
 func getTestName(group string, version string) string {
-	return strings.Join(
-		[]string{
-			"Test",
-			strings.Title(group),
-			version,
-			"CreationAndDeletion",
-		}, "_")
+	var result strings.Builder
+
+	// Common Prefix
+	result.WriteString("Test_")
+
+	// Titlecase for each part of the group
+	title := cases.Title(language.English)
+	for _, part := range strings.Split(group, ".") {
+		result.WriteString(title.String(part))
+	}
+	result.WriteString("_")
+
+	// Append the version
+	result.WriteString(version)
+
+	// Common Suffix
+	result.WriteString("_CreationAndDeletion")
+
+	return result.String()
+}
+
+func TestGetTestName(t *testing.T) {
+	t.Parallel()
+
+	cases := map[string]struct {
+		group    string
+		version  string
+		expected string
+	}{
+		"simple": {
+			group:    "group",
+			version:  "version",
+			expected: "Test_Group_version_CreationAndDeletion",
+		},
+		"Network": {
+			group:    "network",
+			version:  "v1api",
+			expected: "Test_Network_v1api_CreationAndDeletion",
+		},
+		"Frontdoor": {
+			group:    "network.frontdoor",
+			version:  "v1api",
+			expected: "Test_NetworkFrontdoor_v1api_CreationAndDeletion",
+		},
+	}
+
+	for name, c := range cases {
+		c := c
+		t.Run(name, func(t *testing.T) {
+			t.Parallel()
+			g := NewGomegaWithT(t)
+			g.Expect(getTestName(c.group, c.version)).To(Equal(c.expected))
+		})
+	}
 }

v2/internal/controllers/recordings/Test_Samples_CreationAndDeletion/Test_NetworkFrontdoor_v1api_CreationAndDeletion.yaml

@@ -6,7 +6,7 @@
 package main
 
 import (
-	"io/ioutil"
+	"os"
 	"strings"
 	"unicode"
 
@@ -41,7 +41,7 @@ func NewGenTypesCommand() (*cobra.Command, error) {
 
 			if debugMode != nil && *debugMode != "" {
 				var tmpDir string
-				tmpDir, err = ioutil.TempDir("", createDebugPrefix(*debugMode))
+				tmpDir, err = os.MkdirTemp("", createDebugPrefix(*debugMode))
 				if err != nil {
 					log.Error(err, "Error creating temporary directory")
 					return err

v2/internal/controllers/samples_test.go

@@ -12,6 +12,8 @@ import (
 	"unicode"
 
 	"github.com/Azure/azure-service-operator/v2/internal/set"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 // \W is all non-word characters (https://golang.org/pkg/regexp/syntax/)
@@ -176,18 +178,13 @@ func (factory *identifierFactory) cleanPart(part string, visibility Visibility)
 	clean := filterRegex.ReplaceAllLiteralString(part, " ")
 	cleanWords := sliceIntoWords(clean)
 	caseCorrectedWords := make([]string, 0, len(cleanWords))
+	title := cases.Title(language.English, cases.NoLower)
 	for ix, word := range cleanWords {
 		var w string
 		if ix == 0 && visibility == NotExported {
 			w = strings.ToLower(word)
 		} else {
-			// Disable lint: the suggested "replacement" for this in /x/cases has fundamental
-			// differences in how it works (e.g. 'JSON' becomes 'Json'; we don’t want that).
-			// Furthermore, the cases (ha) that it "fixes" are not relevant to us
-			// (something about better handling of various punctuation characters;
-			// our words are punctuation-free).
-			//nolint:staticcheck
-			w = strings.Title(word)
+			w = title.String(word)
 		}
 
 		caseCorrectedWords = append(caseCorrectedWords, w)

v2/tools/generator/gen_types.go

@@ -9,7 +9,6 @@ import (
 	"bufio"
 	"context"
 	"io"
-	"io/ioutil"
 	"os"
 	"path/filepath"
 	"sort"
@@ -200,7 +199,7 @@ func deleteEmptyDirectories(ctx context.Context, path string) error {
 			return ctx.Err()
 		}
 
-		files, err := ioutil.ReadDir(dir)
+		files, err := os.ReadDir(dir)
 		if err != nil {
 			errs = append(errs, errors.Wrapf(err, "error reading directory %q", dir))
 		}

v2/tools/generator/internal/astmodel/identifier_factory.go

@@ -6,7 +6,7 @@
 package kustomization
 
 import (
-	"io/ioutil"
+	"os"
 
 	"github.com/pkg/errors"
 	"gopkg.in/yaml.v3"
@@ -85,7 +85,7 @@ func (p *ConversionPatchFile) Save(destination string) error {
 		return errors.Wrap(err, "serializing to yaml")
 	}
 
-	err = ioutil.WriteFile(destination, data, 0o644) // #nosec G306
+	err = os.WriteFile(destination, data, 0o644) // #nosec G306
 	if err != nil {
 		return errors.Wrapf(err, "writing to %s", destination)
 	}

v2/tools/generator/internal/codegen/pipeline/delete_generated_code.go

@@ -6,7 +6,7 @@
 package kustomization
 
 import (
-	"io/ioutil"
+	"os"
 
 	"github.com/pkg/errors"
 	"gopkg.in/yaml.v3"
@@ -57,7 +57,7 @@ func (k *CRDKustomizeFile) Save(destination string) error {
 		return errors.Wrap(err, "serializing to yaml")
 	}
 
-	err = ioutil.WriteFile(destination, data, 0o644) // #nosec G306
+	err = os.WriteFile(destination, data, 0o644) // #nosec G306
 	if err != nil {
 		return errors.Wrapf(err, "writing to %s", destination)
 	}

v2/tools/generator/internal/kustomization/conversion_patch_file.go

@@ -6,7 +6,7 @@
 package kustomization
 
 import (
-	"io/ioutil"
+	"os"
 
 	"github.com/pkg/errors"
 	"gopkg.in/yaml.v3"
@@ -17,7 +17,7 @@ type ResourceDefinition struct {
 }
 
 func LoadResourceDefinition(filePath string) (*ResourceDefinition, error) {
-	fileBytes, err := ioutil.ReadFile(filePath)
+	fileBytes, err := os.ReadFile(filePath)
 	if err != nil {
 		return nil, errors.Wrapf(err, "reading resource definition from %s", filePath)
 	}