Update secret generation rune values (#4205)

super-harsh · web-flow · commit c684c0d5df42 · 2024-08-23T16:30:53.000Z
diff --git a/v2/internal/controllers/crd_redhatopenshift_openshiftcluster_20230401_test.go b/v2/internal/controllers/crd_redhatopenshift_openshiftcluster_20230401_test.go
@@ -34,10 +34,6 @@ func Test_RedHatOpenShift_OpenShiftCluster_CRUD(t *testing.T) {
 	t.Parallel()
 	t.Skip("flaky right now")
 
-	if *isLive {
-		t.Skip("ARO cluster test requires ServicePrincipal creation and referenced in the cluster object.")
-	}
-
 	tc := globalTestContext.ForTest(t)
 	rg := tc.CreateTestResourceGroupAndWait()
 
diff --git a/v2/internal/testcommon/resource_namer.go b/v2/internal/testcommon/resource_namer.go
@@ -145,7 +145,7 @@ func (n ResourceNamer) GeneratePassword() string {
 	return n.GeneratePasswordOfLength(n.randomChars)
 }
 
-var runes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~!@#$%^&*()")
+var runes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~!@#$%^*()._-")
 
 // GeneratePasswordOfLength generates and returns a non-deterministic password.
 // This method does not use any seed value, so the returned password is never stable.

Original file line number	Diff line number	Diff line change
`@@ -145,7 +145,7 @@ func (n ResourceNamer) GeneratePassword() string {`
`145`	`145`	`return n.GeneratePasswordOfLength(n.randomChars)`
`146`	`146`	`}`
`147`	`147`
`148`		`-var runes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~!@#$%^&*()")`
	`148`	`+var runes = []rune("abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789~!@#$%^*()._-")`
`149`	`149`
`150`	`150`	`// GeneratePasswordOfLength generates and returns a non-deterministic password.`
`151`	`151`	`// This method does not use any seed value, so the returned password is never stable.`