Improve diagnostics from TypeTransformers (#4937)

* Add tests

* Fix wrong check called

* Code gardening

* Require full match from TypeMatcher

* Fix ineffective property removal of CustomerManagedKeyStatus

* Add ignore for generator with default name

Author: theunrepentantgeek

.gitignore

@@ -84,3 +84,4 @@ hack/tools
 v2/controller
 v2/cmd/asoctl/asoctl
 v2/tools/generator/aso-gen
+v2/tools/generator/generator

v2/api/documentdb/v1api20210515/storage/database_account_types_gen.go

@@ -208,7 +208,7 @@ DatabaseAccount_Spec: Object (6 properties)
 │   └── "Parse"
 ├── Location: *string
 ├── Name: string
-├── Properties: *Object (31 properties)
+├── Properties: *Object (30 properties)
 │   ├── AnalyticalStorageConfiguration: *Object (1 property)
 │   │   └── SchemaType: *Enum (2 values)
 │   │       ├── "FullFidelity"
@@ -281,7 +281,6 @@ DatabaseAccount_Spec: Object (6 properties)
 │   ├── CreateMode: *Enum (2 values)
 │   │   ├── "Default"
 │   │   └── "Restore"
-│   ├── CustomerManagedKeyStatus: *string
 │   ├── DatabaseAccountOfferType: *Enum (1 value)
 │   │   └── "Standard"
 │   ├── DefaultIdentity: *string

v2/api/documentdb/v1api20231115/arm/database_account_spec_types_gen.go

@@ -6,7 +6,7 @@ APIVersion: Enum (1 value)
 
 DatabaseAccount: Resource
 ├── Owner: resources/v1apiv20191001.ResourceGroup
-├── Spec: Object (40 properties)
+├── Spec: Object (39 properties)
 │   ├── AnalyticalStorageConfiguration: *Object (2 properties)
 │   │   ├── PropertyBag: genruntime.PropertyBag
 │   │   └── SchemaType: *string
@@ -60,7 +60,6 @@ DatabaseAccount: Resource
 │   │   ├── MaxAgeInSeconds: *int
 │   │   └── PropertyBag: genruntime.PropertyBag
 │   ├── CreateMode: *string
-│   ├── CustomerManagedKeyStatus: *string
 │   ├── DatabaseAccountOfferType: *string
 │   ├── DefaultIdentity: *string
 │   ├── DisableKeyBasedMetadataWriteAccess: *bool