Skip to content

Limit the number of GET replays during tests #5109

@theunrepentantgeek

Description

@theunrepentantgeek

Describe the current behavior

In PR #5067 we introduced a configurable limit on the number of GET replays permitted during playback tests (these GETs are necessary to accommodate timing differences between recording and playback).

However, @theunrepentantgeek discovered a handful of tests that require an improbable number of replays for them to work - one required over 60 when running locally, and over 100 when run in CI.

So, for now, the limit has been set at 1000 replays, which is effectively unlimited.

Tests requiring a very high number of replays include

  • Test_DBForPostgreSQL_FlexibleServer_20250801_CRUD_2

(Unchecked means "outstanding"; checked means "fixed")

Describe the improvement

Once other work to improve the reliability and performance of our test suite has been completed, we should be able to lower the limit in replay_roundtripper.go a great deal.

Metadata

Metadata

Labels

testTest refactoring related tasks

Type

No type

Projects

Status

Backlog

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions