Improve resource condition/error when deletion is not permitted in Azure #4987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
jakjang,
juan-lee and
matthchr
as code owners
github-project-automation
bot
moved this to In Progress
in Azure Service Operator Roadmap
matthchr
reviewed
Oct 20, 2025
v2/samples/sql/v1api20211101/refs/v1api20210401_storageaccountsblobservice.yaml
Show resolved
Hide resolved
matthchr
reviewed
Oct 20, 2025
v2/internal/reconcilers/arm/azure_generic_arm_reconciler_instance.go
Outdated
Show resolved
Hide resolved
matthchr
reviewed
Oct 20, 2025
v2/internal/controllers/crd_dataprotection_backupinstance_20231101_test.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Some Azure resources can't be directly deleted - you have to delete their parent.
Currently if one of those resources is represented by an ASO cluster resource, any attempt to delete the resource from the cluster fails with an indefinite sequence of repeated failures.
But we can enhance our workflow to return a more informative error, including details on how to unblock the deletion from the cluster.
How does this PR make you feel?