fix panic with folder creation tracker validation (#3403)

* already existing folders should not be recreated

* fix

* unit test fct fix

Author: wonwuakpa-msft

e2etest/zt_newe2e_file_test.go

@@ -3,11 +3,12 @@ package e2etest
 import (
 	"context"
 	"fmt"
-	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
-	"github.com/Azure/azure-storage-azcopy/v10/common"
 	"math"
 	"os"
 	"strconv"
+
+	"github.com/Azure/azure-sdk-for-go/sdk/azcore/to"
+	"github.com/Azure/azure-storage-azcopy/v10/common"
 )
 
 func init() {

ste/folderCreationTracker.go

@@ -137,7 +137,9 @@ func (f *jpptFolderTracker) CreateFolder(folder string, doCreation func() error)
 				ts == common.ETransferStatus.FolderExisted() ||
 				ts == common.ETransferStatus.Cancelled() ||
 				ts == common.ETransferStatus.Success() ||
-				ts == common.ETransferStatus.Failed() {
+				ts == common.ETransferStatus.Failed() ||
+				ts == common.ETransferStatus.SkippedEntityAlreadyExists() {
+
 				return nil // do not re-create an existing folder
 			}
 		} else {

ste/folderCreationTracker_test.go

@@ -159,7 +159,7 @@ func TestFolderCreationTracker_directoryExists(t *testing.T) {
 	}) // "create" our folder
 	err := fct.CreateFolder(folderExists, func() error {
 		return common.FolderCreationErrorAlreadyExists{}
-	}) // fail creation on not existing
+	})                                                // fail creation on not existing
 	a.NoError(err, "already exists should be caught") // ensure we caught that error
 	expectedFailureErr := errors.New("this creation should fail")
 	err = fct.CreateFolder(folderShouldCreate, func() error {
@@ -194,3 +194,45 @@ func TestFolderCreationTracker_directoryExists(t *testing.T) {
 
 	a.NoError(err)
 }
+
+// Verifies that a subsequent call to createFolder does not panic when the status is
+// SkippedEntityAlreadyExists
+func TestFolderCreationTracker_skippedEntityExits(t *testing.T) {
+	a := assert.New(t)
+
+	folderExists := "folderExists"
+	existsIdx := JpptFolderIndex{0, 0}
+
+	plan := &mockedJobPlan{
+		transfers: map[JpptFolderIndex]*JobPartPlanTransfer{
+			existsIdx: {atomicTransferStatus: common.ETransferStatus.NotStarted()},
+		},
+	}
+
+	fct := &jpptFolderTracker{
+		fetchTransfer: plan.getFetchTransfer(t),
+		mu:            &sync.Mutex{},
+		contents:      make(map[string]*JpptFolderTrackerState),
+	}
+
+	fct.RegisterPropertiesTransfer(folderExists, existsIdx.PartNum, existsIdx.TransferIndex)
+	err := fct.CreateFolder(folderExists, func() error {
+		return common.FolderCreationErrorAlreadyExists{}
+	})
+	a.NoError(err, "already exists should be caught")
+	a.Equal(common.ETransferStatus.FolderExisted(), plan.transfers[existsIdx].TransferStatus())
+
+	// Simulate folder transfer setting properties this happens in any_toremotefolder
+	plan.transfers[existsIdx].SetTransferStatus(common.ETransferStatus.SkippedEntityAlreadyExists(), false)
+
+	folderCreated := false
+	a.NotPanics(func() { // Subsequent call to createFolder should not panic
+		err = fct.CreateFolder(folderExists, func() error {
+			folderCreated = true
+			return nil
+		})
+	})
+	a.NoError(err)
+	a.False(folderCreated, "createFolder should return early without calling doCreation")
+
+}