Resolved a bug where user setting file size larger than maximum quota wouldn't fail.

Author: katmsft

Microsoft.WindowsAzure.Storage/includes/wascore/constants.h

@@ -58,9 +58,6 @@ namespace azure { namespace storage { namespace protocol {
     const std::chrono::seconds minimum_fixed_lease_duration(15);
     const std::chrono::seconds maximum_fixed_lease_duration(60);
 
-    // could file share limitation
-    const int maximum_share_quota(5120);
-
 #define _CONSTANTS
 #define DAT(a, b) WASTORAGE_API extern const utility::char_t a[]; const size_t a ## _size = sizeof(b) / sizeof(utility::char_t) - 1;
 #include "constants.dat"

Microsoft.WindowsAzure.Storage/includes/wascore/protocol_xml.h

@@ -702,7 +702,7 @@ namespace azure { namespace storage { namespace protocol {
     public:
 
         explicit get_share_stats_reader(concurrency::streams::istream stream)
-            : xml_reader(stream), m_quota(maximum_share_quota)
+            : xml_reader(stream), m_quota(std::numeric_limits<unsigned long long>::max())
         {
         }
 

Microsoft.WindowsAzure.Storage/src/cloud_file_share.cpp

@@ -84,7 +84,7 @@ namespace azure { namespace storage {
 
     pplx::task<void> cloud_file_share::create_async(const file_request_options& options, operation_context context)
     {
-        return create_async(protocol::maximum_share_quota, options, context);
+        return create_async(std::numeric_limits<unsigned long long>::max(), options, context);
     }
 
     pplx::task<void> cloud_file_share::create_async(utility::size64_t max_size, const file_request_options& options, operation_context context)
@@ -107,7 +107,7 @@ namespace azure { namespace storage {
 
     pplx::task<bool> cloud_file_share::create_if_not_exists_async(const file_request_options& options, operation_context context)
     {
-        return create_if_not_exists_async(protocol::maximum_share_quota, options, context);
+        return create_if_not_exists_async(std::numeric_limits<unsigned long long>::max(), options, context);
     }
 
     pplx::task<bool> cloud_file_share::create_if_not_exists_async(utility::size64_t max_size, const file_request_options& options, operation_context context)

Microsoft.WindowsAzure.Storage/src/file_request_factory.cpp

@@ -279,7 +279,7 @@ namespace azure { namespace storage { namespace protocol {
         uri_builder.append_query(core::make_query_parameter(uri_query_resource_type, resource_share, /* do_encoding */ false));
         web::http::http_request request(base_request(web::http::methods::PUT, uri_builder, timeout, context));
         web::http::http_headers& headers = request.headers();
-        if (max_size <= maximum_share_quota)
+        if (max_size != std::numeric_limits<unsigned long long>::max())
         {
             headers.add(protocol::ms_header_share_quota, max_size);
         }
@@ -305,10 +305,7 @@ namespace azure { namespace storage { namespace protocol {
         uri_builder.append_query(core::make_query_parameter(uri_query_resource_type, resource_share, /* do_encoding */ false));
         uri_builder.append_query(core::make_query_parameter(uri_query_component, component_properties, /* do_encoding */ false));
         web::http::http_request request(base_request(web::http::methods::PUT, uri_builder, timeout, context));
-        if (properties.quota() <= protocol::maximum_share_quota)
-        {
-            request.headers().add(protocol::ms_header_share_quota, properties.quota());
-        }
+        request.headers().add(protocol::ms_header_share_quota, properties.quota());
         return request;
     }