Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

Commit 283fe48

Browse files
committed
Revert "Enabled httpsSocketKeepAlive by default"
This reverts commit 0ece261.
1 parent 0ece261 commit 283fe48

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

microsoft-azure-storage/src/com/microsoft/azure/storage/RequestOptions.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ protected static void applyBaseDefaultsInternal(final RequestOptions modifiedOpt
108108
}
109109

110110
if (modifiedOptions.disableHttpsSocketKeepAlive() == null) {
111-
modifiedOptions.setDisableHttpsSocketKeepAlive(false);
111+
modifiedOptions.setDisableHttpsSocketKeepAlive(true);
112112
}
113113
}
114114

@@ -322,16 +322,16 @@ public void setRequireEncryption(Boolean requireEncryption) {
322322
* Sets a value to indicate whether https socket keep-alive should be disabled. Use <code>true</code> to disable
323323
* keep-alive; otherwise, <code>false</code>
324324
* <p>
325-
* The default is set in the client and is by default false, indicating that https socket keep-alive will be
326-
* enabled. You can change the value on this request by setting this property. You can also change the value on
325+
* The default is set in the client and is by default true, indicating that https socket keep-alive will be
326+
* disabled. You can change the value on this request by setting this property. You can also change the value on
327327
* on the {@link ServiceClient#getDefaultRequestOptions()} object so that all subsequent requests made via the
328328
* service client will use the appropriate value.
329329
* <p>
330330
* Setting keep-alive on https sockets is to work around a bug in the JVM where connection timeouts are not honored
331-
* on retried requests. In those cases, we use socket keep-alive as a fallback. Unfortunately, the timeout value
332-
* must be taken from a JVM property rather than configured locally. Therefore, in rare cases the JVM has configured
333-
* aggressively short keep-alive times, it may be beneficial to disable the use of keep-alives lest they interfere
334-
* with long running data transfer operations.
331+
* on retried requests. In those cases, you may choose to use socket keep-alive as a fallback. Unfortunately, the
332+
* timeout value must be taken from a JVM property rather than configured locally. Therefore, in rare cases the JVM
333+
* has configured aggressively short keep-alive times, it may not be beneficial to enable the use of keep-alives
334+
* lest they interfere with long running data transfer operations.
335335
*
336336
* @param disableHttpsSocketKeepAlive
337337
* A value to indicate whether https socket keep-alive should be disabled.

0 commit comments

Comments
 (0)