Merge pull request #422 from Azure/dev

Dev

Author: rickle-msft

ChangeLog.txt

@@ -1,3 +1,7 @@
+2019.01.11 Version 10.4.0
+* Fixed a bug that caused errors when java.io.tempdir has no trailing separator.
+* Upgrade autorest-clientruntime dependency to include some bug fixes.
+
 2018.11.19 Version 10.3.0
 * Added support for SLF4J.
 * Included default logging to log warnings and errors to the temp directory by default.

README.md

@@ -37,7 +37,7 @@ To get the binaries of this library as distributed by Microsoft, ready for use w
 <dependency>
 	<groupId>com.microsoft.azure</groupId>
 	<artifactId>azure-storage-blob</artifactId>
-	<version>10.3.0</version>
+	<version>10.4.0</version>
 </dependency>
 ```
 

pom.xml

@@ -14,7 +14,7 @@
 
     <groupId>com.microsoft.azure</groupId>
     <artifactId>azure-storage-blob</artifactId>
-    <version>10.3.0</version>
+    <version>10.4.0</version>
 
     <name>Azure Storage Blob</name>
     <description>The Azure Storage Java Blob library.</description>
@@ -65,7 +65,7 @@
         <dependency>
             <groupId>com.microsoft.rest.v2</groupId>
             <artifactId>client-runtime</artifactId>
-            <version>2.0.0</version>
+            <version>2.0.2</version>
         </dependency>
         <dependency>
             <groupId>org.slf4j</groupId>

src/main/java/com/microsoft/azure/storage/blob/Constants.java

@@ -184,7 +184,7 @@ static final class HeaderConstants {
         /**
          * Specifies the value to use for UserAgent header.
          */
-        static final String USER_AGENT_VERSION = "10.3.0";
+        static final String USER_AGENT_VERSION = "10.4.0";
 
         private HeaderConstants() {
             // Private to prevent construction.

src/main/java/com/microsoft/azure/storage/blob/LoggingFactory.java

@@ -54,7 +54,7 @@ public final class LoggingFactory implements RequestPolicyFactory {
             forceLogger.setLevel(Level.WARNING);
 
             // Create the logs directory if it doesn't exist.
-            File logDir = new File(System.getProperty("java.io.tmpdir") + "AzureStorageJavaSDKLogs");
+            File logDir = new File(System.getProperty("java.io.tmpdir"), "AzureStorageJavaSDKLogs");
             if (!logDir.exists()) {
                 if (!logDir.mkdir()) {
                     throw new Exception("Could not create logs directory");

src/test/java/com/microsoft/azure/storage/APISpec.groovy

@@ -176,7 +176,7 @@ class APISpec extends Specification {
         if (accountName == null || accountKey == null) {
             System.out.println("Account name or key for the " + accountType + " account was null. Test's requiring " +
                     "these credentials will fail.")
-            throw new Exception()
+            return null
         }
         return new SharedKeyCredentials(accountName, accountKey)
     }

src/test/java/com/microsoft/azure/storage/blob/LoggingTest.groovy

@@ -446,12 +446,4 @@ class LoggingTest extends APISpec {
                     }
                 }
     }
-
-    // Test creating directory and when directory exists
-    // Test slf4j logging and default logging and HttpPipeline logging
-    // Test that event logging only logs warnings and errors
-    // Check that string is not formatted if we don't need to log?
-    // Can attach a spy to the LoggerFactory.getLogger and make sure things are called the right number of times.
-    // Test when the forceLogger fails to load
-    // Test why the force logger seems to be printing some things to stdout? (Repro by setting the log level to warning)
 }