Skip to content

Commit 588c11a

Browse files
xiafu-msftzezha-msft
authored andcommitted
[Blob][BugFix]set_blob_service_properties Throws Exception When Parameters are All None
set_blob_service_properties should remind the users to give correct input when the users give a bad input, while now the request is still sending out even with bad parameters. https://msazure.visualstudio.com/One/_workitems/edit/3715199
1 parent 13e065e commit 588c11a

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

azure-storage-blob/azure/storage/blob/baseblobservice.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1534,6 +1534,11 @@ def set_blob_service_properties(
15341534
:type static_website:
15351535
:class:`~azure.storage.common.models.StaticWebsite`
15361536
'''
1537+
if all(parameter is None for parameter in [logging, hour_metrics, minute_metrics, cors, target_version,
1538+
delete_retention_policy, static_website]):
1539+
1540+
raise ValueError("set_blob_service_properties should be called with at least one parameter")
1541+
15371542
request = HTTPRequest()
15381543
request.method = 'PUT'
15391544
request.host_locations = self._get_host_locations()

tests/common/test_service_properties.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,11 @@ def test_blob_service_properties(self):
132132
self._assert_properties_default(props)
133133
self.assertEqual('2014-02-14', props.target_version)
134134

135+
def test_blob_service_properties_exception(self):
136+
# if users did't provide any parameter, throw an Exception to alert them
137+
with self.assertRaises(ValueError):
138+
self.bs.set_blob_service_properties()
139+
135140
@record
136141
def test_queue_service_properties(self):
137142
# Arrange

0 commit comments

Comments
 (0)