Skip to content

Commit 13555e6

Browse files
thecmdradamaaricket-ccxAlexanderSehr
authored
fix: Update avm/res/net-app/net-app-account - fix optional zone for volumes and specify protocolTypes options (#4469)
## Description This PR resolves the following issues in the `avm/res/net-app/net-app-account` module * On the NetApp Volume submodule, `zone` has been renamed to `availabilityZone`. * The type for `availabilityZone` has been changed to `string` from `int[]` and is now optional with null as the default. Previously the module would try and deploy a volume into all three zones if no value is defined. * Changed: `protocolTypes` is now an optional array of strings with three possible options `'NFSv3', 'NFSv4.1', and 'CIFS'`. If no value is provided, the default value of `['NFSv3']` is used. * Added to the description for `protocolTypes` indicating that the user will need to specify `['NFSv3','CIFS']` or `['NFSv4.1','CIFS']` if creating dual-stack volumes. * Added in additional submodule README.md and main.json files generated by Set-AVMModule. <!-- >Thank you for your contribution ! > Please include a summary of the change and which issue is fixed. > Please also include the context. > List any dependencies that are required for this change. Fixes #4506 Closes #4534 --> ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [![avm.res.net-app.net-app-account](https://github.com/thecmdradama/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml/badge.svg?branch=fix%2Fnetapp-pattern)](https://github.com/thecmdradama/bicep-registry-modules/actions/workflows/avm.res.net-app.net-app-account.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [x] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [x] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [x] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep --> --------- Co-authored-by: Adam Ricket <adam.ricket@cybercx.com.au> Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
1 parent 7732c3f commit 13555e6

File tree

16 files changed

+639
-223
lines changed

16 files changed

+639
-223
lines changed

avm/res/net-app/net-app-account/README.md

Lines changed: 200 additions & 60 deletions
Large diffs are not rendered by default.

avm/res/net-app/net-app-account/backup-policies/main.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
"metadata": {
55
"_generator": {
66
"name": "bicep",
7-
"version": "0.33.13.18514",
8-
"templateHash": "7141176618644423280"
7+
"version": "0.33.93.31351",
8+
"templateHash": "2748634922557584170"
99
},
1010
"name": "Azure NetApp Files Backup Policy",
1111
"description": "This module deploys a Backup Policy for Azure NetApp File."

avm/res/net-app/net-app-account/backup-vault/backup/main.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"_generator": {
77
"name": "bicep",
8-
"version": "0.33.13.18514",
9-
"templateHash": "3948084235912412629"
8+
"version": "0.33.93.31351",
9+
"templateHash": "17452697444375969559"
1010
},
1111
"name": "Azure NetApp Files Volume Backup",
1212
"description": "This module deploys a backup of a NetApp Files Volume."

avm/res/net-app/net-app-account/backup-vault/main.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
"metadata": {
66
"_generator": {
77
"name": "bicep",
8-
"version": "0.33.13.18514",
9-
"templateHash": "9738469557677047438"
8+
"version": "0.33.93.31351",
9+
"templateHash": "6704781490326075849"
1010
},
1111
"name": "Azure NetApp Files Volume Backup Vault",
1212
"description": "This module deploys a NetApp Files Backup Vault."
@@ -144,8 +144,8 @@
144144
"metadata": {
145145
"_generator": {
146146
"name": "bicep",
147-
"version": "0.33.13.18514",
148-
"templateHash": "3948084235912412629"
147+
"version": "0.33.93.31351",
148+
"templateHash": "17452697444375969559"
149149
},
150150
"name": "Azure NetApp Files Volume Backup",
151151
"description": "This module deploys a backup of a NetApp Files Volume."

0 commit comments

Comments
 (0)