Skip to content

Commit 5d32bab

Browse files
Always use named pipes on Windows for gRPC (#18712)
While modern Windows technically supports UDS, many libraries (like Rust's Tokio) do not. So unfortunately is much more straightforward to always use named pipes on Windows. ## Description <!-- Provide a 1-2 sentence description of your change --> ## Example Usage PowerShell/DSC#1330 ## Checklist - [x] I have read and adhere to the [contribution guide](https://github.com/Azure/bicep/blob/main/CONTRIBUTING.md). ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/Azure/bicep/pull/18712) --------- Co-authored-by: Anthony Martin <38542602+anthony-c-martin@users.noreply.github.com>
1 parent ee50525 commit 5d32bab

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/Bicep.Local.Deploy/Extensibility/GrpcLocalExtension.cs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,8 @@ public static async Task<ILocalExtension> Start(IOUri binaryUri)
3636
Func<GrpcChannel> channelBuilder;
3737
GrpcChannel? channel = null;
3838

39-
if (Socket.OSSupportsUnixDomainSockets)
39+
// While modern Windows technically supports UDS, many libraries (like Rust's Tokio) do not
40+
if (Socket.OSSupportsUnixDomainSockets && !OperatingSystem.IsWindows())
4041
{
4142
var socketName = $"{Guid.NewGuid()}.tmp";
4243
var socketPath = Path.Combine(Path.GetTempPath(), socketName);

0 commit comments

Comments
 (0)