Templates that were working Friday now arent

[slinginSimmo]

Hi All, Just started using these CARML modules recently as I try to build out some automated deployments. Pretty sweet I have to say. I seem to be getting new errors today, which were not showing up last week. My bicep/param files have not changed.
Any idea if something has changed from the MS side?
These templates were 100% working for me on Friday.

main.bicep

targetScope = 'subscription'

// ================ //
// Input Parameters //
// ================ //

// RG parameters
@description('Name, Location and Tags paramters')
param resourceGroupParams array

// ST parameters
@description('Name, Location, Sku and Kind paramters')
param storageParams array

// =========== //
// Deployments //
// =========== //

// Resource Group

module rgs '../ResourceModules-0.5.0/arm/Microsoft.Resources/resourceGroups/deploy.bicep' = [for rgparam in resourceGroupParams: {
  name: '${rgparam.Name}-deploy'
  params: rgparam
}]

// creates all the storage account in to the Resource Groups in the scope provided
module sts '../ResourceModules-0.5.0/arm/Microsoft.Storage/storageAccounts/deploy.bicep' = [for stparam in storageParams: {
  name: '${stparam.Name}-deploy'
  scope: resourceGroup(stparam.resourceGroupToDeployTo)
  params: stparam
  dependsOn: [
    rgs
  ]
}]

params.json

{
    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
    "contentVersion": "1.0.0.0",
    "parameters": {
        "resourceGroupParams": {
            "value": [
                {
                    "name": "rg-1",
                    "location": "northeurope",
                    "tags": {
                        "Environment": "Sandbox",
                        "Solution Level": "Tin",
                        "Application": "BICEP POC_app1",
                        "Owner": "Shane.Warne@email.com",
                        "Department": "IT"
                    }
                },
                {
                    "name": "rg-2",
                    "location": "northeurope",
                    "tags": {
                        "Environment": "Sandbox",
                        "Solution Level": "Tin",
                        "Application": "BICEP POC_app2",
                        "Owner": "acdc@email.com",
                        "Department": "IT"
                    }
                }
            ]
        },
        "storageParams": {
            "value": [
                {
                    "Name": "stapp1",
                    "location": "northeurope",
                    "storageAccountSku": "Standard_LRS",
                    "storageAccountKind": "StorageV2",
                    "resourceGroupToDeployTo": "rg-1"
                },
                {
                    "Name": "stapp2",
                    "location": "northeurope",
                    "sku": "Standard_LRS",
                    "kind": "StorageV2",
                    "resourceGroupToDeployTo": "rg-2"
                }
            ]
        }
    }
}

New errors I am seeing :
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Storage\storageAccounts\deploy.bicep(155,31) : Warning simplify-interpolation: Remove unnecessary string interpolation. [https://aka.ms/bicep/linter/simplify-interpolation]
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Storage\storageAccounts\blobServices\containers.bicep\nested_rbac.bicep(62,25) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview"
does not have types available.
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Storage\storageAccounts\queueServices\queues.bicep\nested_rbac.bicep(68,25) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview" does not have types available.
C:\temp\ResourceModules-0.5.0\thebigone_working.bicep(23,11) : Error BCP183: The value of the module "params" property must be an object literal.
C:\temp\ResourceModules-0.5.0\thebigone_working.bicep(30,11) : Error BCP183: The value of the module "params" property must be an object literal.
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Storage\storageAccounts\fileServices\shares.bicep\nested_rbac.bicep(71,25) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview" does not have types available.
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Storage\storageAccounts.bicep\nested_rbac.bicep(71,25) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview" does not have types available.
C:\temp\ResourceModules-0.5.0\arm\Microsoft.Resources\resourceGroups.bicep\nested_rbac.bicep(200,25) : Warning BCP081: Resource type "Microsoft.Authorization/roleAssignments@2021-04-01-preview" does not have types available.

Any help would be appreciated.

Thanks

SImon

[brwilkinson]

Hi @SC-Rotork do you have a bicepconfig.json file?

If you do you can override these warnings/errors to simply ignore them.

https://docs.microsoft.com/en-us/azure/azure-resource-manager/bicep/bicep-config-linter

I cannot think what might have changed, perhaps an updated Bicep version itself.

You might want to bring these up on the CARML repo itself.

which Bicep and Bicep vscode extension are you using?

[slinginSimmo]

Thanks for taking the time to respond @brwilkinson
I was using Bicep v0.4.1318 and have upgraded to v0.6.1. Still same errors.

I think the problem lies in these errors:
C:\temp\ResourceModules-0.5.0\thebigone_working.bicep(30,11) : Error BCP183: The value of the module "params" property must be an object literal.

Intellisense isn't happy with it:

I thought I could use params: stparam, as long as all the values in the params.json file were exactly what the MS property values are.
I saw here https://stackoverflow.com/questions/69742629/is-there-a-way-to-deploy-azure-resource-modules-not-in-the-main-file it was a way to simplify. I like the idea of this, as it potentially then means I can have a main.bicep file that could for each loops for every resource I want to deploy, with the changeable params per environment in the param.json file. And I would never have to change the main.bicep file to deploy many resources.

I am sure I was able to get these to deploy successfully on Friday (even with intellisense saying it was a problem)

Any idea if my bicep looks right, or if I have some syntax wrong?

I can take a look at using the bicepconfig.json, but that wont override an error that stops it from deploying will it?

Thanks again

[alex-frankel]

I don't believe what you are doing has ever been allowed and if VS code was throwing an error, that would have prevented the deployment from starting, so I think we are missing something. bicepconfig can help with the warnings you are seeing, but this error in particular will not be resolved there.

In order to make progress, we will need to be able to recreate the conditions where you successfully deployed. Any other ideas as to what might have changed since Friday? Are you using submodules to pull the CARML content into your repo? If so, have you pulled the latest from that repo since Friday? Can you revert those changes if that is the case?

[brwilkinson]

@SC-Rotork can you please provide an update on this?

The Splatting of the params via an object is not supported, I also do not see those variables defined in your template, so it appears you have made some changes or perhaps pulled changes from an upstream repo? perhaps you pulled from the non main branch, so have partial changes. Perhaps pulling from upstream will assist to get the latest changes, and this may have been resolved.

Here is the thread where we discuss Splatting, which is still open, this change may facilitate the format you have, however this has never been implemented

#1121

[slinginSimmo]

No probs all, I am just calling out the params i need in the main.bicep file instead now.

Thanks to you both for taking the time to help me out. I do have another question, but I will create a new discussion for that.