Skip to content

Commit 231204f

Browse files
committed
PR changes
1 parent 76043e6 commit 231204f

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

src/Config/DatabasePrimitives/DatabaseObject.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,6 @@ public bool IsAnyColumnNullable(List<string> columnsToCheck)
235235
if (Columns.TryGetValue(paramName, out ColumnDefinition? columnDefinition))
236236
{
237237
return columnDefinition.Length;
238-
;
239238
}
240239

241240
return null;

src/Service.Tests/SqlTests/GraphQLQueryTests/MsSqlGraphQLQueryTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ public virtual async Task TestFilterParamForStringFilter()
202202
/// the string being passed as a parameter maybe longer than the length of the column. The parameter data type
203203
/// can't be fixed to the length of the underlying column, otherwise the parameter value would be truncated and
204204
/// we'd get incorret results
205+
/// Thus checking the parameter length is overridden to cater for teh extra length i.e. lengthOverride = true codepath?
205206
/// </remarks>
206207
[DataTestMethod]
207208
[DataRow("contains")]
@@ -241,7 +242,8 @@ public virtual async Task TestFilterParamForStringFilterWorkWithComplexOp(string
241242
/// When using complex operators i.e. NotContains due to wildcards being added or special characters being escaped
242243
/// the string being passed as a parameter maybe longer than the length of the column. The parameter data type
243244
/// can't be fixed to the length of the underlying column, otherwise the parameter value would be truncated and
244-
/// we'd get incorret results
245+
/// we'd get incorret results.
246+
/// Thus checking the parameter length is overridden to cater for teh extra length i.e. lengthOverride = true codepath?
245247
/// </remarks>
246248
[TestMethod]
247249
public virtual async Task TestFilterParamForStringFilterWorkWithNotContains(string op)

0 commit comments

Comments
 (0)