Skip to content

Commit b7d59f6

Browse files
CopilotJerryNixon
andcommitted
Simplify test to single assertion for stored procedure exclusion
Co-authored-by: JerryNixon <[email protected]>
1 parent c1c1e0d commit b7d59f6

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

src/Service.Tests/Configuration/HealthEndpointTests.cs

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -565,27 +565,24 @@ private static RuntimeConfig CreateRuntimeConfig(Dictionary<string, Entity> enti
565565
}
566566

567567
/// <summary>
568-
/// Verifies health checks include only tables and views, not stored procedures.
568+
/// Verifies stored procedures are excluded from health checks.
569569
/// </summary>
570570
[TestMethod]
571-
[DataRow(EntitySourceType.Table, true, DisplayName = "Table entities are included in health checks")]
572-
[DataRow(EntitySourceType.View, true, DisplayName = "View entities are included in health checks")]
573-
[DataRow(EntitySourceType.StoredProcedure, false, DisplayName = "Stored procedures are excluded from health checks")]
574-
public void HealthChecks_IncludeOnlyTablesAndViews(EntitySourceType sourceType, bool shouldBeIncluded)
571+
public void HealthChecks_ExcludeStoredProcedures()
575572
{
576-
Entity entity = new(
577-
Source: new("test", sourceType, null, null),
573+
Entity storedProcedure = new(
574+
Source: new("test", EntitySourceType.StoredProcedure, null, null),
578575
GraphQL: new("test", "tests"),
579576
Rest: new(Enabled: true),
580577
Permissions: new[] { ConfigurationTests.GetMinimalPermissionConfig(AuthorizationResolver.ROLE_ANONYMOUS) },
581578
Mappings: null,
582579
Relationships: null,
583580
Fields: null);
584581

585-
// Apply the same filter logic used in HealthCheckHelper.UpdateEntityHealthCheckResultsAsync
586-
bool isIncluded = entity.IsEntityHealthEnabled && entity.Source.Type != EntitySourceType.StoredProcedure;
587-
588-
Assert.AreEqual(shouldBeIncluded, isIncluded);
582+
// Apply the filter logic used in HealthCheckHelper - stored procedures should be excluded
583+
bool isIncludedInHealthCheck = storedProcedure.IsEntityHealthEnabled && storedProcedure.Source.Type != EntitySourceType.StoredProcedure;
584+
585+
Assert.IsFalse(isIncludedInHealthCheck);
589586
}
590587

591588
private static void WriteToCustomConfigFile(RuntimeConfig runtimeConfig)

0 commit comments

Comments
 (0)