Skip to content
This repository was archived by the owner on Oct 11, 2023. It is now read-only.

Commit 41af60f

Browse files
committed
Update the step:Create 'child namespaces and add Dev Spaces labels' and clean-up and make it faster by updating the command-kubectl label namespace
1 parent 011fec9 commit 41af60f

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

.github/workflows/bikes.yml

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,11 @@ jobs:
3939
- name: Create child namespaces and add Dev Spaces labels
4040
run: |
4141
if [ -n "$(kubectl get namespace ${{steps.generate-child-space-name.outputs.result}} --ignore-not-found -o name)" ]; then exit 0; fi
42-
kubectl create namespace ${{steps.generate-child-space-name.outputs.result}}
43-
kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/parent-space=${{ secrets.MASTER_SPACE }}
44-
kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/space=true
45-
kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} azds.io/pull-request-space=true
42+
kubectl create namespace ${{steps.generate-child-space-name.outputs.result}} \
43+
kubectl label namespace ${{steps.generate-child-space-name.outputs.result}} \
44+
azds.io/parent-space=${{ secrets.MASTER_SPACE }} \
45+
azds.io/space=true \
46+
azds.io/pull-request-space=true
4647
4748
- uses: azure/k8s-actions/k8s-create-secret@master
4849
with:
@@ -78,12 +79,12 @@ jobs:
7879
curl https://raw.githubusercontent.com/helm/helm/master/scripts/get > get_helm.sh
7980
chmod 700 get_helm.sh
8081
./get_helm.sh
81-
echo ::set-output name=result::$tmp_dir/
82+
echo ::set-output name=install_location::$tmp_dir/
8283
fi
8384
8485
- name: Helm Upgrade PR
8586
run: |
86-
${{steps.install-helm-client.outputs.result}}helm upgrade \
87+
${{steps.install-helm-client.outputs.install_location}}helm upgrade \
8788
--install ${{steps.generate-release-name.outputs.result}} samples/BikeSharingApp/Bikes/charts/bikes \
8889
--namespace ${{steps.generate-child-space-name.outputs.result}} \
8990
--set image.repository=${{ secrets.CONTAINER_REGISTRY }}/bikes \

0 commit comments

Comments
 (0)