Custom model send telemetry updates (#342)

* Update partition size

* Device state

* config

* space

Author: ap-git-hub

SimulationAgent/DeviceTelemetry/DeviceTelemetryActor.cs

@@ -262,36 +262,60 @@ public void HandleEvent(ActorEvents e)
         public void Stop()
         {
             this.status = ActorStatus.Stopped;
+            this.log.Debug("Telemetry stopped",
+                () => new
+                {
+                    this.deviceId,
+                    Status = this.status.ToString()
+                });
         }
 
         private void Reset()
         {
             this.status = ActorStatus.ReadyToStart;
-        }
-
-        private void ScheduleTelemetry()
-        {
-            // Considering the throttling settings, when can the message be sent
-            var availableSchedule = Now + this.simulationContext.RateLimiting.GetPauseForNextMessage();
-
-            // Looking at the device model, when should the message be sent
-            // note: this.whenToRun contains the time when the last msg was sent
-            var optimalSchedule = this.whenToRun + (long) this.Message.Interval.TotalMilliseconds;
-
-            // TODO: review this approach: when choosing optimalSchedule the app might overload the hub and cause throttling
-            this.whenToRun = Math.Max(optimalSchedule, availableSchedule);
-            this.status = ActorStatus.ReadyToSend;
-
-            this.actorLogger.TelemetryScheduled(this.whenToRun);
-            this.log.Debug("Telemetry scheduled",
+            this.log.Debug("Telemetry reset",
                 () => new
                 {
                     this.deviceId,
-                    Status = this.status.ToString(),
-                    When = this.log.FormatDate(this.whenToRun)
+                    Status = this.status.ToString()
                 });
         }
 
+        private void ScheduleTelemetry()
+        {
+            if (this.deviceStateActor.IsDeviceActive)
+            {
+                // Considering the throttling settings, when can the message be sent
+                var availableSchedule = Now + this.simulationContext.RateLimiting.GetPauseForNextMessage();
+
+                // Looking at the device model, when should the message be sent
+                // note: this.whenToRun contains the time when the last msg was sent
+                var optimalSchedule = this.whenToRun + (long) this.Message.Interval.TotalMilliseconds;
+
+                // TODO: review this approach: when choosing optimalSchedule the app might overload the hub and cause throttling
+                this.whenToRun = Math.Max(optimalSchedule, availableSchedule);
+                this.status = ActorStatus.ReadyToSend;
+
+                this.actorLogger.TelemetryScheduled(this.whenToRun);
+                this.log.Debug("Telemetry scheduled",
+                    () => new
+                    {
+                        this.deviceId,
+                        Status = this.status.ToString(),
+                        When = this.log.FormatDate(this.whenToRun)
+                    });
+            }
+            else
+            {
+                this.log.Debug("Device is not active, skipping telemetry send action.", 
+                    () => new
+                    {
+                        this.deviceId,
+                        Status = this.status.ToString()
+                    });
+            }
+        }
+
         private void PauseForQuotaExceeded()
         {
             this.status = ActorStatus.WaitingForQuota;

SimulationAgent/DeviceTelemetry/SendTelemetry.cs

@@ -35,30 +35,40 @@ public void Init(IDeviceTelemetryActor context, string deviceId, DeviceModel dev
 
         public async Task RunAsync()
         {
-            var state = this.context.DeviceState.GetAll();
-
-            // device could be rebooting, updating firmware, etc.
-            this.log.Debug("Checking to see if device is online", () => new { this.deviceId });
-            if (!state.ContainsKey("online") || (bool) state["online"])
+            try
             {
-                this.log.Debug("The device state says the device is online, sending telemetry...", () => new { this.deviceId });
+                var state = this.context.DeviceState.GetAll();
+
+                // device could be rebooting, updating firmware, etc.
+                this.log.Debug("Checking to see if device is online", () => new { this.deviceId });
+                if (!state.ContainsKey("online") || (bool) state["online"])
+                {
+                    this.log.Debug("The device state says the device is online, sending telemetry...", () => new { this.deviceId });
+                }
+                else
+                {
+                    this.log.Debug("No telemetry will be sent because the device is offline...", () => new { this.deviceId });
+                    this.context.HandleEvent(DeviceTelemetryActor.ActorEvents.TelemetryDelivered);
+                    return;
+                }
+
+                // Inject the device state into the message template
+                this.log.Debug("Preparing the message content using the device state", () => new { this.deviceId });
+                var msg = this.message.MessageTemplate;
+                foreach (var value in state)
+                {
+                    msg = msg.Replace("${" + value.Key + "}", value.Value.ToString());
+                }
+
+                await this.SendTelemetryMessageAsync(msg);
             }
-            else
+            catch (Exception e)
             {
-                this.log.Debug("No telemetry will be sent because the device is offline...", () => new { this.deviceId });
-                this.context.HandleEvent(DeviceTelemetryActor.ActorEvents.TelemetryDelivered);
-                return;
-            }
+                this.log.Error("Unexpected error while sending telemetry",
+                    () => new { this.deviceId, e });
 
-            // Inject the device state into the message template
-            this.log.Debug("Preparing the message content using the device state", () => new { this.deviceId });
-            var msg = this.message.MessageTemplate;
-            foreach (var value in state)
-            {
-                msg = msg.Replace("${" + value.Key + "}", value.Value.ToString());
+                this.context.HandleEvent(DeviceTelemetryActor.ActorEvents.TelemetrySendFailure);
             }
-
-            await this.SendTelemetryMessageAsync(msg);
         }
 
         private async Task SendTelemetryMessageAsync(string msg)

WebService/appsettings.ini

@@ -379,7 +379,7 @@ master_lock_duration = 120000
 # Note that a number bigger than ~10000 can cause errors when storing partitions
 # in Azure Tables due to the records size limit of 1MB.
 # Default: 1000, Min: 1, Max: 10000
-max_partition_size = 5000
+max_partition_size = 3000
 
 # Limit the amount of devices per node
 # Default: 20000, Min: 1, Max: 1000000