use aks cluster admin role

davidgamero · davidgamero · commit 4ea42ff24c2b · 2024-11-18T17:29:14.000-05:00
diff --git a/pkg/providers/azure.go b/pkg/providers/azure.go
@@ -30,7 +30,7 @@ type SetUpCmd struct {
 	AzClient          AzClientInterface
 }
 
-const AZURE_CONTRIBUTOR_ROLE_ID = "b24988ac-6180-42a0-ab88-20f7382dd24c"
+const AKS_CLUSTER_ADMIN_ROLE_ID = "b1ff04bb-8a4e-4dc4-8eb5-8693973ce19b"
 
 func InitiateAzureOIDCFlow(ctx context.Context, sc *SetUpCmd, s spinner.Spinner, gh GhClient) error {
 	log.Debug("Commencing github connection with azure...")
@@ -56,7 +56,7 @@ func InitiateAzureOIDCFlow(ctx context.Context, sc *SetUpCmd, s spinner.Spinner,
 		return err
 	}
 
-	if err := sc.AzClient.assignSpRole(ctx, sc.SubscriptionID, sc.ResourceGroupName, sc.spObjectId, AZURE_CONTRIBUTOR_ROLE_ID); err != nil {
+	if err := sc.AzClient.assignSpRole(ctx, sc.SubscriptionID, sc.ResourceGroupName, sc.spObjectId, AKS_CLUSTER_ADMIN_ROLE_ID); err != nil {
 		return err
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ type SetUpCmd struct {`
`30`	`30`	`AzClient AzClientInterface`
`31`	`31`	`}`
`32`	`32`
`33`		`-const AZURE_CONTRIBUTOR_ROLE_ID = "b24988ac-6180-42a0-ab88-20f7382dd24c"`
	`33`	`+const AKS_CLUSTER_ADMIN_ROLE_ID = "b1ff04bb-8a4e-4dc4-8eb5-8693973ce19b"`
`34`	`34`
`35`	`35`	`func InitiateAzureOIDCFlow(ctx context.Context, sc *SetUpCmd, s spinner.Spinner, gh GhClient) error {`
`36`	`36`	`log.Debug("Commencing github connection with azure...")`
`@@ -56,7 +56,7 @@ func InitiateAzureOIDCFlow(ctx context.Context, sc *SetUpCmd, s spinner.Spinner,`
`56`	`56`	`return err`
`57`	`57`	`}`
`58`	`58`
`59`		`- if err := sc.AzClient.assignSpRole(ctx, sc.SubscriptionID, sc.ResourceGroupName, sc.spObjectId, AZURE_CONTRIBUTOR_ROLE_ID); err != nil {`
	`59`	`+ if err := sc.AzClient.assignSpRole(ctx, sc.SubscriptionID, sc.ResourceGroupName, sc.spObjectId, AKS_CLUSTER_ADMIN_ROLE_ID); err != nil {`
`60`	`60`	`return err`
`61`	`61`	`}`
`62`	`62`