Skip to content

Commit 5bd702b

Browse files
authored
cluster resource type default enforcement (#476)
1 parent c3c7b04 commit 5bd702b

File tree

5 files changed

+37
-3
lines changed

5 files changed

+37
-3
lines changed

.github/workflows/integration-per-language.yml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,6 @@ jobs:
158158
--variable CONTAINERNAME=someContainer \
159159
--variable CLUSTERRESOURCEGROUP=someClusterResourceGroup \
160160
--variable CLUSTERNAME=someAksCluster \
161-
--variable CLUSTERRESOURCETYPE=Microsoft.ContainerService/managedClusters \
162161
--variable DOCKERFILE=./Dockerfile \
163162
--variable BUILDCONTEXTPATH=. \
164163
--variable NAMESPACE=default
@@ -332,7 +331,6 @@ jobs:
332331
--variable CONTAINERNAME=someContainer \
333332
--variable CLUSTERRESOURCEGROUP=someClusterResourceGroup \
334333
--variable CLUSTERNAME=someAksCluster \
335-
--variable CLUSTERRESOURCETYPE=Microsoft.ContainerService/managedClusters \
336334
--variable DOCKERFILE=./Dockerfile \
337335
--variable BUILDCONTEXTPATH=. \
338336
--variable NAMESPACE=default
@@ -486,7 +484,18 @@ jobs:
486484
curl -m 3 $SERVICEIP:${{env.serviceport}}
487485
sleep 5
488486
kill $tunnelPID
489-
- run: ./draft -v generate-workflow -d ./langtest/ --deploy-type manifests --variable WORKFLOWNAME=someWorkflow --variable BRANCHNAME=main --variable ACRRESOURCEGROUP=someAcrResourceGroup --variable AZURECONTAINERREGISTRY=someRegistry --variable CONTAINERNAME=someContainer --variable CLUSTERRESOURCEGROUP=someClusterResourceGroup --variable CLUSTERNAME=someAksCluster --variable CLUSTERRESOURCETYPE=Microsoft.ContainerService/managedClusters --variable DOCKERFILE=./Dockerfile --variable BUILDCONTEXTPATH=. --variable NAMESPACE=default
487+
- run: ./draft -v generate-workflow\
488+
--deploy-type manifests\
489+
--variable WORKFLOWNAME=someWorkflow \
490+
--variable BRANCHNAME=main \
491+
--variable ACRRESOURCEGROUP=someAcrResourceGroup \
492+
--variable AZURECONTAINERREGISTRY=someRegistry \
493+
--variable CONTAINERNAME=someContainer \
494+
--variable CLUSTERRESOURCEGROUP=someClusterResourceGroup \
495+
--variable CLUSTERNAME=someAksCluster \
496+
--variable DOCKERFILE=./Dockerfile \
497+
--variable BUILDCONTEXTPATH=. \
498+
--variable NAMESPACE=default
490499
# Validate generated workflow yaml
491500
- name: Install action-validator with asdf
492501
uses: asdf-vm/actions/install@v1

pkg/config/draftconfig_template_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ var validVariableKinds = map[string]bool{
3939
"azureServiceConnection": true,
4040
"containerImageName": true,
4141
"containerImageVersion": true,
42+
"clusterResourceType": true,
4243
"dirPath": true,
4344
"dockerFileName": true,
4445
"envVarMap": true,

template/workflows/helm/draft.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,3 +94,11 @@ variables:
9494
value: "false"
9595
description: "enable creation of target namespace if it does not exist"
9696
versions: ">=0.0.1"
97+
- name: "CLUSTERRESOURCETYPE"
98+
type: "string"
99+
kind: "clusterResourceType"
100+
default:
101+
disablePrompt: true
102+
value: "Microsoft.ContainerService/managedClusters"
103+
description: "ARM resource type for cluster"
104+
versions: ">=0.0.1"

template/workflows/kustomize/draft.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,11 @@ variables:
7878
value: "false"
7979
description: "enable creation of target namespace if it does not exist"
8080
versions: ">=0.0.1"
81+
- name: "CLUSTERRESOURCETYPE"
82+
type: "string"
83+
kind: "clusterResourceType"
84+
default:
85+
disablePrompt: true
86+
value: "Microsoft.ContainerService/managedClusters"
87+
description: "ARM resource type for cluster"
88+
versions: ">=0.0.1"

template/workflows/manifests/draft.yaml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,11 @@ variables:
7878
value: "false"
7979
description: "enable creation of target namespace if it does not exist"
8080
versions: ">=0.0.1"
81+
- name: "CLUSTERRESOURCETYPE"
82+
type: "string"
83+
kind: "clusterResourceType"
84+
default:
85+
disablePrompt: true
86+
value: "Microsoft.ContainerService/managedClusters"
87+
description: "ARM resource type for cluster"
88+
versions: ">=0.0.1"

0 commit comments

Comments
 (0)