Skip to content

Commit 3bc255c

Browse files
authored
Add the PartitionId value to the ProcessingMessage log event (#1186)
1 parent 4d886da commit 3bc255c

File tree

6 files changed

+20
-6
lines changed

6 files changed

+20
-6
lines changed

src/DurableTask.AzureStorage/AnalyticsEventSource.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1019,7 +1019,7 @@ public void DiscardingWorkItem(
10191019
ExtensionVersion);
10201020
}
10211021

1022-
[Event(EventIds.ProcessingMessage, Level = EventLevel.Informational, Task = Tasks.Processing, Opcode = EventOpcode.Receive, Version = 5)]
1022+
[Event(EventIds.ProcessingMessage, Level = EventLevel.Informational, Task = Tasks.Processing, Opcode = EventOpcode.Receive, Version = 6)]
10231023
public void ProcessingMessage(
10241024
Guid relatedActivityId,
10251025
string Account,
@@ -1030,6 +1030,7 @@ public void ProcessingMessage(
10301030
string ExecutionId,
10311031
string MessageId,
10321032
int Age,
1033+
string PartitionId,
10331034
long SequenceNumber,
10341035
int Episode,
10351036
bool IsExtendedSession,
@@ -1047,6 +1048,7 @@ public void ProcessingMessage(
10471048
ExecutionId ?? string.Empty,
10481049
MessageId,
10491050
Age,
1051+
PartitionId,
10501052
SequenceNumber,
10511053
Episode,
10521054
IsExtendedSession,

src/DurableTask.AzureStorage/AzureStorageOrchestrationService.cs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -752,7 +752,10 @@ async Task<TaskOrchestrationWorkItem> LockNextTaskOrchestrationWorkItemAsync(boo
752752
}
753753
else
754754
{
755-
session.TraceProcessingMessage(message, isExtendedSession: false);
755+
session.TraceProcessingMessage(
756+
message,
757+
isExtendedSession: false,
758+
partitionId: session.ControlQueue.Name);
756759
}
757760
}
758761

@@ -1525,7 +1528,7 @@ public async Task<TaskActivityWorkItem> LockNextTaskActivityWorkItem(
15251528
});
15261529

15271530
TraceMessageReceived(this.settings, session.MessageData, this.azureStorageClient.QueueAccountName);
1528-
session.TraceProcessingMessage(message, isExtendedSession: false);
1531+
session.TraceProcessingMessage(message, isExtendedSession: false, this.workItemQueue.Name);
15291532

15301533
if (!this.activeActivitySessions.TryAdd(message.Id, session))
15311534
{

src/DurableTask.AzureStorage/Logging/LogEvents.cs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2500,6 +2500,7 @@ public ProcessingMessage(
25002500
string executionId,
25012501
string messageId,
25022502
int age,
2503+
string partitionId,
25032504
long sequenceNumber,
25042505
int episode,
25052506
bool isExtendedSession)
@@ -2513,6 +2514,7 @@ public ProcessingMessage(
25132514
this.ExecutionId = executionId;
25142515
this.MessageId = messageId;
25152516
this.Age = age;
2517+
this.PartitionId = partitionId;
25162518
this.SequenceNumber = sequenceNumber;
25172519
this.Episode = episode;
25182520
this.IsExtendedSession = isExtendedSession;
@@ -2544,6 +2546,9 @@ public ProcessingMessage(
25442546
[StructuredLogField]
25452547
public int Age { get; }
25462548

2549+
[StructuredLogField]
2550+
public string PartitionId { get; }
2551+
25472552
[StructuredLogField]
25482553
public long SequenceNumber { get; }
25492554

@@ -2572,6 +2577,7 @@ void IEventSourceEvent.WriteEventSource() => AnalyticsEventSource.Log.Processing
25722577
this.ExecutionId,
25732578
this.MessageId,
25742579
this.Age,
2580+
this.PartitionId,
25752581
this.SequenceNumber,
25762582
this.Episode,
25772583
this.IsExtendedSession,

src/DurableTask.AzureStorage/Logging/LogHelper.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -823,6 +823,7 @@ internal void ProcessingMessage(
823823
string executionId,
824824
string messageId,
825825
int age,
826+
string partitionId,
826827
long sequenceNumber,
827828
int episode,
828829
bool isExtendedSession)
@@ -837,6 +838,7 @@ internal void ProcessingMessage(
837838
executionId,
838839
messageId,
839840
age,
841+
partitionId,
840842
sequenceNumber,
841843
episode,
842844
isExtendedSession);

src/DurableTask.AzureStorage/Messaging/OrchestrationSession.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ public async Task<IList<TaskMessage>> FetchNewOrchestrationMessagesAsync(
114114
var messages = new List<TaskMessage>(this.CurrentMessageBatch.Count);
115115
foreach (MessageData msg in this.CurrentMessageBatch)
116116
{
117-
this.TraceProcessingMessage(msg, isExtendedSession: true);
117+
this.TraceProcessingMessage(msg, isExtendedSession: true, partitionId: this.ControlQueue.Name);
118118
messages.Add(msg.TaskMessage);
119119
}
120120

src/DurableTask.AzureStorage/Messaging/Session.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public void StartNewLogicalTraceScope()
4545
AnalyticsEventSource.SetLogicalTraceActivityId(this.TraceActivityId);
4646
}
4747

48-
public void TraceProcessingMessage(MessageData data, bool isExtendedSession)
48+
public void TraceProcessingMessage(MessageData data, bool isExtendedSession, string partitionId)
4949
{
5050
if (data == null)
5151
{
@@ -64,7 +64,8 @@ public void TraceProcessingMessage(MessageData data, bool isExtendedSession)
6464
taskMessage.OrchestrationInstance.InstanceId,
6565
taskMessage.OrchestrationInstance.ExecutionId,
6666
queueMessage.MessageId,
67-
Math.Max(0, (int)DateTimeOffset.UtcNow.Subtract(queueMessage.InsertedOn.Value).TotalMilliseconds),
67+
age: Math.Max(0, (int)DateTimeOffset.UtcNow.Subtract(queueMessage.InsertedOn.Value).TotalMilliseconds),
68+
partitionId,
6869
data.SequenceNumber,
6970
data.Episode.GetValueOrDefault(-1),
7071
isExtendedSession);

0 commit comments

Comments
 (0)