Skip to content

Commit b87cce6

Browse files
committed
Update constructors to remove breaking change
Signed-off-by: halspang <[email protected]>
1 parent 8d45ad9 commit b87cce6

File tree

1 file changed

+69
-9
lines changed

1 file changed

+69
-9
lines changed

src/DurableTask.Core/TaskHubWorker.cs

Lines changed: 69 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -78,15 +78,30 @@ public TaskHubWorker(IOrchestrationService orchestrationService)
7878
/// </summary>
7979
/// <param name="orchestrationService">Reference the orchestration service implementation</param>
8080
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
81+
public TaskHubWorker(IOrchestrationService orchestrationService, ILoggerFactory loggerFactory = null)
82+
: this(
83+
orchestrationService,
84+
new NameVersionObjectManager<TaskOrchestration>(),
85+
new NameVersionObjectManager<TaskActivity>(),
86+
new NameVersionObjectManager<TaskEntity>(),
87+
loggerFactory)
88+
{
89+
}
90+
91+
/// <summary>
92+
/// Create a new TaskHubWorker with given OrchestrationService
93+
/// </summary>
94+
/// <param name="orchestrationService">Reference the orchestration service implementation</param>
8195
/// <param name="versioningSettings">The <see cref="VersioningSettings"/> that define how orchestration versions are handled</param>
82-
public TaskHubWorker(IOrchestrationService orchestrationService, ILoggerFactory loggerFactory = null, VersioningSettings versioningSettings = null)
96+
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
97+
public TaskHubWorker(IOrchestrationService orchestrationService, VersioningSettings versioningSettings, ILoggerFactory loggerFactory = null)
8398
: this(
8499
orchestrationService,
85100
new NameVersionObjectManager<TaskOrchestration>(),
86101
new NameVersionObjectManager<TaskActivity>(),
87102
new NameVersionObjectManager<TaskEntity>(),
88-
loggerFactory,
89-
versioningSettings)
103+
versioningSettings,
104+
loggerFactory)
90105
{
91106
}
92107

@@ -117,20 +132,41 @@ public TaskHubWorker(
117132
/// <param name="orchestrationObjectManager">The <see cref="INameVersionObjectManager{TaskOrchestration}"/> for orchestrations</param>
118133
/// <param name="activityObjectManager">The <see cref="INameVersionObjectManager{TaskActivity}"/> for activities</param>
119134
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
135+
public TaskHubWorker(
136+
IOrchestrationService orchestrationService,
137+
INameVersionObjectManager<TaskOrchestration> orchestrationObjectManager,
138+
INameVersionObjectManager<TaskActivity> activityObjectManager,
139+
ILoggerFactory loggerFactory = null)
140+
: this(
141+
orchestrationService,
142+
orchestrationObjectManager,
143+
activityObjectManager,
144+
new NameVersionObjectManager<TaskEntity>(),
145+
loggerFactory)
146+
{
147+
}
148+
149+
/// <summary>
150+
/// Create a new <see cref="TaskHubWorker"/> with given <see cref="IOrchestrationService"/> and name version managers
151+
/// </summary>
152+
/// <param name="orchestrationService">The orchestration service implementation</param>
153+
/// <param name="orchestrationObjectManager">The <see cref="INameVersionObjectManager{TaskOrchestration}"/> for orchestrations</param>
154+
/// <param name="activityObjectManager">The <see cref="INameVersionObjectManager{TaskActivity}"/> for activities</param>
120155
/// <param name="versioningSettings">The <see cref="VersioningSettings"/> that define how orchestration versions are handled</param>
156+
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
121157
public TaskHubWorker(
122158
IOrchestrationService orchestrationService,
123159
INameVersionObjectManager<TaskOrchestration> orchestrationObjectManager,
124160
INameVersionObjectManager<TaskActivity> activityObjectManager,
125-
ILoggerFactory loggerFactory = null,
126-
VersioningSettings versioningSettings = null)
161+
VersioningSettings versioningSettings,
162+
ILoggerFactory loggerFactory = null)
127163
: this(
128164
orchestrationService,
129165
orchestrationObjectManager,
130166
activityObjectManager,
131167
new NameVersionObjectManager<TaskEntity>(),
132-
loggerFactory,
133-
versioningSettings)
168+
versioningSettings,
169+
loggerFactory)
134170
{
135171
}
136172

@@ -142,14 +178,38 @@ public TaskHubWorker(
142178
/// <param name="activityObjectManager">NameVersionObjectManager for Activities</param>
143179
/// <param name="entityObjectManager">The NameVersionObjectManager for entities. The version is the entity key.</param>
144180
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
181+
public TaskHubWorker(
182+
IOrchestrationService orchestrationService,
183+
INameVersionObjectManager<TaskOrchestration> orchestrationObjectManager,
184+
INameVersionObjectManager<TaskActivity> activityObjectManager,
185+
INameVersionObjectManager<TaskEntity> entityObjectManager,
186+
ILoggerFactory loggerFactory = null)
187+
: this(
188+
orchestrationService,
189+
orchestrationObjectManager,
190+
activityObjectManager,
191+
entityObjectManager,
192+
null,
193+
loggerFactory)
194+
{
195+
}
196+
197+
/// <summary>
198+
/// Create a new TaskHubWorker with given OrchestrationService and name version managers
199+
/// </summary>
200+
/// <param name="orchestrationService">Reference the orchestration service implementation</param>
201+
/// <param name="orchestrationObjectManager">NameVersionObjectManager for Orchestrations</param>
202+
/// <param name="activityObjectManager">NameVersionObjectManager for Activities</param>
203+
/// <param name="entityObjectManager">The NameVersionObjectManager for entities. The version is the entity key.</param>
145204
/// <param name="versioningSettings">The <see cref="VersioningSettings"/> that define how orchestration versions are handled</param>
205+
/// <param name="loggerFactory">The <see cref="ILoggerFactory"/> to use for logging</param>
146206
public TaskHubWorker(
147207
IOrchestrationService orchestrationService,
148208
INameVersionObjectManager<TaskOrchestration> orchestrationObjectManager,
149209
INameVersionObjectManager<TaskActivity> activityObjectManager,
150210
INameVersionObjectManager<TaskEntity> entityObjectManager,
151-
ILoggerFactory loggerFactory = null,
152-
VersioningSettings versioningSettings = null)
211+
VersioningSettings versioningSettings,
212+
ILoggerFactory loggerFactory = null)
153213
{
154214
this.orchestrationManager = orchestrationObjectManager ?? throw new ArgumentException("orchestrationObjectManager");
155215
this.activityManager = activityObjectManager ?? throw new ArgumentException("activityObjectManager");

0 commit comments

Comments
 (0)