use uncached reader in eviction controller

Author: Arvind Thirumurugan

cmd/hubagent/workload/setup.go

@@ -229,7 +229,8 @@ func SetupControllers(ctx context.Context, wg *sync.WaitGroup, mgr ctrl.Manager,
 			}
 			klog.Info("Setting up cluster resource placement eviction controller")
 			if err := (&clusterresourceplacementeviction.Reconciler{
-				Client: mgr.GetClient(),
+				Client:         mgr.GetClient(),
+				UncachedReader: mgr.GetAPIReader(),
 			}).SetupWithManager(mgr); err != nil {
 				klog.ErrorS(err, "Unable to set up cluster resource placement eviction controller")
 				return err

pkg/controllers/clusterresourceplacementeviction/controller.go

@@ -31,6 +31,8 @@ import (
 // Reconciler reconciles a ClusterResourcePlacementEviction object.
 type Reconciler struct {
 	client.Client
+	// UncachedReader is only used to read disruption budget objects directly from the API server to ensure we can enforce the disruption budget for eviction.
+	UncachedReader client.Reader
 }
 
 // Reconcile triggers a single eviction reconcile round.
@@ -186,7 +188,7 @@ func (r *Reconciler) executeEviction(ctx context.Context, validationResult *evic
 	}
 
 	var db placementv1alpha1.ClusterResourcePlacementDisruptionBudget
-	if err := r.Client.Get(ctx, types.NamespacedName{Name: crp.Name}, &db); err != nil {
+	if err := r.UncachedReader.Get(ctx, types.NamespacedName{Name: crp.Name}, &db); err != nil {
 		if k8serrors.IsNotFound(err) {
 			if err = r.deleteClusterResourceBinding(ctx, evictionTargetBinding); err != nil {
 				return err

pkg/controllers/clusterresourceplacementeviction/controller_test.go

@@ -625,7 +625,8 @@ func TestExecuteEviction(t *testing.T) {
 				WithObjects(objects...).
 				Build()
 			r := Reconciler{
-				Client: fakeClient,
+				Client:         fakeClient,
+				UncachedReader: fakeClient,
 			}
 			gotErr := r.executeEviction(ctx, tc.validationResult, tc.eviction)
 			gotExecutedCondition := tc.eviction.GetCondition(string(placementv1alpha1.PlacementEvictionConditionTypeExecuted))

pkg/controllers/clusterresourceplacementeviction/suite_test.go

@@ -84,7 +84,8 @@ var _ = BeforeSuite(func() {
 	Expect(err).Should(Succeed())
 
 	err = (&Reconciler{
-		Client: k8sClient,
+		Client:         k8sClient,
+		UncachedReader: mgr.GetAPIReader(),
 	}).SetupWithManager(mgr)
 	Expect(err).Should(Succeed())