chore: Add UT to ensure Arc charts are parseable (#1239)

Author: MuhammadAliFleet

charts/member-agent-arc/charts_test.go

@@ -0,0 +1,171 @@
+package memberagentarc
+
+import (
+	"encoding/base64"
+	"os"
+	"path/filepath"
+	"strings"
+	"testing"
+	"text/template"
+
+	. "github.com/onsi/gomega"
+
+	"sigs.k8s.io/yaml"
+)
+
+// TestHelmChartTemplatesRenderValidYAML tests that Helm chart templates render
+// to valid YAML with maximal configuration values that activate all conditional paths.
+func TestHelmChartTemplatesRenderValidYAML(t *testing.T) {
+	// Maximal configuration to activate all conditional template paths
+	values := map[string]interface{}{
+		"memberagent": map[string]interface{}{
+			"repository": "mcr.microsoft.com/aks/fleet/member-agent",
+			"tag":        "v1.0.0",
+		},
+		"mcscontrollermanager": map[string]interface{}{
+			"repository": "mcr.microsoft.com/aks/fleet/mcs-controller-manager",
+			"tag":        "v1.0.0",
+		},
+		"membernetcontrollermanager": map[string]interface{}{
+			"repository": "mcr.microsoft.com/aks/fleet/member-net-controller-manager",
+			"tag":        "v1.0.0",
+		},
+		"refreshtoken": map[string]interface{}{
+			"repository": "mcr.microsoft.com/aks/fleet/refresh-token",
+			"tag":        "v1.0.0",
+		},
+		"crdinstaller": map[string]interface{}{
+			"enabled":      true,
+			"repository":   "mcr.microsoft.com/aks/fleet/crd-installer",
+			"tag":          "v1.0.0",
+			"logVerbosity": 2,
+		},
+		"logVerbosity": 5,
+		"namespace":    "fleet-system",
+		"config": map[string]interface{}{
+			"scope":             "https://test.scope",
+			"hubURL":            "https://hub.example.com",
+			"memberClusterName": "test-cluster",
+			"hubCA":             "test-ca-cert",
+		},
+		"enableV1Beta1APIs":           true,
+		"enableTrafficManagerFeature": true,
+		"enableNetworkingFeatures":    true,
+		"propertyProvider":            "azure",
+		"Azure": map[string]interface{}{
+			"proxySettings": map[string]interface{}{
+				"isProxyEnabled": true,
+				"httpProxy":      "http://proxy.example.com:8080",
+				"httpsProxy":     "https://proxy.example.com:8443",
+				"noProxy":        "localhost,127.0.0.1",
+				"proxyCert":      "test-proxy-cert",
+			},
+			"Identity": map[string]interface{}{
+				"MSIAdapterYaml": "image: mcr.microsoft.com/aks/msi-adapter:v1.0.0\nresources:\n  limits:\n    cpu: 100m",
+			},
+			"Extension": map[string]interface{}{
+				"Name": "fleet-member-extension",
+			},
+		},
+	}
+
+	// Template context matching Helm's structure
+	context := map[string]interface{}{
+		"Values": values,
+		"Release": map[string]interface{}{
+			"Name":      "test-release",
+			"Namespace": "fleet-system",
+		},
+		"Chart": map[string]interface{}{
+			"Name":    "arc-member-cluster-agents",
+			"Version": "1.0.0",
+		},
+	}
+
+	// Table-driven test for each template file
+	tests := []struct {
+		name         string
+		templateFile string
+	}{
+		{name: "deployment template", templateFile: "deployment.yaml"},
+		{name: "rbac template", templateFile: "rbac.yaml"},
+		{name: "serviceaccount template", templateFile: "serviceaccount.yaml"},
+		{name: "azure-proxy-secrets template", templateFile: "azure-proxy-secrets.yaml"},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			g := NewWithT(t)
+
+			templatePath := filepath.Join("templates", tt.templateFile)
+			templateBytes, err := os.ReadFile(templatePath)
+			g.Expect(err).ToNot(HaveOccurred(), "Failed to read template %s. Err %s", tt.templateFile, err)
+
+			// Parse and render the Go template
+			tmpl := template.New(tt.templateFile).Funcs(helmFuncMap())
+			tmpl, err = tmpl.Parse(string(templateBytes))
+			g.Expect(err).ToNot(HaveOccurred(), "Failed to parse template %s. Err %s", tt.templateFile, err)
+
+			var rendered strings.Builder
+			err = tmpl.Execute(&rendered, context)
+			g.Expect(err).ToNot(HaveOccurred(), "Failed to render template %s. Err %s", tt.templateFile, err)
+			renderedContent := strings.TrimSpace(rendered.String())
+
+			// Validate each YAML document in multi-doc files
+			docs := strings.Split(renderedContent, "\n---\n")
+			validDocsCount := 0
+			for i, doc := range docs {
+				doc = strings.TrimSpace(doc)
+				if doc == "" {
+					continue
+				}
+
+				var obj interface{}
+				err := yaml.Unmarshal([]byte(doc), &obj)
+				g.Expect(err).ToNot(HaveOccurred(), "Template %s doc %d is invalid YAML\nContent:\n%s",
+					tt.templateFile, i+1, doc)
+				validDocsCount++
+			}
+
+			g.Expect(validDocsCount).To(BeNumerically(">", 0), "Template %s rendered but produced no valid YAML documents", tt.templateFile)
+		})
+	}
+}
+
+// helmFuncMap returns template functions that mimic Helm's template functions
+func helmFuncMap() template.FuncMap {
+	return template.FuncMap{
+		"nindent": func(spaces int, s string) string {
+			indent := strings.Repeat(" ", spaces)
+			lines := strings.Split(s, "\n")
+			var result []string
+			for i, line := range lines {
+				if i == 0 {
+					result = append(result, "\n"+indent+line)
+				} else {
+					result = append(result, indent+line)
+				}
+			}
+			return strings.Join(result, "\n")
+		},
+		"quote": func(s interface{}) string {
+			return `"` + toString(s) + `"`
+		},
+		"b64enc": func(s string) string {
+			return base64.StdEncoding.EncodeToString([]byte(s))
+		},
+		"include": func(name string, data interface{}) string {
+			return "<included: " + name + ">"
+		},
+	}
+}
+
+func toString(v interface{}) string {
+	if v == nil {
+		return ""
+	}
+	if s, ok := v.(string); ok {
+		return s
+	}
+	return ""
+}