update updateRun validations to ensure ApprovalRequest name uniqueness

Author: jwtty

apis/placement/v1alpha1/stagedupdate_types.go

@@ -19,11 +19,12 @@ import (
 // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
 // +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string
 // +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="Resource-Snapshot",type=string
-// +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.policySnapshotIndexUsed`,name="Policy-Snapshot",type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Initialized")].status`,name="Initialized",type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Succeeded")].status`,name="Succeeded",type=string
 // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date
+// +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 128",message="metadata.name max length is 127"
 
 // ClusterStagedUpdateRun represents a stage by stage update process that applies ClusterResourcePlacement
 // selected resources to specified clusters.
@@ -109,7 +110,7 @@ type ClusterStagedUpdateStrategyList struct {
 type StageConfig struct {
 	// The name of the stage. This MUST be unique within the same StagedUpdateStrategy.
 	// +kubebuilder:validation:MaxLength=63
-	// +kubebuilder:validation:Pattern="[A-Za-z0-9]+$"
+	// +kubebuilder:validation:Pattern="^[a-z0-9]+$"
 	// +kubebuilder:validation:Required
 	Name string `json:"name"`
 

apis/placement/v1beta1/stageupdate_types.go

@@ -18,11 +18,12 @@ import (
 // +kubebuilder:storageversion
 // +kubebuilder:printcolumn:JSONPath=`.spec.placementName`,name="Placement",type=string
 // +kubebuilder:printcolumn:JSONPath=`.spec.resourceSnapshotIndex`,name="Resource-Snapshot",type=string
-// +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.policySnapshotIndexUsed`,name="Policy-Snapshot",type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Initialized")].status`,name="Initialized",type=string
 // +kubebuilder:printcolumn:JSONPath=`.status.conditions[?(@.type=="Succeeded")].status`,name="Succeeded",type=string
 // +kubebuilder:printcolumn:JSONPath=`.metadata.creationTimestamp`,name="Age",type=date
+// +kubebuilder:printcolumn:JSONPath=`.spec.stagedRolloutStrategyName`,name="Strategy",priority=1,type=string
+// +kubebuilder:validation:XValidation:rule="size(self.metadata.name) < 128",message="metadata.name max length is 127"
 
 // ClusterStagedUpdateRun represents a stage by stage update process that applies ClusterResourcePlacement
 // selected resources to specified clusters.
@@ -109,7 +110,7 @@ type ClusterStagedUpdateStrategyList struct {
 type StageConfig struct {
 	// The name of the stage. This MUST be unique within the same StagedUpdateStrategy.
 	// +kubebuilder:validation:MaxLength=63
-	// +kubebuilder:validation:Pattern="[A-Za-z0-9]+$"
+	// +kubebuilder:validation:Pattern="^[a-z0-9]+$"
 	// +kubebuilder:validation:Required
 	Name string `json:"name"`
 

config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdateruns.yaml

@@ -26,10 +26,6 @@ spec:
     - jsonPath: .spec.resourceSnapshotIndex
       name: Resource-Snapshot
       type: string
-    - jsonPath: .spec.stagedRolloutStrategyName
-      name: Strategy
-      priority: 1
-      type: string
     - jsonPath: .status.policySnapshotIndexUsed
       name: Policy-Snapshot
       type: string
@@ -42,6 +38,10 @@ spec:
     - jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
+    - jsonPath: .spec.stagedRolloutStrategyName
+      name: Strategy
+      priority: 1
+      type: string
     name: v1alpha1
     schema:
       openAPIV3Schema:
@@ -884,7 +884,7 @@ spec:
                           description: The name of the stage. This MUST be unique
                             within the same StagedUpdateStrategy.
                           maxLength: 63
-                          pattern: '[A-Za-z0-9]+$'
+                          pattern: ^[a-z0-9]+$
                           type: string
                         sortingLabelKey:
                           description: |-
@@ -1232,6 +1232,9 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 127
+          rule: size(self.metadata.name) < 128
     served: true
     storage: false
     subresources:
@@ -1243,10 +1246,6 @@ spec:
     - jsonPath: .spec.resourceSnapshotIndex
       name: Resource-Snapshot
       type: string
-    - jsonPath: .spec.stagedRolloutStrategyName
-      name: Strategy
-      priority: 1
-      type: string
     - jsonPath: .status.policySnapshotIndexUsed
       name: Policy-Snapshot
       type: string
@@ -1259,6 +1258,10 @@ spec:
     - jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
+    - jsonPath: .spec.stagedRolloutStrategyName
+      name: Strategy
+      priority: 1
+      type: string
     name: v1beta1
     schema:
       openAPIV3Schema:
@@ -2101,7 +2104,7 @@ spec:
                           description: The name of the stage. This MUST be unique
                             within the same StagedUpdateStrategy.
                           maxLength: 63
-                          pattern: '[A-Za-z0-9]+$'
+                          pattern: ^[a-z0-9]+$
                           type: string
                         sortingLabelKey:
                           description: |-
@@ -2449,6 +2452,9 @@ spec:
         required:
         - spec
         type: object
+        x-kubernetes-validations:
+        - message: metadata.name max length is 127
+          rule: size(self.metadata.name) < 128
     served: true
     storage: true
     subresources:

config/crd/bases/placement.kubernetes-fleet.io_clusterstagedupdatestrategies.yaml

@@ -134,7 +134,7 @@ spec:
                       description: The name of the stage. This MUST be unique within
                         the same StagedUpdateStrategy.
                       maxLength: 63
-                      pattern: '[A-Za-z0-9]+$'
+                      pattern: ^[a-z0-9]+$
                       type: string
                     sortingLabelKey:
                       description: |-
@@ -273,7 +273,7 @@ spec:
                       description: The name of the stage. This MUST be unique within
                         the same StagedUpdateStrategy.
                       maxLength: 63
-                      pattern: '[A-Za-z0-9]+$'
+                      pattern: ^[a-z0-9]+$
                       type: string
                     sortingLabelKey:
                       description: |-