add svc export health check

Author: britaniar

Makefile

@@ -27,7 +27,7 @@ CLUSTER_CONFIG := $(abspath test/e2e/v1alpha1/kind-config.yaml)
 # Binaries
 # Note: Need to use abspath so we can invoke these from subdirectories
 
-CONTROLLER_GEN_VER := v0.15.0
+CONTROLLER_GEN_VER := v0.16.0
 CONTROLLER_GEN_BIN := controller-gen
 CONTROLLER_GEN := $(abspath $(TOOLS_BIN_DIR)/$(CONTROLLER_GEN_BIN)-$(CONTROLLER_GEN_VER))
 

apis/placement/v1/clusterresourceplacement_types.go

@@ -664,7 +664,6 @@ type ResourcePlacementStatus struct {
 // FailedResourcePlacement contains the failure details of a failed resource placement.
 type FailedResourcePlacement struct {
 	// The resource failed to be placed.
-	// +required
 	ResourceIdentifier `json:",inline"`
 
 	// The failed condition status.

apis/placement/v1alpha1/override_types.go

@@ -97,7 +97,6 @@ type OverrideRule struct {
 
 	// JSONPatchOverrides defines a list of JSON patch override rules.
 	// This field is only allowed when OverrideType is JSONPatch.
-	// +kubebuilder:validation:Required
 	// +kubebuilder:validation:MinItems=1
 	// +kubebuilder:validation:MaxItems=20
 	// +optional

apis/placement/v1beta1/clusterresourceplacement_types.go

@@ -951,7 +951,6 @@ type ResourcePlacementStatus struct {
 // FailedResourcePlacement contains the failure details of a failed resource placement.
 type FailedResourcePlacement struct {
 	// The resource failed to be placed.
-	// +kubebuilder:validation:Required
 	ResourceIdentifier `json:",inline"`
 
 	// The failed condition status.
@@ -986,7 +985,6 @@ type PatchDetail struct {
 // DriftedResourcePlacement contains the details of a resource with configuration drifts.
 type DriftedResourcePlacement struct {
 	// The resource that has drifted.
-	// +kubebuilder:validation:Required
 	ResourceIdentifier `json:",inline"`
 
 	// ObservationTime is the time when we observe the configuration drifts for the resource.
@@ -1021,7 +1019,6 @@ type DriftedResourcePlacement struct {
 // DiffedResourcePlacement contains the details of a resource with configuration differences.
 type DiffedResourcePlacement struct {
 	// The resource that has drifted.
-	// +kubebuilder:validation:Required
 	ResourceIdentifier `json:",inline"`
 
 	// ObservationTime is the time when we observe the configuration differences for the resource.

apis/v1alpha1/clusterresourceplacement_types.go

@@ -160,7 +160,7 @@ type ClusterResourcePlacementStatus struct {
 // ResourceIdentifier identifies one Kubernetes resource.
 type ResourceIdentifier struct {
 	// Group is the group name of the selected resource.
-	// +required
+	// +optional
 	Group string `json:"group,omitempty"`
 
 	// Version is the version of the selected resource.
@@ -183,7 +183,6 @@ type ResourceIdentifier struct {
 // FailedResourcePlacement contains the failure details of a failed resource placement.
 type FailedResourcePlacement struct {
 	// The resource failed to be placed.
-	// +required
 	ResourceIdentifier `json:",inline"`
 
 	// Name of the member cluster that the resource is placed to.

cmd/hubagent/options/ratelimit.go

@@ -37,7 +37,7 @@ func (o *RateLimitOptions) AddFlags(fs *flag.FlagSet) {
 }
 
 // DefaultControllerRateLimiter provide a default rate limiter for controller, and users can tune it by corresponding flags.
-func DefaultControllerRateLimiter(opts RateLimitOptions) workqueue.RateLimiter {
+func DefaultControllerRateLimiter(opts RateLimitOptions) workqueue.TypedRateLimiter[any] {
 	// set defaults
 	if opts.RateLimiterBaseDelay <= 0 {
 		opts.RateLimiterBaseDelay = 5 * time.Millisecond
@@ -51,8 +51,8 @@ func DefaultControllerRateLimiter(opts RateLimitOptions) workqueue.RateLimiter {
 	if opts.RateLimiterBucketSize <= 0 {
 		opts.RateLimiterBucketSize = 100
 	}
-	return workqueue.NewMaxOfRateLimiter(
-		workqueue.NewItemExponentialFailureRateLimiter(opts.RateLimiterBaseDelay, opts.RateLimiterMaxDelay),
-		&workqueue.BucketRateLimiter{Limiter: rate.NewLimiter(rate.Limit(opts.RateLimiterQPS), opts.RateLimiterBucketSize)},
+	return workqueue.NewTypedMaxOfRateLimiter[any](
+		workqueue.NewTypedItemExponentialFailureRateLimiter[any](opts.RateLimiterBaseDelay, opts.RateLimiterMaxDelay),
+		&workqueue.TypedBucketRateLimiter[any]{Limiter: rate.NewLimiter(rate.Limit(opts.RateLimiterQPS), opts.RateLimiterBucketSize)},
 	)
 }

config/crd/bases/cluster.kubernetes-fleet.io_internalmemberclusters.yaml

@@ -3,7 +3,7 @@ apiVersion: apiextensions.k8s.io/v1
 kind: CustomResourceDefinition
 metadata:
   annotations:
-    controller-gen.kubebuilder.io/version: v0.15.0
+    controller-gen.kubebuilder.io/version: v0.16.0
   name: internalmemberclusters.cluster.kubernetes-fleet.io
 spec:
   group: cluster.kubernetes-fleet.io
@@ -80,18 +80,8 @@ spec:
                       description: Conditions is an array of current observed conditions
                         for the member agent.
                       items:
-                        description: "Condition contains details for one aspect of
-                          the current state of this API Resource.\n---\nThis struct
-                          is intended for direct use as an array at the field path
-                          .status.conditions.  For example,\n\n\n\ttype FooStatus
-                          struct{\n\t    // Represents the observations of a foo's
-                          current state.\n\t    // Known .status.conditions.type are:
-                          \"Available\", \"Progressing\", and \"Degraded\"\n\t    //
-                          +patchMergeKey=type\n\t    // +patchStrategy=merge\n\t    //
-                          +listType=map\n\t    // +listMapKey=type\n\t    Conditions
-                          []metav1.Condition `json:\"conditions,omitempty\" patchStrategy:\"merge\"
-                          patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"`\n\n\n\t
-                          \   // other fields\n\t}"
+                        description: Condition contains details for one aspect of
+                          the current state of this API Resource.
                         properties:
                           lastTransitionTime:
                             description: |-
@@ -133,12 +123,7 @@ spec:
                             - Unknown
                             type: string
                           type:
-                            description: |-
-                              type of condition in CamelCase or in foo.example.com/CamelCase.
-                              ---
-                              Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
-                              useful (see .node.status.conditions), the ability to deconflict is important.
-                              The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
+                            description: type of condition in CamelCase or in foo.example.com/CamelCase.
                             maxLength: 316
                             pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
                             type: string
@@ -169,16 +154,8 @@ spec:
                 description: Conditions is an array of current observed conditions
                   for the member cluster.
                 items:
-                  description: "Condition contains details for one aspect of the current
-                    state of this API Resource.\n---\nThis struct is intended for
-                    direct use as an array at the field path .status.conditions.  For
-                    example,\n\n\n\ttype FooStatus struct{\n\t    // Represents the
-                    observations of a foo's current state.\n\t    // Known .status.conditions.type
-                    are: \"Available\", \"Progressing\", and \"Degraded\"\n\t    //
-                    +patchMergeKey=type\n\t    // +patchStrategy=merge\n\t    // +listType=map\n\t
-                    \   // +listMapKey=type\n\t    Conditions []metav1.Condition `json:\"conditions,omitempty\"
-                    patchStrategy:\"merge\" patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"`\n\n\n\t
-                    \   // other fields\n\t}"
+                  description: Condition contains details for one aspect of the current
+                    state of this API Resource.
                   properties:
                     lastTransitionTime:
                       description: |-
@@ -219,12 +196,7 @@ spec:
                       - Unknown
                       type: string
                     type:
-                      description: |-
-                        type of condition in CamelCase or in foo.example.com/CamelCase.
-                        ---
-                        Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
-                        useful (see .node.status.conditions), the ability to deconflict is important.
-                        The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
                       maxLength: 316
                       pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
                       type: string
@@ -249,7 +221,6 @@ spec:
                       description: |-
                         Value is the value of the cluster property.
 
-
                         Currently, it should be a valid Kubernetes quantity.
                         For more information, see
                         https://pkg.go.dev/k8s.io/apimachinery/pkg/api/resource#Quantity.
@@ -261,7 +232,6 @@ spec:
                 description: |-
                   Properties is an array of properties observed for the member cluster.
 
-
                   This field is beta-level; it is for the property-based scheduling feature and is only
                   populated when a property provider is enabled in the deployment.
                 type: object
@@ -279,12 +249,10 @@ spec:
                     description: |-
                       Allocatable represents the total allocatable resources of all the nodes on a member cluster.
 
-
                       A node's allocatable capacity is the amount of resource that can actually be used
                       for user workloads, i.e.,
                       allocatable capacity = total capacity - capacities reserved for the OS, kubelet, etc.
 
-
                       For more information, see
                       https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/.
                     type: object
@@ -298,11 +266,9 @@ spec:
                     description: |-
                       Available represents the total available resources of all the nodes on a member cluster.
 
-
                       A node's available capacity is the amount of resource that has not been used yet, i.e.,
                       available capacity = allocatable capacity - capacity that has been requested by workloads.
 
-
                       This field is beta-level; it is for the property-based scheduling feature and is only
                       populated when a property provider is enabled in the deployment.
                     type: object
@@ -316,7 +282,6 @@ spec:
                     description: |-
                       Capacity represents the total resource capacity of all the nodes on a member cluster.
 
-
                       A node's total capacity is the amount of resource installed on the node.
                     type: object
                   observationTime:
@@ -393,18 +358,8 @@ spec:
                       description: Conditions is an array of current observed conditions
                         for the member agent.
                       items:
-                        description: "Condition contains details for one aspect of
-                          the current state of this API Resource.\n---\nThis struct
-                          is intended for direct use as an array at the field path
-                          .status.conditions.  For example,\n\n\n\ttype FooStatus
-                          struct{\n\t    // Represents the observations of a foo's
-                          current state.\n\t    // Known .status.conditions.type are:
-                          \"Available\", \"Progressing\", and \"Degraded\"\n\t    //
-                          +patchMergeKey=type\n\t    // +patchStrategy=merge\n\t    //
-                          +listType=map\n\t    // +listMapKey=type\n\t    Conditions
-                          []metav1.Condition `json:\"conditions,omitempty\" patchStrategy:\"merge\"
-                          patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"`\n\n\n\t
-                          \   // other fields\n\t}"
+                        description: Condition contains details for one aspect of
+                          the current state of this API Resource.
                         properties:
                           lastTransitionTime:
                             description: |-
@@ -446,12 +401,7 @@ spec:
                             - Unknown
                             type: string
                           type:
-                            description: |-
-                              type of condition in CamelCase or in foo.example.com/CamelCase.
-                              ---
-                              Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
-                              useful (see .node.status.conditions), the ability to deconflict is important.
-                              The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
+                            description: type of condition in CamelCase or in foo.example.com/CamelCase.
                             maxLength: 316
                             pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
                             type: string
@@ -482,16 +432,8 @@ spec:
                 description: Conditions is an array of current observed conditions
                   for the member cluster.
                 items:
-                  description: "Condition contains details for one aspect of the current
-                    state of this API Resource.\n---\nThis struct is intended for
-                    direct use as an array at the field path .status.conditions.  For
-                    example,\n\n\n\ttype FooStatus struct{\n\t    // Represents the
-                    observations of a foo's current state.\n\t    // Known .status.conditions.type
-                    are: \"Available\", \"Progressing\", and \"Degraded\"\n\t    //
-                    +patchMergeKey=type\n\t    // +patchStrategy=merge\n\t    // +listType=map\n\t
-                    \   // +listMapKey=type\n\t    Conditions []metav1.Condition `json:\"conditions,omitempty\"
-                    patchStrategy:\"merge\" patchMergeKey:\"type\" protobuf:\"bytes,1,rep,name=conditions\"`\n\n\n\t
-                    \   // other fields\n\t}"
+                  description: Condition contains details for one aspect of the current
+                    state of this API Resource.
                   properties:
                     lastTransitionTime:
                       description: |-
@@ -532,12 +474,7 @@ spec:
                       - Unknown
                       type: string
                     type:
-                      description: |-
-                        type of condition in CamelCase or in foo.example.com/CamelCase.
-                        ---
-                        Many .condition.type values are consistent across resources like Available, but because arbitrary conditions can be
-                        useful (see .node.status.conditions), the ability to deconflict is important.
-                        The regex it matches is (dns1123SubdomainFmt/)?(qualifiedNameFmt)
+                      description: type of condition in CamelCase or in foo.example.com/CamelCase.
                       maxLength: 316
                       pattern: ^([a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*/)?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])$
                       type: string
@@ -562,7 +499,6 @@ spec:
                       description: |-
                         Value is the value of the cluster property.
 
-
                         Currently, it should be a valid Kubernetes quantity.
                         For more information, see
                         https://pkg.go.dev/k8s.io/apimachinery/pkg/api/resource#Quantity.
@@ -574,7 +510,6 @@ spec:
                 description: |-
                   Properties is an array of properties observed for the member cluster.
 
-
                   This field is beta-level; it is for the property-based scheduling feature and is only
                   populated when a property provider is enabled in the deployment.
                 type: object
@@ -592,12 +527,10 @@ spec:
                     description: |-
                       Allocatable represents the total allocatable resources of all the nodes on a member cluster.
 
-
                       A node's allocatable capacity is the amount of resource that can actually be used
                       for user workloads, i.e.,
                       allocatable capacity = total capacity - capacities reserved for the OS, kubelet, etc.
 
-
                       For more information, see
                       https://kubernetes.io/docs/tasks/administer-cluster/reserve-compute-resources/.
                     type: object
@@ -611,11 +544,9 @@ spec:
                     description: |-
                       Available represents the total available resources of all the nodes on a member cluster.
 
-
                       A node's available capacity is the amount of resource that has not been used yet, i.e.,
                       available capacity = allocatable capacity - capacity that has been requested by workloads.
 
-
                       This field is beta-level; it is for the property-based scheduling feature and is only
                       populated when a property provider is enabled in the deployment.
                     type: object
@@ -629,7 +560,6 @@ spec:
                     description: |-
                       Capacity represents the total resource capacity of all the nodes on a member cluster.
 
-
                       A node's total capacity is the amount of resource installed on the node.
                     type: object
                   observationTime: