fix: fix azurePropertyCheckerOptions not correctly passin (#1236)

Author: jwtty

cmd/hubagent/options/azureoptions.go

@@ -16,16 +16,8 @@ type AzurePropertyCheckerOptions struct {
 	ComputeServiceAddressWithBasePath string
 }
 
-// NewAzurePropertyCheckerOptions creates a new AzurePropertyCheckerOptions with default values.
-func NewAzurePropertyCheckerOptions() AzurePropertyCheckerOptions {
-	return AzurePropertyCheckerOptions{
-		IsEnabled:                         false,
-		ComputeServiceAddressWithBasePath: "http://localhost:8421/compute",
-	}
-}
-
 // AddFlags adds flags for Azure Property Checker options to the given FlagSet.
-func (o AzurePropertyCheckerOptions) AddFlags(flags *flag.FlagSet) {
-	flags.BoolVar(&o.IsEnabled, "azure-property-checker-enabled", o.IsEnabled, "Enable Azure property checker for validating Azure-specific cluster properties.")
-	flags.StringVar(&o.ComputeServiceAddressWithBasePath, "azure-compute-server-address", o.ComputeServiceAddressWithBasePath, "The address of the Azure compute service with base path.")
+func (o *AzurePropertyCheckerOptions) AddFlags(flags *flag.FlagSet) {
+	flags.BoolVar(&o.IsEnabled, "azure-property-checker-enabled", false, "Enable Azure property checker for validating Azure-specific cluster properties.")
+	flags.StringVar(&o.ComputeServiceAddressWithBasePath, "azure-compute-server-address", "http://localhost:8421/compute", "The address of the Azure compute service with base path.")
 }

cmd/hubagent/options/options.go

@@ -136,7 +136,6 @@ func NewOptions() *Options {
 		PprofPort:                               6065,
 		ResourceSnapshotCreationMinimumInterval: 30 * time.Second,
 		ResourceChangesCollectionDuration:       15 * time.Second,
-		AzurePropertyCheckerOpts:                NewAzurePropertyCheckerOptions(),
 	}
 }
 

go.mod

@@ -11,7 +11,6 @@ require (
 	github.com/gofrs/uuid v4.4.0+incompatible
 	github.com/google/go-cmp v0.7.0
 	github.com/grpc-ecosystem/grpc-gateway/v2 v2.20.0
-	github.com/kubefleet-dev/kubefleet v0.0.1
 	github.com/onsi/ginkgo/v2 v2.23.4
 	github.com/onsi/gomega v1.37.0
 	github.com/prometheus/client_golang v1.22.0

go.sum

@@ -203,8 +203,6 @@ github.com/kr/pretty v0.3.1 h1:flRD4NNwYAUpkphVc1HcthR4KEIFJ65n8Mw5qdRn3LE=
 github.com/kr/pretty v0.3.1/go.mod h1:hoEshYVHaxMs3cyo3Yncou5ZscifuDolrwPKZanG3xk=
 github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY=
 github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE=
-github.com/kubefleet-dev/kubefleet v0.0.1 h1:Xo/DvRlKq7YLvzjGp8GFD8G6SLAyI41l4Sw4+df534g=
-github.com/kubefleet-dev/kubefleet v0.0.1/go.mod h1:EXicokCzLknCzcpQ/8ehtXqBokr0/xUfzsSsU++rReY=
 github.com/kylelemons/godebug v1.1.0 h1:RPNrshWIDI6G2gRW9EHilWtl7Z6Sb1BR0xunSBf0SNc=
 github.com/kylelemons/godebug v1.1.0/go.mod h1:9/0rRGxNHcop5bhtWyNeEfOS8JIWk580+fNqagV/RAw=
 github.com/leodido/go-urn v1.4.0 h1:WT9HwE9SGECu3lg4d/dIA+jxlljEa1/ffXKmRjqdmIQ=