fix: update vap to bypass openshift-kube-controller-manager on openshift clusters (#1208)

ryanzhang-oss · web-flow · commit a71b0f3cb0c7 · 2025-10-07T09:55:23.000-07:00
diff --git a/pkg/webhook/managedresource/validatingadmissionpolicy.go b/pkg/webhook/managedresource/validatingadmissionpolicy.go
@@ -75,7 +75,7 @@ func mutateValidatingAdmissionPolicy(vap *admv1.ValidatingAdmissionPolicy, isHub
 		},
 		Validations: []admv1.Validation{
 			{
-				Expression: `"system:masters" in request.userInfo.groups || "system:serviceaccounts:kube-system" in request.userInfo.groups || "system:serviceaccounts:fleet-system" in request.userInfo.groups`,
+				Expression: `"system:masters" in request.userInfo.groups || "system:serviceaccounts:kube-system" in request.userInfo.groups || "system:serviceaccounts:fleet-system" in request.userInfo.groups || "system:serviceaccounts:openshift-kube-controller-manager" in request.userInfo.groups`,
 				Message:    "Create, Update, or Delete operations on ARM managed resources is forbidden",
 				Reason:     &forbidden,
 			},

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func mutateValidatingAdmissionPolicy(vap *admv1.ValidatingAdmissionPolicy, isHub`
`75`	`75`	`},`
`76`	`76`	`Validations: []admv1.Validation{`
`77`	`77`	`{`
`78`		- Expression: `"system:masters" in request.userInfo.groups \|\| "system:serviceaccounts:kube-system" in request.userInfo.groups \|\| "system:serviceaccounts:fleet-system" in request.userInfo.groups`,
	`78`	+ Expression: `"system:masters" in request.userInfo.groups \|\| "system:serviceaccounts:kube-system" in request.userInfo.groups \|\| "system:serviceaccounts:fleet-system" in request.userInfo.groups \|\| "system:serviceaccounts:openshift-kube-controller-manager" in request.userInfo.groups`,
`79`	`79`	`Message: "Create, Update, or Delete operations on ARM managed resources is forbidden",`
`80`	`80`	`Reason: &forbidden,`
`81`	`81`	`},`