fix UTs

Signed-off-by: Britania Rodriguez Reyes <[email protected]>

Author: britaniar

pkg/propertychecker/azure/checker_test.go

@@ -72,11 +72,10 @@ func TestValidateCapacity(t *testing.T) {
 			errorSubstring: "invalid capacity value",
 		},
 		{
-			name:           "invalid value of zero for capacity",
-			value:          "0",
-			operator:       placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
-			wantError:      true,
-			errorSubstring: fmt.Sprintf("capacity value cannot be below minimum %d after adjustment", minVMInstanceCapacity),
+			name:      "invalid value of zero for capacity replaced with minimum",
+			value:     "0",
+			operator:  placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
+			wantValue: 1,
 		},
 		{
 			name:           "capacity equal to max limit with GreaterThan operator",
@@ -86,12 +85,10 @@ func TestValidateCapacity(t *testing.T) {
 			errorSubstring: "exceeds maximum allowed value",
 		},
 		{
-			name:           "unsupported operator with capacity of 1",
-			value:          "1",
-			operator:       placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
-			wantValue:      0,
-			wantError:      true,
-			errorSubstring: fmt.Sprintf("capacity value cannot be below minimum %d after adjustment", minVMInstanceCapacity),
+			name:      "capacity at minimum limit with GreaterThanOrEqualTo operator",
+			value:     "1",
+			operator:  placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
+			wantValue: 1,
 		},
 		{
 			name:      "capacity equal to max limit with supported operator",
@@ -187,9 +184,8 @@ func TestExtractCapacityRequirements(t *testing.T) {
 				Operator: placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
 				Values:   []string{"1"},
 			},
-			wantSKU:        "Standard_B2ms",
-			wantError:      true,
-			errorSubstring: fmt.Sprintf("capacity value cannot be below minimum %d after adjustment", minVMInstanceCapacity),
+			wantSKU:           "Standard_B2ms",
+			wantCapacityValue: 1,
 		},
 		{
 			name: "invalid Azure SKU capacity property with decimal",
@@ -421,18 +417,17 @@ func TestCheckIfMeetSKUCapacityRequirement(t *testing.T) {
 			errorSubstring: "unsupported operator \"Eq\" for SKU capacity property, only GreaterThan (Gt) and GreaterThanOrEqualTo (Ge) are supported",
 		},
 		{
-			name:           "invalid value in requirement",
+			name:           "too low value in requirement replaced with minimum capacity",
 			cluster:        cluster,
 			sku:            validSKU,
-			targetCapacity: 0,
+			targetCapacity: 1,
 			req: placementv1beta1.PropertySelectorRequirement{
 				Name:     fmt.Sprintf(azure.CapacityPerSKUPropertyTmpl, validSKU),
 				Operator: placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
 				Values:   []string{"0"},
 			},
 			mockStatusCode: http.StatusOK,
-			wantError:      true,
-			errorSubstring: fmt.Sprintf("capacity value cannot be below minimum %d after adjustment", minVMInstanceCapacity),
+			wantAvailable:  true,
 		},
 		{
 			name:           "cases-insensitive request - available SKU",

pkg/scheduler/framework/plugins/clusteraffinity/types_test.go

@@ -1360,7 +1360,7 @@ func TestClusterRequirementMatches_WithPropertyChecker(t *testing.T) {
 			want:           true,
 		},
 		{
-			name: "op >=, not matched (min limit)",
+			name: "op >=, matched (min limit)",
 			matchExpression: []placementv1beta1.PropertySelectorRequirement{
 				{
 					Name:     validPropertyName,
@@ -1372,8 +1372,8 @@ func TestClusterRequirementMatches_WithPropertyChecker(t *testing.T) {
 			},
 			cluster:        cluster,
 			sku:            "Standard_D2s_v3",
-			targetCapacity: 0,
-			wantError:      true,
+			targetCapacity: 1,
+			want:           true,
 		},
 		{
 			name: "op >, not matched",