address comments

Signed-off-by: Britania Rodriguez Reyes <[email protected]>

Author: britaniar

pkg/propertychecker/azure/checker.go

@@ -80,7 +80,7 @@ func (s *PropertyChecker) CheckIfMeetSKUCapacityRequirement(
 	}
 
 	// Request VM size recommendations to validate SKU availability and capacity.
-	// The capacity is checked by ensuring the current allocatable capacity is greater than or equals to the requested capacity.
+	// The capacity is checked by ensuring the current allocatable capacity is greater than or equal to the requested capacity.
 	klog.V(2).Infof("Checking SKU %s with capacity %d in cluster %s", sku, capacity, cluster.Name)
 	request := &computev1.GenerateAttributeBasedRecommendationsRequest{
 		SubscriptionId: subID,

pkg/propertychecker/azure/checker_test.go

@@ -85,12 +85,6 @@ func TestValidateCapacity(t *testing.T) {
 			wantError:      true,
 			errorSubstring: "exceeds maximum allowed value",
 		},
-		{
-			name:      "capacity at minimum limit with GreaterThanOrEqualTo operator",
-			value:     "1",
-			operator:  placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
-			wantValue: 1,
-		},
 		{
 			name:      "capacity equal to max limit with supported operator",
 			value:     "200",
@@ -107,9 +101,9 @@ func TestValidateCapacity(t *testing.T) {
 		},
 		{
 			name:      "capacity at minimum limit (Gt)",
-			value:     "1",
+			value:     "0",
 			operator:  placementv1beta1.PropertySelectorGreaterThan,
-			wantValue: 2,
+			wantValue: 1,
 			wantError: false,
 		},
 		{
@@ -179,7 +173,7 @@ func TestExtractCapacityRequirements(t *testing.T) {
 			errorSubstring: "exceeds maximum allowed value of 200",
 		},
 		{
-			name: "invalid Azure SKU capacity property below min limit",
+			name: "invalid Azure SKU capacity property below min limit (Ge)",
 			req: placementv1beta1.PropertySelectorRequirement{
 				Name:     fmt.Sprintf(azure.CapacityPerSKUPropertyTmpl, "Standard_B2ms"),
 				Operator: placementv1beta1.PropertySelectorGreaterThanOrEqualTo,
@@ -422,7 +416,7 @@ func TestCheckIfMeetSKUCapacityRequirement(t *testing.T) {
 			name:           "too low value in requirement",
 			cluster:        cluster,
 			sku:            validSKU,
-			targetCapacity: 1,
+			targetCapacity: 0,
 			req: placementv1beta1.PropertySelectorRequirement{
 				Name:     fmt.Sprintf(azure.CapacityPerSKUPropertyTmpl, validSKU),
 				Operator: placementv1beta1.PropertySelectorGreaterThanOrEqualTo,

pkg/scheduler/framework/plugins/clusteraffinity/types_test.go

@@ -1350,13 +1350,13 @@ func TestClusterRequirementMatches_WithPropertyChecker(t *testing.T) {
 					Name:     validPropertyName,
 					Operator: placementv1beta1.PropertySelectorGreaterThan,
 					Values: []string{
-						"1",
+						"0",
 					},
 				},
 			},
 			cluster:        cluster,
 			sku:            "Standard_D2s_v3",
-			targetCapacity: 2,
+			targetCapacity: 1,
 			want:           true,
 		},
 		{