[.NET] remove hardcoded client Id from samples whose connection strings already include client ids (#595)

Specifying 2 different client Ids crashed the app

Author: timtay-microsoft

dotnet/samples/CounterClient/RpcCommandRunner.cs

@@ -14,7 +14,7 @@ protected override async Task ExecuteAsync(CancellationToken stoppingToken)
     {
         try
         {
-            // MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration!.GetConnectionString("Default")! + ";ClientId=sampleClient-" + Environment.TickCount);
+            // MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration!.GetConnectionString("Default")!);
             MqttConnectionSettings mcs = MqttConnectionSettings.FromEnvVars();
 
             await mqttClient.ConnectAsync(mcs, stoppingToken);

dotnet/samples/SampleClient/RpcCommandRunner.cs

@@ -15,7 +15,7 @@ public class RpcCommandRunner(MqttSessionClient mqttClient, IServiceProvider ser
 {
     protected override async Task ExecuteAsync(CancellationToken stoppingToken)
     {
-        MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration!.GetConnectionString("Default")! + ";ClientId=sampleClient-" + Environment.TickCount);
+        MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration!.GetConnectionString("Default")!);
 
         await mqttClient.ConnectAsync(mcs, stoppingToken);
         await Console.Out.WriteLineAsync($"Connected to: {mcs}");

dotnet/samples/SessionClientConnectionManagementSample/LibraryManagedConnectionWorker.cs

@@ -15,7 +15,7 @@ protected override async Task ExecuteAsync(CancellationToken cancellationToken)
     {
         sessionClient.SessionLostAsync += OnCrash;
         sessionClient.ApplicationMessageReceivedAsync += OnMessageReceived;
-        MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration.GetConnectionString("Default")! + ";ClientId=LibraryManagedConnectionClient-" + Guid.NewGuid());
+        MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration.GetConnectionString("Default")!);
 
         await sessionClient.ConnectAsync(mcs, cancellationToken);
 

dotnet/samples/UserManagedConnectionManagementSample/UserManagedConnectionWorker.cs

@@ -15,7 +15,7 @@ public class UserManagedConnectionWorker(OrderedAckMqttClient mqttClient, ILogge
 
         protected override async Task ExecuteAsync(CancellationToken cancellationToken)
         {
-            MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration.GetConnectionString("Default")! + ";ClientId=UserManagedConnectionClient-" + Guid.NewGuid());
+            MqttConnectionSettings mcs = MqttConnectionSettings.FromConnectionString(configuration.GetConnectionString("Default")!);
 
             mqttClient.ApplicationMessageReceivedAsync += OnMessageReceived;
             mqttClient.DisconnectedAsync += OnDisconnect;