Fix latent codegen lint issues from PR 553 (#787)

Author: jrdouceur

codegen/src/Azure.Iot.Operations.ProtocolCompiler/T4/communication/dotnet/Service/t4/DotNetService.tt

@@ -53,8 +53,7 @@ namespace <#=this.projectName#>.<#=this.genNamespace.GetTypeName(TargetLanguage.
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
             /// for topic tokens such as "modelId" which should be the same for the duration of this service's lifetime. Note that
-            /// additional topic tokens can be specified when starting the service with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/> and
-            /// can be specified per-telemetry message.
+            /// additional topic tokens can be specified per-telemetry message.
             /// </param>
             public Service(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -139,20 +138,8 @@ namespace <#=this.projectName#>.<#=this.genNamespace.GetTypeName(TargetLanguage.
             /// <summary>
             /// Begin accepting command invocations for all command executors.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="preferredDispatchConcurrency">The dispatch concurrency count for the command response cache to use.</param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make command executors only
-            /// accept commands over a specific topic.
-            ///
-            /// Note that a given command executor can only be started with one set of topic token replacements. If you want a command executor
-            /// to only handle commands for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a command executor per topic token set.
-            /// </remarks>
             public async Task StartAsync(int? preferredDispatchConcurrency = null, CancellationToken cancellationToken = default)
             {
                 string? clientId = this.mqttClient.ClientId;
@@ -247,8 +234,7 @@ namespace <#=this.projectName#>.<#=this.genNamespace.GetTypeName(TargetLanguage.
             /// <param name="mqttClient">The MQTT client to use.</param>
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
-            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime. Note that
-            /// additional topic tokens can be specified when starting the client with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/>.
+            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime.
             /// </param>
             public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -298,6 +284,12 @@ namespace <#=this.projectName#>.<#=this.genNamespace.GetTypeName(TargetLanguage.
             /// <summary>
             /// Invoke a command.
             /// </summary>
+<# if (this.doesCommandTargetExecutor) { #>
+            /// <param name="executorId">The identifier of the executor targeted by this command request.</param>
+<# } #>
+<# if (cmdEnvoyInfo.RequestSchema != null) { #>
+            /// <param name="request">The data for this command request.</param>
+<# } #>
             /// <param name="requestMetadata">The metadata for this command request.</param>
             /// <param name="additionalTopicTokenMap">
             /// The topic token replacement map to use in addition to the topic tokens specified in the constructor. If this map
@@ -336,19 +328,7 @@ namespace <#=this.projectName#>.<#=this.genNamespace.GetTypeName(TargetLanguage.
             /// <summary>
             /// Begin accepting telemetry for all telemetry receivers.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make telemetry receivers only
-            /// accept telemetry over a specific topic.
-            ///
-            /// Note that a given telemetry receiver can only be started with one set of topic token replacements. If you want a telemetry receiver
-            /// to only handle telemetry for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a telemetry receiver per topic token set.
-            /// </remarks>
             public async Task StartAsync(CancellationToken cancellationToken = default)
             {
                 await Task.WhenAll(

dotnet/samples/Protocol/CloudEvents/Oven/Oven.g.cs

@@ -33,8 +33,7 @@ public abstract partial class Service : IAsyncDisposable
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
             /// for topic tokens such as "modelId" which should be the same for the duration of this service's lifetime. Note that
-            /// additional topic tokens can be specified when starting the service with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/> and
-            /// can be specified per-telemetry message.
+            /// additional topic tokens can be specified per-telemetry message.
             /// </param>
             public Service(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -109,8 +108,7 @@ public abstract partial class Client
             /// <param name="mqttClient">The MQTT client to use.</param>
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
-            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime. Note that
-            /// additional topic tokens can be specified when starting the client with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/>.
+            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime.
             /// </param>
             public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -134,19 +132,7 @@ public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClien
             /// <summary>
             /// Begin accepting telemetry for all telemetry receivers.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make telemetry receivers only
-            /// accept telemetry over a specific topic.
-            ///
-            /// Note that a given telemetry receiver can only be started with one set of topic token replacements. If you want a telemetry receiver
-            /// to only handle telemetry for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a telemetry receiver per topic token set.
-            /// </remarks>
             public async Task StartAsync(CancellationToken cancellationToken = default)
             {
                 await Task.WhenAll(

dotnet/samples/Protocol/ReadCloudEvents/Oven/Oven.g.cs

@@ -33,8 +33,7 @@ public abstract partial class Service : IAsyncDisposable
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
             /// for topic tokens such as "modelId" which should be the same for the duration of this service's lifetime. Note that
-            /// additional topic tokens can be specified when starting the service with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/> and
-            /// can be specified per-telemetry message.
+            /// additional topic tokens can be specified per-telemetry message.
             /// </param>
             public Service(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -109,8 +108,7 @@ public abstract partial class Client
             /// <param name="mqttClient">The MQTT client to use.</param>
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
-            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime. Note that
-            /// additional topic tokens can be specified when starting the client with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/>.
+            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime.
             /// </param>
             public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -134,19 +132,7 @@ public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClien
             /// <summary>
             /// Begin accepting telemetry for all telemetry receivers.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make telemetry receivers only
-            /// accept telemetry over a specific topic.
-            ///
-            /// Note that a given telemetry receiver can only be started with one set of topic token replacements. If you want a telemetry receiver
-            /// to only handle telemetry for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a telemetry receiver per topic token set.
-            /// </remarks>
             public async Task StartAsync(CancellationToken cancellationToken = default)
             {
                 await Task.WhenAll(

dotnet/samples/Protocol/TestEnvoys/Counter/Counter.g.cs

@@ -37,8 +37,7 @@ public abstract partial class Service : IAsyncDisposable
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
             /// for topic tokens such as "modelId" which should be the same for the duration of this service's lifetime. Note that
-            /// additional topic tokens can be specified when starting the service with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/> and
-            /// can be specified per-telemetry message.
+            /// additional topic tokens can be specified per-telemetry message.
             /// </param>
             public Service(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -113,20 +112,8 @@ public async Task SendTelemetryAsync(TelemetryCollection telemetry, OutgoingTele
             /// <summary>
             /// Begin accepting command invocations for all command executors.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="preferredDispatchConcurrency">The dispatch concurrency count for the command response cache to use.</param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make command executors only
-            /// accept commands over a specific topic.
-            ///
-            /// Note that a given command executor can only be started with one set of topic token replacements. If you want a command executor
-            /// to only handle commands for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a command executor per topic token set.
-            /// </remarks>
             public async Task StartAsync(int? preferredDispatchConcurrency = null, CancellationToken cancellationToken = default)
             {
                 string? clientId = this.mqttClient.ClientId;
@@ -200,8 +187,7 @@ public abstract partial class Client : IAsyncDisposable
             /// <param name="mqttClient">The MQTT client to use.</param>
             /// <param name="topicTokenMap">
             /// The topic token replacement map to use for all operations by default. Generally, this will include the token values
-            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime. Note that
-            /// additional topic tokens can be specified when starting the client with <see cref="StartAsync(Dictionary{string, string}?, int?, CancellationToken)"/>.
+            /// for topic tokens such as "modelId" which should be the same for the duration of this client's lifetime.
             /// </param>
             public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClient, Dictionary<string, string>? topicTokenMap = null)
             {
@@ -255,6 +241,7 @@ public Client(ApplicationContext applicationContext, IMqttPubSubClient mqttClien
             /// <summary>
             /// Invoke a command.
             /// </summary>
+            /// <param name="executorId">The identifier of the executor targeted by this command request.</param>
             /// <param name="requestMetadata">The metadata for this command request.</param>
             /// <param name="additionalTopicTokenMap">
             /// The topic token replacement map to use in addition to the topic tokens specified in the constructor. If this map
@@ -289,6 +276,8 @@ public RpcCallAsync<ReadCounterResponsePayload> ReadCounterAsync(string executor
             /// <summary>
             /// Invoke a command.
             /// </summary>
+            /// <param name="executorId">The identifier of the executor targeted by this command request.</param>
+            /// <param name="request">The data for this command request.</param>
             /// <param name="requestMetadata">The metadata for this command request.</param>
             /// <param name="additionalTopicTokenMap">
             /// The topic token replacement map to use in addition to the topic tokens specified in the constructor. If this map
@@ -323,6 +312,7 @@ public RpcCallAsync<IncrementResponsePayload> IncrementAsync(string executorId,
             /// <summary>
             /// Invoke a command.
             /// </summary>
+            /// <param name="executorId">The identifier of the executor targeted by this command request.</param>
             /// <param name="requestMetadata">The metadata for this command request.</param>
             /// <param name="additionalTopicTokenMap">
             /// The topic token replacement map to use in addition to the topic tokens specified in the constructor. If this map
@@ -357,19 +347,7 @@ public RpcCallAsync<EmptyJson> ResetAsync(string executorId, CommandRequestMetad
             /// <summary>
             /// Begin accepting telemetry for all telemetry receivers.
             /// </summary>
-            /// <param name="additionalTopicTokenMap">
-            /// The topic token replacements to use in addition to any topic tokens specified in the constructor. If this map
-            /// contains any keys that topic tokens provided in the constructor also has, then values specified in this map will take precedence.
-            /// </param>
             /// <param name="cancellationToken">Cancellation token.</param>
-            /// <remarks>
-            /// Specifying custom topic tokens in <paramref name="additionalTopicTokenMap"/> allows you to make telemetry receivers only
-            /// accept telemetry over a specific topic.
-            ///
-            /// Note that a given telemetry receiver can only be started with one set of topic token replacements. If you want a telemetry receiver
-            /// to only handle telemetry for several specific sets of topic token values (as opposed to all possible topic token values), then you will
-            /// instead need to create a telemetry receiver per topic token set.
-            /// </remarks>
             public async Task StartAsync(CancellationToken cancellationToken = default)
             {
                 await Task.WhenAll(