Skip to content

Commit f18cbd7

Browse files
authored
Merge pull request #336 from Azure/ipam-3.5.0
Azure IPAM v3.5.0 Updated Release
2 parents 4ebd644 + 9c4c9cc commit f18cbd7

File tree

12 files changed

+1416
-6252
lines changed

12 files changed

+1416
-6252
lines changed

deploy/deploy.ps1

Lines changed: 185 additions & 163 deletions
Large diffs are not rendered by default.

deploy/modules/containerRegistry.bicep

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,9 @@ param containerRegistryName string
77
@description('Managed Identity PrincipalId')
88
param principalId string
99

10-
@description('Role Assignment GUID')
11-
param roleAssignmentName string = newGuid()
12-
1310
var acrPull = '7f951dda-4ed3-4680-a7ca-43fe172d538d'
1411
var acrPullId = subscriptionResourceId('Microsoft.Authorization/roleDefinitions', acrPull)
12+
var acrPullRoleAssignmentId = guid(subscription().id, acrPull, principalId)
1513

1614
resource containerRegistry 'Microsoft.ContainerRegistry/registries@2021-12-01-preview' = {
1715
name: containerRegistryName
@@ -22,8 +20,7 @@ resource containerRegistry 'Microsoft.ContainerRegistry/registries@2021-12-01-pr
2220
}
2321

2422
resource roleAssignment 'Microsoft.Authorization/roleAssignments@2020-04-01-preview' = {
25-
#disable-next-line use-stable-resource-identifiers
26-
name: roleAssignmentName
23+
name: acrPullRoleAssignmentId
2724
scope: containerRegistry
2825
properties: {
2926
principalType: 'ServicePrincipal'

deploy/modules/managedIdentity.bicep

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,10 @@ param managedIdentityName string
66

77
var contributor = 'b24988ac-6180-42a0-ab88-20f7382dd24c'
88
var contributorId = subscriptionResourceId('Microsoft.Authorization/roleDefinitions', contributor)
9-
var contributorRoleAssignmentId = guid(contributor, managedIdentity.id, subscription().id)
9+
var contributorRoleAssignmentId = guid(subscription().id, contributor, managedIdentity.id)
1010
var managedIdentityOperator = 'f1a07417-d97a-45cb-824c-7a7467783830'
1111
var managedIdentityOperatorId = subscriptionResourceId('Microsoft.Authorization/roleDefinitions', managedIdentityOperator)
12-
var managedIdentityOperatorRoleAssignmentId = guid(managedIdentityOperator, managedIdentity.id, subscription().id)
12+
var managedIdentityOperatorRoleAssignmentId = guid(subscription().id, managedIdentityOperator, managedIdentity.id)
1313

1414
resource managedIdentity 'Microsoft.ManagedIdentity/userAssignedIdentities@2018-11-30' = {
1515
name: managedIdentityName

engine/app/routers/space.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1815,7 +1815,7 @@ async def create_external_network(
18151815
block_net_cidrs += prefixes
18161816

18171817
block_set = IPSet(block_net_cidrs)
1818-
resv_set = IPSet(x['cidr'] for x in target_block['resv'])
1818+
resv_set = IPSet(x['cidr'] for x in target_block['resv'] if not x['settledOn'])
18191819
external_set = IPSet(x['cidr'] for x in target_block['externals'])
18201820
available_set = IPSet([target_block['cidr']]) ^ (resv_set | external_set | block_set)
18211821

ui/.eslintrc

Lines changed: 0 additions & 37 deletions
This file was deleted.

ui/eslint.config.js

Lines changed: 45 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,45 @@
1+
import js from "@eslint/js";
2+
import globals from "globals";
3+
4+
import react from "eslint-plugin-react";
5+
import hooks from "eslint-plugin-react-hooks";
6+
import jest from "eslint-plugin-jest";
7+
8+
export default [
9+
js.configs.recommended,
10+
{
11+
files: ["src/**/*.jsx"],
12+
plugins: {
13+
react,
14+
"react-hooks": hooks,
15+
jest
16+
},
17+
settings: {
18+
react: {
19+
version: "detect",
20+
}
21+
},
22+
languageOptions: {
23+
parserOptions: {
24+
ecmaFeatures: {
25+
jsx: true,
26+
},
27+
ecmaVersion: 'latest',
28+
sourceType: 'module',
29+
},
30+
globals: {
31+
...globals.node,
32+
...globals.browser,
33+
...globals.jest
34+
}
35+
},
36+
rules: {
37+
"no-unused-vars": "off",
38+
"no-prototype-builtins": "off",
39+
"react/prop-types": "off",
40+
"react/display-name": "off",
41+
"react/no-unescaped-entities": "off",
42+
"no-constant-binary-expression": "off"
43+
},
44+
},
45+
];

0 commit comments

Comments
 (0)