Multiple wrong commands in setup.sh

[gillg]

Trying to reverse engineer the script setup.sh to understand how to use this plugin, I discovered mutiple commands wrong.

• notation key remove should be notation key delete

• notation cert remove should be notation cert delete

• notation key add --name $keyName --plugin azure-kv --id $keyID --kms should be notation key add --plugin azure-kv --id $keyID $keyName

• notation cert add --name $keyName --plugin azure-kv --id $keyID --kms is not usable at all... The cert should be a local PEM imported.
  Could eventualy be :

az keyvault certificate download --encoding PEM --name $keyName --vault-name $keyVaultName --file tmpcert.pem
notation cert add --store test --type signingAuthority tmpcert.pem

[FeynmanZhou]

Hi @gillg ,

Thanks for reporting this problem. This script looks outdated and should be updated to Notation RC.1. cc @duffney

[duffney]

Thanks for the mention @FeynmanZhou, I'll get the setup.sh updated with RC.1.

[duffney]

I've got the setup.sh updated, but ran into the same issue @gillg did with the cert add command. It doesn't look like it's used, but I'm looking into how I can add the cert from key vault. Once I figure that out, I'll submit a PR with the fixes.